Re: [PATCH] patch to compile grub2 in msys/mingw environment

2009-03-21 Thread Robert Millan
On Wed, Mar 18, 2009 at 09:43:33PM +0800, Bean wrote: > > The header file is included after grub_millisleep, so > Sleep is not defined yet, perhaps it'd be better to move #include > to the beginning of file. Agreed. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will

Re: [PATCH] patch to compile grub2 in msys/mingw environment

2009-03-21 Thread Bean
Committed. -- Bean ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] patch to compile grub2 in msys/mingw environment

2009-03-18 Thread Bean
On Wed, Mar 18, 2009 at 6:15 PM, Robert Millan wrote: > On Tue, Mar 17, 2009 at 01:54:22PM +0800, Bean wrote: >> > >> > It seems you defined the mingw32 version of grub_millisleep >> > unconditionally. >> >> Hi, >> >> Are you suggesting adding some test in configure.ac ? Although >> grub_millisle

Re: [PATCH] patch to compile grub2 in msys/mingw environment

2009-03-18 Thread Robert Millan
On Tue, Mar 17, 2009 at 01:54:22PM +0800, Bean wrote: > > > > It seems you defined the mingw32 version of grub_millisleep unconditionally. > > Hi, > > Are you suggesting adding some test in configure.ac ? Although > grub_millisleep for mingw32 uses Windows API Sleep, I guess it's safe > to assume

Re: [PATCH] patch to compile grub2 in msys/mingw environment

2009-03-16 Thread Bean
On Sun, Mar 15, 2009 at 11:40 PM, Robert Millan wrote: > On Sun, Mar 15, 2009 at 03:27:05AM +0800, Bean wrote: >> Hi, >> >> There are three issue related to msys/mingw environment. >> >> 1, no nanosleep in mingw, although, the windows API Sleep support >> millisecond. >> >> 2, Use stat on device

Re: [PATCH] patch to compile grub2 in msys/mingw environment

2009-03-15 Thread Robert Millan
On Sun, Mar 15, 2009 at 03:27:05AM +0800, Bean wrote: > Hi, > > There are three issue related to msys/mingw environment. > > 1, no nanosleep in mingw, although, the windows API Sleep support millisecond. > > 2, Use stat on device like //./PHYSICALDRIVE0 would fail. It should > use utility functi

[PATCH] patch to compile grub2 in msys/mingw environment

2009-03-14 Thread Bean
Hi, There are three issue related to msys/mingw environment. 1, no nanosleep in mingw, although, the windows API Sleep support millisecond. 2, Use stat on device like //./PHYSICALDRIVE0 would fail. It should use utility function grub_util_get_disk_size in read_device_map. 3, The ln command in m