Re: [PATCH] parser: Remove escape from the state transitions

2017-10-17 Thread Eric Snowberg
> On Oct 17, 2017, at 6:53 AM, Daniel Kiper wrote: > > On Mon, Oct 16, 2017 at 02:04:17PM -0600, Eric Snowberg wrote: >>> On Oct 16, 2017, at 2:44 AM, Daniel Kiper wrote: > > [...] > >>> I am a bit surprised that you are not able to quote a string but I will >>> give you some examples: >>> >

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-17 Thread Daniel Kiper
On Mon, Oct 16, 2017 at 02:04:17PM -0600, Eric Snowberg wrote: > > On Oct 16, 2017, at 2:44 AM, Daniel Kiper wrote: [...] > > I am a bit surprised that you are not able to quote a string but I will > > give you some examples: > > > > "/pci@306/pci@1/LSI\,mrsas@0/disk@0\,0" > > '/pci@306/pci@1/LS

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-16 Thread Eric Snowberg
> On Oct 16, 2017, at 2:44 AM, Daniel Kiper wrote: > > On Fri, Oct 13, 2017 at 08:53:23AM -0600, Eric Snowberg wrote: >>> On Oct 13, 2017, at 3:36 AM, Daniel Kiper wrote: >>> On Thu, Oct 12, 2017 at 08:38:51AM -0600, Eric Snowberg wrote: > On Oct 12, 2017, at 5:43 AM, Daniel Kiper wrote: >

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-16 Thread Daniel Kiper
On Fri, Oct 13, 2017 at 08:53:23AM -0600, Eric Snowberg wrote: > > On Oct 13, 2017, at 3:36 AM, Daniel Kiper wrote: > > On Thu, Oct 12, 2017 at 08:38:51AM -0600, Eric Snowberg wrote: > >>> On Oct 12, 2017, at 5:43 AM, Daniel Kiper wrote: > >>> On Mon, Oct 09, 2017 at 09:23:44AM -0600, Eric Snowbe

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-13 Thread Eric Snowberg
> On Oct 13, 2017, at 3:36 AM, Daniel Kiper wrote: > > On Thu, Oct 12, 2017 at 08:38:51AM -0600, Eric Snowberg wrote: >>> On Oct 12, 2017, at 5:43 AM, Daniel Kiper wrote: >>> On Mon, Oct 09, 2017 at 09:23:44AM -0600, Eric Snowberg wrote: > On Oct 9, 2017, at 5:48 AM, Daniel Kiper wrote: >>

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-13 Thread Daniel Kiper
On Thu, Oct 12, 2017 at 08:38:51AM -0600, Eric Snowberg wrote: > > On Oct 12, 2017, at 5:43 AM, Daniel Kiper wrote: > > On Mon, Oct 09, 2017 at 09:23:44AM -0600, Eric Snowberg wrote: > >>> On Oct 9, 2017, at 5:48 AM, Daniel Kiper wrote: > >>> On Fri, Oct 06, 2017 at 09:37:54AM -0600, Eric Snowber

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-12 Thread Eric Snowberg
> On Oct 12, 2017, at 5:43 AM, Daniel Kiper wrote: > > On Mon, Oct 09, 2017 at 09:23:44AM -0600, Eric Snowberg wrote: >>> On Oct 9, 2017, at 5:48 AM, Daniel Kiper wrote: >>> On Fri, Oct 06, 2017 at 09:37:54AM -0600, Eric Snowberg wrote: > On Oct 6, 2017, at 8:47 AM, Daniel Kiper wrote: >>>

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-12 Thread Daniel Kiper
On Mon, Oct 09, 2017 at 09:23:44AM -0600, Eric Snowberg wrote: > > On Oct 9, 2017, at 5:48 AM, Daniel Kiper wrote: > > On Fri, Oct 06, 2017 at 09:37:54AM -0600, Eric Snowberg wrote: > >>> On Oct 6, 2017, at 8:47 AM, Daniel Kiper wrote: > >>> On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-09 Thread Eric Snowberg
> On Oct 9, 2017, at 5:48 AM, Daniel Kiper wrote: > > On Fri, Oct 06, 2017 at 09:37:54AM -0600, Eric Snowberg wrote: >>> On Oct 6, 2017, at 8:47 AM, Daniel Kiper wrote: >>> On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_ST

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-09 Thread Daniel Kiper
On Fri, Oct 06, 2017 at 09:37:54AM -0600, Eric Snowberg wrote: > > On Oct 6, 2017, at 8:47 AM, Daniel Kiper wrote: > > On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: > >> Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_STATE_TEXT from > >> the list of not allowed characters. >

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-06 Thread Eric Snowberg
> On Oct 6, 2017, at 8:47 AM, Daniel Kiper wrote: > > On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: >> Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_STATE_TEXT from >> the list of not allowed characters. > > Once again, NACK for this patch. I explained why earlier but...

Re: [PATCH] parser: Remove escape from the state transitions

2017-10-06 Thread Daniel Kiper
On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: > Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_STATE_TEXT from > the list of not allowed characters. Once again, NACK for this patch. I explained why earlier but... > This fixes a problem where a properly escaped comma is in th

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-13 Thread Eric Snowberg
> On Jun 13, 2017, at 6:59 AM, Daniel Kiper wrote: > > On Wed, Jun 07, 2017 at 03:43:34PM -0600, Eric Snowberg wrote: >> >>> On Jun 7, 2017, at 3:36 PM, Daniel Kiper wrote: >>> >>> On Wed, Jun 07, 2017 at 02:48:04PM -0600, Eric Snowberg wrote: > On Jun 7, 2017, at 1:23 PM, Daniel Kiper w

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-13 Thread Daniel Kiper
On Wed, Jun 07, 2017 at 03:43:34PM -0600, Eric Snowberg wrote: > > > On Jun 7, 2017, at 3:36 PM, Daniel Kiper wrote: > > > > On Wed, Jun 07, 2017 at 02:48:04PM -0600, Eric Snowberg wrote: > >>> On Jun 7, 2017, at 1:23 PM, Daniel Kiper wrote: > >>> On Mon, Jun 05, 2017 at 08:29:47AM -0600, Eric Sn

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-07 Thread Eric Snowberg
> On Jun 7, 2017, at 3:36 PM, Daniel Kiper wrote: > > On Wed, Jun 07, 2017 at 02:48:04PM -0600, Eric Snowberg wrote: >>> On Jun 7, 2017, at 1:23 PM, Daniel Kiper wrote: >>> On Mon, Jun 05, 2017 at 08:29:47AM -0600, Eric Snowberg wrote: > On Jun 2, 2017, at 4:41 AM, Daniel Kiper wrote:

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-07 Thread Daniel Kiper
On Wed, Jun 07, 2017 at 02:48:04PM -0600, Eric Snowberg wrote: > > On Jun 7, 2017, at 1:23 PM, Daniel Kiper wrote: > > On Mon, Jun 05, 2017 at 08:29:47AM -0600, Eric Snowberg wrote: > >>> On Jun 2, 2017, at 4:41 AM, Daniel Kiper wrote: > >>> On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-07 Thread Eric Snowberg
> On Jun 7, 2017, at 1:23 PM, Daniel Kiper wrote: > > On Mon, Jun 05, 2017 at 08:29:47AM -0600, Eric Snowberg wrote: >>> On Jun 2, 2017, at 4:41 AM, Daniel Kiper wrote: >>> On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_ST

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-07 Thread Daniel Kiper
On Mon, Jun 05, 2017 at 08:29:47AM -0600, Eric Snowberg wrote: > > On Jun 2, 2017, at 4:41 AM, Daniel Kiper wrote: > > On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: > >> Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_STATE_TEXT from > >> the list of not allowed characters. >

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-05 Thread Eric Snowberg
> On Jun 2, 2017, at 4:41 AM, Daniel Kiper wrote: > > On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: >> Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_STATE_TEXT from >> the list of not allowed characters. >> >> This fixes a problem where a properly escaped comma is in the

Re: [PATCH] parser: Remove escape from the state transitions

2017-06-02 Thread Daniel Kiper
On Tue, May 30, 2017 at 04:07:52PM -0600, Eric Snowberg wrote: > Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_STATE_TEXT from > the list of not allowed characters. > > This fixes a problem where a properly escaped comma is in the disk path. > > For example: /pci@306/pci@1/LSI,mrsas@0/disk@0:

[PATCH] parser: Remove escape from the state transitions

2017-05-30 Thread Eric Snowberg
Remove GRUB_PARSER_STATE_ESC with state GRUB_PARSER_STATE_TEXT from the list of not allowed characters. This fixes a problem where a properly escaped comma is in the disk path. For example: /pci@306/pci@1/LSI,mrsas@0/disk@0:a During grub install, the search.fs_uuid is correctly stored in the cor