Re: [PATCH] more scripting fixes

2009-06-15 Thread Vladimir 'phcoder' Serbinenko
Comitted On Mon, Jun 15, 2009 at 5:22 PM, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Jun 13, 2009 at 10:15 PM, Pavel Roskin wrote: >> On Sat, 2009-06-13 at 00:34 +0200, Vladimir 'phcoder' Serbinenko wrote: >> >>> > It looks like \" cancels quoting for the subsequent characters, but it >>> > sh

Re: [PATCH] more scripting fixes

2009-06-15 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jun 13, 2009 at 10:15 PM, Pavel Roskin wrote: > On Sat, 2009-06-13 at 00:34 +0200, Vladimir 'phcoder' Serbinenko wrote: > >> > It looks like \" cancels quoting for the subsequent characters, but it >> > shouldn't. >> Actually the problem is different: escaping in quoting isn't parsed at >>

Re: [PATCH] more scripting fixes

2009-06-13 Thread Pavel Roskin
On Sat, 2009-06-13 at 00:34 +0200, Vladimir 'phcoder' Serbinenko wrote: > > It looks like \" cancels quoting for the subsequent characters, but it > > shouldn't. > Actually the problem is different: escaping in quoting isn't parsed at > all. For first step lexer uses rescue mode parser which isn't

Re: [PATCH] more scripting fixes

2009-06-12 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jun 13, 2009 at 12:10 AM, Pavel Roskin wrote: > On Wed, 2009-06-10 at 12:52 +0200, Vladimir 'phcoder' Serbinenko wrote: >> +       Fix handling of string like \"hello\" and "a >> +       b" >> + >> +       * script/sh/lexer.c (check_textstate): accept >> GRUB_PARSER_STATE_ESC >> +       (gr

Re: [PATCH] more scripting fixes

2009-06-12 Thread Pavel Roskin
On Wed, 2009-06-10 at 12:52 +0200, Vladimir 'phcoder' Serbinenko wrote: > + Fix handling of string like \"hello\" and "a > + b" > + > + * script/sh/lexer.c (check_textstate): accept > GRUB_PARSER_STATE_ESC > + (grub_script_yylex): fix parsing of quoting, escaping and > newli

[PATCH] more scripting fixes

2009-06-10 Thread Vladimir 'phcoder' Serbinenko
Hello. I discovered that the lines like echo \"hello\" and echo "a b" weren't parsed correctly. Here is a fix. I have tested it throughly yet -- Regards Vladimir 'phcoder' Serbinenko diff --git a/ChangeLog b/ChangeLog index 3eb4bfd..4b3bf75 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@