Re: [PATCH] mbi: use per segment a separate relocator chunk

2018-06-05 Thread Alexander Boettcher
On 15.05.2018 15:42, Daniel Kiper wrote: > On Mon, May 14, 2018 at 09:02:00PM +0200, Alexander Boettcher wrote: >>grub_relocator_chunk_t ch; >> - grub_uint32_t load_offset, load_size; >> + grub_uint32_t load_offset = 0, load_size; >>int i; >> - void *source; >> + void *source = NULL; >

Re: [PATCH] mbi: use per segment a separate relocator chunk

2018-05-16 Thread Daniel Kiper
On Tue, May 15, 2018 at 09:18:18PM +0200, Alexander Boettcher wrote: > On 15.05.2018 21:10, Alexander Boettcher wrote: > >>I assume that a given ELF PHDR address/size does not cover VGA memory or > >>anything like that, > > > >No. > > > >>so, I am not sure what exactly overwrites this region. > >>g

Re: [PATCH] mbi: use per segment a separate relocator chunk

2018-05-15 Thread Alexander Boettcher
On 15.05.2018 21:10, Alexander Boettcher wrote: I assume that a given ELF PHDR address/size does not cover VGA memory or anything like that, No. so, I am not sure what exactly overwrites this region. grub_memset() in current line 161 at some point? No. During grub_relocator_prepare_reloc t

Re: [PATCH] mbi: use per segment a separate relocator chunk

2018-05-15 Thread Alexander Boettcher
On 15.05.2018 15:42, Daniel Kiper wrote: On Mon, May 14, 2018 at 09:02:00PM +0200, Alexander Boettcher wrote: >From 8a0296d040a42950cd64e733f7997203975bc184 Mon Sep 17 00:00:00 2001 From: Alexander Boettcher Date: Fri, 13 Apr 2018 23:37:01 +0200 Subject: [PATCH] mbi: use per segment a separ

Re: [PATCH] mbi: use per segment a separate relocator chunk

2018-05-15 Thread Daniel Kiper
On Mon, May 14, 2018 at 09:02:00PM +0200, Alexander Boettcher wrote: > >From 8a0296d040a42950cd64e733f7997203975bc184 Mon Sep 17 00:00:00 2001 > From: Alexander Boettcher > Date: Fri, 13 Apr 2018 23:37:01 +0200 > Subject: [PATCH] mbi: use per segment a separate relocator chunk &g

[PATCH] mbi: use per segment a separate relocator chunk

2018-05-14 Thread Alexander Boettcher
rom: Alexander Boettcher Date: Fri, 13 Apr 2018 23:37:01 +0200 Subject: [PATCH] mbi: use per segment a separate relocator chunk if elf is non relocatable. If the segments are not dense packed, the original code set up a huge relocator chunk comprising all segments. During the final relocation