Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-27 Thread Felix Zielcke
Am Sonntag, den 27.07.2008, 15:03 +0200 schrieb Robert Millan: > Done. > Ok, the patch I sent you attached offlist, because the one I posted inline here onlist didn't work for you, had a missing #include "grub/term.h" Attached is a patch for it. I don't know if you want to leave changelog untouc

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-27 Thread Robert Millan
Done. On Sat, Jul 26, 2008 at 11:14:30AM +0200, Marco Gerards wrote: > Marco Gerards <[EMAIL PROTECTED]> writes: > > >> Felix Zielcke <[EMAIL PROTECTED]> > >> > >> > >>* commands/help.c: Include . > >>(TERM_WIDTH): Removed. Updated all uses. > > > > I would say "Updated all users." or

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-26 Thread Marco Gerards
Marco Gerards <[EMAIL PROTECTED]> writes: >> Felix Zielcke <[EMAIL PROTECTED]> >> >> >> * commands/help.c: Include . >> (TERM_WIDTH): Removed. Updated all uses. > > I would say "Updated all users." or perhaps even "Updated all > callers.". English is not my native language, hopefully

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-20 Thread Marco Gerards
"Felix Zielcke" <[EMAIL PROTECTED]> writes: > From: "Marco Gerards" <[EMAIL PROTECTED]> > >> >> It would be better to replace all users of TERM_WIDTH to use >> GRUB_TERM_WIDTH, like you mentioned. Only ugly thing is that this is >> actually a function... >> > > Here it is. > > > Felix Zielcke <[E

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-20 Thread Felix Zielcke
From: "Marco Gerards" <[EMAIL PROTECTED]> It would be better to replace all users of TERM_WIDTH to use GRUB_TERM_WIDTH, like you mentioned. Only ugly thing is that this is actually a function... Here it is. Felix Zielcke <[EMAIL PROTECTED]> * commands/help.c: Include . (

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-20 Thread Marco Gerards
"Felix Zielcke" <[EMAIL PROTECTED]> writes: > Thanks to nyu and daChaac on IRC By default with gfxterm loaded and > gfxmode set to 640*480 help command produces empty lines see [0] help > command assumes a fixed width of 80 but gfxterm in 640*480 has only 77 > > This is a patch to fix it. Here i

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-20 Thread Felix Zielcke
Felix Zielcke <[EMAIL PROTECTED]> * commands/help.c: Include . (TERM_WIDTH): Redefined to GRUB_TERM_WIDTH. Thanks to Marco for the help. I should have asked before, but i'm more a try and fail guy :) ___ Grub-devel mailing list Gru

Re: [PATCH] make assumed terminal width on cmd help dynamic

2008-07-20 Thread Felix Zielcke
From: "Felix Zielcke" <[EMAIL PROTECTED]> Sent: Sunday, July 20, 2008 3:47 PM To: Subject: [PATCH] make assumed terminal width on cmd help dynamic * commands/help.c: changed assumed terminal width from 80 to dynamic * commands/help.c: it was using a fixed terminal widt

[PATCH] make assumed terminal width on cmd help dynamic

2008-07-20 Thread Felix Zielcke
Thanks to nyu and daChaac on IRC By default with gfxterm loaded and gfxmode set to 640*480 help command produces empty lines see [0] help command assumes a fixed width of 80 but gfxterm in 640*480 has only 77 This is a patch to fix it. [0] http://img146.imageshack.us/my.php?image=otherlinux26x