Re: [PATCH] ls: prevent double open

2017-11-13 Thread John Paul Adrian Glaubitz
On 11/10/2017 10:35 PM, Daniel Kiper wrote: >> Ok, I’ll add a comment and submit a V2. > > I was going to apply this today but have not found v2... :-((( > If you post it I will apply it immediately. I think Eric didn't send a V2 patch yet. But since the only difference would be adding an additio

Re: [PATCH] ls: prevent double open

2017-11-10 Thread Daniel Kiper
On Wed, Oct 18, 2017 at 10:30:37AM -0600, Eric Snowberg wrote: > > On Oct 17, 2017, at 7:22 AM, Daniel Kiper wrote: > > On Mon, Oct 16, 2017 at 01:11:12PM -0700, Eric Snowberg wrote: > >> Prevent a double open. This can cause problems with some ieee1275 > >> devices, causing the system to hang.

Re: [PATCH] ls: prevent double open

2017-11-07 Thread Daniel Kiper
On Tue, Nov 07, 2017 at 10:17:34PM +0100, John Paul Adrian Glaubitz wrote: > Hi Daniel and Eric! > > Is there any progress on these patches? Vladimir had some concerns. Sadly he was ill last week and I was going to ping him this one. Vladimir? If he does not voice his opinion I will apply this pat

Re: [PATCH] ls: prevent double open

2017-11-07 Thread John Paul Adrian Glaubitz
Hi Daniel and Eric! Is there any progress on these patches? May I suggest that we continue with the remaining SPARC patches first if there is still disagreement on the patches that have been posted so far? I fear that this will fall into oblivion again and we continue to be stuck with SILO :(.

Re: [PATCH] ls: prevent double open

2017-10-18 Thread Eric Snowberg
> On Oct 18, 2017, at 11:03 AM, Vladimir 'phcoder' Serbinenko > wrote: > > > > On Wed, Oct 18, 2017, 19:02 Eric Snowberg wrote: > > > On Oct 18, 2017, at 10:32 AM, Vladimir 'phcoder' Serbinenko > > wrote: > > > > > > > > On Mon, Oct 16, 2017, 22:11 Eric Snowberg wrote: > > Prevent a doub

Re: [PATCH] ls: prevent double open

2017-10-18 Thread Vladimir 'phcoder' Serbinenko
On Wed, Oct 18, 2017, 19:02 Eric Snowberg wrote: > > > On Oct 18, 2017, at 10:32 AM, Vladimir 'phcoder' Serbinenko < > phco...@gmail.com> wrote: > > > > > > > > On Mon, Oct 16, 2017, 22:11 Eric Snowberg > wrote: > > Prevent a double open. This can cause problems with some ieee1275 > > devices,

Re: [PATCH] ls: prevent double open

2017-10-18 Thread Eric Snowberg
> On Oct 18, 2017, at 10:32 AM, Vladimir 'phcoder' Serbinenko > wrote: > > > > On Mon, Oct 16, 2017, 22:11 Eric Snowberg wrote: > Prevent a double open. This can cause problems with some ieee1275 > devices, causing the system to hang. The double open can occur > as follows: > Why does it?

Re: [PATCH] ls: prevent double open

2017-10-18 Thread Vladimir 'phcoder' Serbinenko
On Mon, Oct 16, 2017, 22:11 Eric Snowberg wrote: > Prevent a double open. This can cause problems with some ieee1275 > devices, causing the system to hang. The double open can occur > as follows: > Why does it? Underlying firmware device should not be aware of how many times grub device is open

Re: [PATCH] ls: prevent double open

2017-10-18 Thread Eric Snowberg
> On Oct 17, 2017, at 7:22 AM, Daniel Kiper wrote: > > On Mon, Oct 16, 2017 at 01:11:12PM -0700, Eric Snowberg wrote: >> Prevent a double open. This can cause problems with some ieee1275 >> devices, causing the system to hang. The double open can occur >> as follows: >> >> grub_ls_list_files

Re: [PATCH] ls: prevent double open

2017-10-17 Thread Daniel Kiper
On Mon, Oct 16, 2017 at 01:11:12PM -0700, Eric Snowberg wrote: > Prevent a double open. This can cause problems with some ieee1275 > devices, causing the system to hang. The double open can occur > as follows: > > grub_ls_list_files (char *dirname, int longlist, int all, int human) >dev =

[PATCH] ls: prevent double open

2017-10-16 Thread Eric Snowberg
Prevent a double open. This can cause problems with some ieee1275 devices, causing the system to hang. The double open can occur as follows: grub_ls_list_files (char *dirname, int longlist, int all, int human) dev = grub_device_open (device_name); dev remains open while: gru