Re: [PATCH] improve error messages in grub-setup

2009-05-04 Thread Robert Millan
On Sun, May 03, 2009 at 05:02:33PM -0400, Pavel Roskin wrote: > > > grub_util_warn() doesn't set any flag that there have been > > > warnings. > > > > That's an option, too. But it would preclude the possibility of issuing > > warnings for which we don't want to require --force (i.e. lesser evils

Re: [PATCH] improve error messages in grub-setup

2009-05-03 Thread Pavel Roskin
On Sun, 2009-05-03 at 22:54 +0200, Robert Millan wrote: > On Sun, May 03, 2009 at 01:04:33PM -0400, Pavel Roskin wrote: > > On Sun, 2009-05-03 at 18:55 +0200, Robert Millan wrote: > > > > > Agreed. It's no harm to add --force for users who are stuck in such > > > layouts. > > > > > > Here's a n

Re: [PATCH] improve error messages in grub-setup

2009-05-03 Thread Robert Millan
On Sun, May 03, 2009 at 01:04:33PM -0400, Pavel Roskin wrote: > On Sun, 2009-05-03 at 18:55 +0200, Robert Millan wrote: > > > Agreed. It's no harm to add --force for users who are stuck in such > > layouts. > > > > Here's a new patch. > > I don't see the "force" variable affecting anything in

Re: [PATCH] improve error messages in grub-setup

2009-05-03 Thread Pavel Roskin
On Sun, 2009-05-03 at 18:55 +0200, Robert Millan wrote: > Agreed. It's no harm to add --force for users who are stuck in such layouts. > > Here's a new patch. I don't see the "force" variable affecting anything in setup() other than output. grub_util_warn() doesn't set any flag that there have

Re: [PATCH] improve error messages in grub-setup

2009-05-03 Thread Robert Millan
On Sun, May 03, 2009 at 12:35:08AM -0400, Pavel Roskin wrote: > On Sat, 2009-05-02 at 13:15 +0200, Robert Millan wrote: > > This patch improves error messages in grub-setup, and adds a few > > warnings when requested to install in odd layouts. > > > > Since there was no facility to emmit a warning

Re: [PATCH] improve error messages in grub-setup

2009-05-02 Thread Pavel Roskin
On Sat, 2009-05-02 at 13:15 +0200, Robert Millan wrote: > This patch improves error messages in grub-setup, and adds a few > warnings when requested to install in odd layouts. > > Since there was no facility to emmit a warning that is always > visible (regardless of verbosity), but doesn't abort e

[PATCH] improve error messages in grub-setup

2009-05-02 Thread Robert Millan
This patch improves error messages in grub-setup, and adds a few warnings when requested to install in odd layouts. Since there was no facility to emmit a warning that is always visible (regardless of verbosity), but doesn't abort execution, I added one (grub_util_warn ()). Is everyone fine with

Re: [PATCH] improve error messages

2008-02-08 Thread Robert Millan
On Wed, Feb 06, 2008 at 05:41:31PM +0100, Robert Millan wrote: > > Just a few error message improvements. Committed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) __

[PATCH] improve error messages

2008-02-06 Thread Robert Millan
Just a few error message improvements. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.) * disk/raid.c (grub_raid_open, grub_raid_scan_device): Add a few grub_dprintf() calls. * kern/disk.c (grub_disk_read): Incl