Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 3:11 PM, John Paul Adrian Glaubitz > wrote: > > On 3/25/19 9:41 PM, Eric Snowberg wrote: >>> Is this on Solaris? I want to try reproducing it, so I can figure what >>> happened. >>> >> >> I’m using Oracle Linux for SPARC (6.9). > > Ok, so it can only be a matter of the

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 9:41 PM, Eric Snowberg wrote: >> Is this on Solaris? I want to try reproducing it, so I can figure what >> happened. >> > > I’m using Oracle Linux for SPARC (6.9). Ok, so it can only be a matter of the older binutils version implicitly assuming the output format to be a.out. Could yo

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 1:21 PM, John Paul Adrian Glaubitz > wrote: > > On 3/25/19 5:20 PM, Eric Snowberg wrote: >> I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I >> missing something? >> >> Before the patch: >> >> $ grub-install --force --skip-fs-probe /dev/sdb1

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 5:20 PM, Eric Snowberg wrote: > I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I > missing something? > > Before the patch: > > $ grub-install --force --skip-fs-probe /dev/sdb1 > Installing for sparc64-ieee1275 platform. > grub-install: warning: Attempting

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 6:22 PM, John Paul Adrian Glaubitz wrote: > I am not done testing yet but I just realized, 544 = 512 + 32, so it looks > like the a.out header is appended twice. Does an older binutils maybe default > to a.out when just passing binary as the output format? Just did another test build, t

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 5:20 PM, Eric Snowberg wrote: > I tried it out, but on my system it doesn’t fit in the 512 byte block? Am I > missing something? > > Before the patch: > > $ grub-install --force --skip-fs-probe /dev/sdb1 > Installing for sparc64-ieee1275 platform. > grub-install: warning: Attempting

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread John Paul Adrian Glaubitz
On 3/25/19 6:17 PM, John Paul Adrian Glaubitz wrote: >> $ grub-install --force --skip-fs-probe /dev/sdb1 >> Installing for sparc64-ieee1275 platform. >> grub-install: error: the size of `/boot/grub/sparc64-ieee1275/boot.img' is >> not 512. >> >> $ ls -al /boot/grub/sparc64-ieee1275/boot.img >> -rw

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Eric Snowberg
> On Mar 25, 2019, at 5:45 AM, Daniel Kiper wrote: > > On Fri, Mar 22, 2019 at 07:35:55AM +0100, John Paul Adrian Glaubitz wrote: >> Recent versions of binutils dropped support for the a.out and COFF >> formats on sparc64 targets. Since the boot loader on sparc64 is >> supposed to be an a.out bi

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-25 Thread Daniel Kiper
On Fri, Mar 22, 2019 at 07:35:55AM +0100, John Paul Adrian Glaubitz wrote: > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the a.out header entries are > rather simple to calc

[PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-03-21 Thread John Paul Adrian Glaubitz
Recent versions of binutils dropped support for the a.out and COFF formats on sparc64 targets. Since the boot loader on sparc64 is supposed to be an a.out binary and the a.out header entries are rather simple to calculate in our case, we just write the header ourselves instead of relying on externa

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-21 Thread John Paul Adrian Glaubitz
Hi Daniel! On 2/21/19 4:40 PM, Daniel Kiper wrote: > If you sprinkle the comments similar to above ones into the code then > I will be happy with the patch. Ok, thanks. I'll try to get around doing it tomorrow. > And sorry for late reply but I am recovering after the travel. No worries. I'm cur

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-21 Thread Daniel Kiper
On Thu, Feb 21, 2019 at 04:28:40PM +0100, John Paul Adrian Glaubitz wrote: > Hi Daniel! > > Thanks for the review! > > On 2/20/19 9:59 PM, Daniel Kiper wrote: > > On Sat, Feb 09, 2019 at 02:39:05PM +0100, John Paul Adrian Glaubitz wrote: > >> Recent versions of binutils dropped support for the a.ou

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-21 Thread John Paul Adrian Glaubitz
Hi Daniel! Thanks for the review! On 2/20/19 9:59 PM, Daniel Kiper wrote: > On Sat, Feb 09, 2019 at 02:39:05PM +0100, John Paul Adrian Glaubitz wrote: >> Recent versions of binutils dropped support for the a.out and COFF >> formats on sparc64 targets. Since the boot loader on sparc64 is >> suppos

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-20 Thread Daniel Kiper
On Sat, Feb 09, 2019 at 02:39:05PM +0100, John Paul Adrian Glaubitz wrote: > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the a.out header entries are > rather simple to calc

Re: [PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-09 Thread John Paul Adrian Glaubitz
This is supposed to be version 3. Forgot to edit the subject. Adrian On 2/9/19 2:39 PM, John Paul Adrian Glaubitz wrote: > Recent versions of binutils dropped support for the a.out and COFF > formats on sparc64 targets. Since the boot loader on sparc64 is > supposed to be an a.out binary and the

[PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-09 Thread John Paul Adrian Glaubitz
Recent versions of binutils dropped support for the a.out and COFF formats on sparc64 targets. Since the boot loader on sparc64 is supposed to be an a.out binary and the a.out header entries are rather simple to calculate in our case, we just write the header ourselves instead of relying on externa

[PATCH] ieee1275: Include a.out header in assembly of sparc64 boot loader

2019-02-09 Thread John Paul Adrian Glaubitz
Recent versions of binutils dropped support for the a.out and COFF formats on sparc64 targets. Since the boot loader on sparc64 is supposed to be an a.out binary and the a.out header entries are rather simple to calculate in our case, we just write the header ourselves instead of relying external t