Re: [PATCH] grub-core/kern/arm/misc.S: fix unaligned grub_uint64_t local variable

2014-12-11 Thread Leif Lindholm
On 7 December 2014 at 17:05, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Please commit and push. Apologies, I've been on holiday and then knocked down with a bad cold, but I notice Andrei has now committed this - thanks! / Leif ___ Grub-devel m

Re: [PATCH] grub-core/kern/arm/misc.S: fix unaligned grub_uint64_t local variable

2014-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Please commit and push. On 27.11.2014 15:25, Andrei Borzenkov wrote: > В Tue, 25 Nov 2014 11:43:57 + > Leif Lindholm пишет: > >> On Thu, Nov 20, 2014 at 09:53:14PM +0100, David Kozub wrote: >>> The unaligned local in __aeabi_uidivmod leads to a store to a 64bit >>> value at an address that is

Re: [PATCH] grub-core/kern/arm/misc.S: fix unaligned grub_uint64_t local variable

2014-11-28 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.11.2014 13:43, Leif Lindholm wrote: > On Thu, Nov 20, 2014 at 09:53:14PM +0100, David Kozub wrote: >> The unaligned local in __aeabi_uidivmod leads to a store to a 64bit >> value at an address that is not divisible by 8 (in grub_divmod64). >> The compiler most likely generates a STRD instruct

Re: [PATCH] grub-core/kern/arm/misc.S: fix unaligned grub_uint64_t local variable

2014-11-27 Thread Andrei Borzenkov
В Tue, 25 Nov 2014 11:43:57 + Leif Lindholm пишет: > On Thu, Nov 20, 2014 at 09:53:14PM +0100, David Kozub wrote: > > The unaligned local in __aeabi_uidivmod leads to a store to a 64bit > > value at an address that is not divisible by 8 (in grub_divmod64). > > The compiler most likely generat

Re: [PATCH] grub-core/kern/arm/misc.S: fix unaligned grub_uint64_t local variable

2014-11-25 Thread Leif Lindholm
On Thu, Nov 20, 2014 at 09:53:14PM +0100, David Kozub wrote: > The unaligned local in __aeabi_uidivmod leads to a store to a 64bit > value at an address that is not divisible by 8 (in grub_divmod64). > The compiler most likely generates a STRD instruction to store it and > this causes an exception.

[PATCH] grub-core/kern/arm/misc.S: fix unaligned grub_uint64_t local variable

2014-11-21 Thread David Kozub
The unaligned local in __aeabi_uidivmod leads to a store to a 64bit value at an address that is not divisible by 8 (in grub_divmod64). The compiler most likely generates a STRD instruction to store it and this causes an exception. Fixes Savannah bug #43632. This includes improvements done by Leif