Re: [PATCH] generic ELF loading #3

2006-11-02 Thread Hollis Blanchard
On Thu, 2006-11-02 at 14:54 -0600, Hollis Blanchard wrote: > > How do I know what the load address should be before I've even looked > at the program header? > > Just because the x86 loader uses fixed values doesn't mean other > loaders should. In particular, the PowerPC loader is happy to load t

Re: [PATCH] generic ELF loading #3

2006-11-02 Thread Hollis Blanchard
On Thu, 2006-11-02 at 21:58 +0200, Yoshinori K. Okuji wrote: > On Wednesday 01 November 2006 02:23, Hollis Blanchard wrote: > > Here is pass #3 of the ELF loader. Changes from #2: > > - the `load' callback no longer modifies the phdr directly > > I still don't understand why you want to pass a hoo

Re: [PATCH] generic ELF loading #3

2006-11-02 Thread Yoshinori K. Okuji
On Wednesday 01 November 2006 02:23, Hollis Blanchard wrote: > Here is pass #3 of the ELF loader. Changes from #2: > - the `load' callback no longer modifies the phdr directly I still don't understand why you want to pass a hook. Why don't you simply pass a load address? Okuji

Re: [PATCH] generic ELF loading #3

2006-11-01 Thread Johan Rydberg
Hollis Blanchard <[EMAIL PROTECTED]> writes: > --- grub2-cvs.orig/include/grub/types.h 2006-10-31 19:06:47.0 > -0600 > +++ grub2-cvs/include/grub/types.h2006-10-31 19:06:58.0 -0600 > @@ -23,6 +23,8 @@ > #include > #include > > +#define __unused __attribute__ ((unus