Will do! I’ll do this later today after work. I was attempting to chase
down some additional ntfs test failures (around hard links on an ntfs file
system) even with the fix mentioned but maybe to expedite the main issue
people are having I’ll put that on my queue for after this first fix.
Thanks!
On Tue, Mar 18, 2025 at 09:22:46AM -0500, Andrew Hamilton wrote:
> Unless someone else is already working on this, I started working on a patch
> for this as well as fixes to correct the NTFS Grub test failures - I’ll
> hopefully submit something for review in a few days.
>
> Once it is available -
Unless someone else is already working on this, I started working on a
patch for this as well as fixes to correct the NTFS Grub test failures -
I’ll hopefully submit something for review in a few days.
Once it is available - any additional testing that can be done would be
appreciated.
Thanks,
An
For some fuzzers I’m working on, l happened to run into the same issue this
patch is addressing and used a fix similar to what Vladimir suggested
(keeping mft_end check and adding attr_cur != NULL check). This fixes the
issue for me in my fuzzer so far.
Thanks,
Andrew
On Fri, Feb 28, 2025 at 7:12
Hi,
This patch also fixes an issue introduced by the original patch involving
dual booting: grub-mount seg faults when trying to mount an ntfs volume,
e.g., when grub-mkconfig is run. There are bugs for this on fedora [1] and
arch [2], so further review of this patch is really appreciated!
thanks
Why do you remove boundary check? Maybe it's better to add the second
boundary check from below
Le ven. 28 févr. 2025, 16:11, B Horn a écrit :
> On some NTFS volumes GRUB would enter an infinite loop when
> next_attribute() returned NULL, which can happen in normal cases when
> the end of the at
On 28/02/2025 22:17, Vladimir 'phcoder' Serbinenko wrote:
Why do you remove boundary check? Maybe it's better to add the second
boundary check from below
The issue stems from my original patches being rebased over `fs/ntfs:
Fix out-of-bounds read`, with both my patches and that commit fixing
On Fri, Feb 28, 2025 at 01:07:06PM +, B Horn wrote:
> On some NTFS volumes GRUB would enter an infinite loop when
> next_attribute() returned NULL, which can happen in normal cases when
> the end of the attribute list is reached.
> This would trigger a NULL deref, but as the null page is mapped
On some NTFS volumes GRUB would enter an infinite loop when
next_attribute() returned NULL, which can happen in normal cases when
the end of the attribute list is reached.
This would trigger a NULL deref, but as the null page is mapped on the
majority of firmware, an infinite loop would occur as th
