Re: [PATCH] fix usability problem in FreeBSD loader

2009-08-10 Thread Robert Millan
Committed. On Sat, Aug 01, 2009 at 04:28:52PM +0200, Robert Millan wrote: > On Sat, Aug 01, 2009 at 03:49:15PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On Sat, Aug 1, 2009 at 3:40 PM, Robert Millan wrote: > > > > > > There's a minor usability problem with FreeBSD loader.  E.g. if user runs

Re: [PATCH] fix usability problem in FreeBSD loader

2009-08-01 Thread Robert Millan
On Sat, Aug 01, 2009 at 03:49:15PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sat, Aug 1, 2009 at 3:40 PM, Robert Millan wrote: > > > > There's a minor usability problem with FreeBSD loader.  E.g. if user runs > > freebsd_module first, the error message is confusing. > > > -static int kernel_

Re: [PATCH] fix usability problem in FreeBSD loader

2009-08-01 Thread Vladimir 'phcoder' Serbinenko
On Sat, Aug 1, 2009 at 3:40 PM, Robert Millan wrote: > > There's a minor usability problem with FreeBSD loader.  E.g. if user runs > freebsd_module first, the error message is confusing. > -static int kernel_type; +static int kernel_type; /* 0 == KERNEL_TYPE_NONE */ I would prefer either static int

[PATCH] fix usability problem in FreeBSD loader

2009-08-01 Thread Robert Millan
There's a minor usability problem with FreeBSD loader. E.g. if user runs freebsd_module first, the error message is confusing. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: w