Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-11 Thread Robert Millan
On Mon, Feb 11, 2008 at 01:43:21PM +0100, Jan Nieuwenhuizen wrote: > Robert Millan writes: > > > This is only known to work on proof-of-concept test systems. *Please* > > anyone > > who was affected on real, production systems, test it (against latest CVS) > > and > > send feedback. The proble

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-09 Thread Robert Millan
On Fri, Feb 08, 2008 at 03:52:37PM +0100, Robert Millan wrote: > > * disk/lvm.c [GRUB_UTIL] (grub_lvm_memberlist): New function. Construct > and return a grub_diskmemberlist_t composed of LVM physical volumes. > [GRUB_UTIL] (grub_lvm_dev): Add `memberlist' member. > > * d

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-09 Thread Robert Millan
On Fri, Feb 08, 2008 at 11:39:49PM +0100, Robert Millan wrote: > > $ sudo ./grub-probe -t partmap /boot/grub/ > > pc > > pc > > Now that I think about it... does this cause grub-install / grub-mkimage > to load pc.mod twice? Ok, I see that it doesn't. util/resolve.c takes care of that. -- Robe

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-08 Thread Robert Millan
On Fri, Feb 08, 2008 at 09:38:25PM +, Sam Morris wrote: > > diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp -N > > ../grub2/disk/raid.c ./disk/raid.c --- ../grub2/disk/raid.c > > 2008-02-08 13:35:05.0 +0100 +++ ./disk/raid.c 2008-02-08 > > 20:36:47.0

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-08 Thread Sam Morris
On Fri, 08 Feb 2008 20:38:56 +0100, Robert Millan wrote: > On Fri, Feb 08, 2008 at 07:20:31PM +, Sam Morris wrote: >> On Fri, 2008-02-08 at 15:52 +0100, Robert Millan wrote: >> > New patch to fix partmap detection in LVM/RAID. Changes in >> > comparison to previous patch: >> >> (gdb)

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-08 Thread Robert Millan
On Fri, Feb 08, 2008 at 07:20:31PM +, Sam Morris wrote: > On Fri, 2008-02-08 at 15:52 +0100, Robert Millan wrote: > > New patch to fix partmap detection in LVM/RAID. Changes in comparison to > > previous patch: > > (gdb) run -t partmap /boot/grub/ > Starting program: /home/sam

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-08 Thread Sam Morris
On Fri, 2008-02-08 at 15:52 +0100, Robert Millan wrote: > New patch to fix partmap detection in LVM/RAID. Changes in comparison to > previous patch: (gdb) run -t partmap /boot/grub/ Starting program: /home/sam/grub/grub2/grub-probe -t partmap /boot/grub/ Program r

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-08 Thread Robert Millan
New patch to fix partmap detection in LVM/RAID. Changes in comparison to previous patch: - Add LVM detection. - Rename the structures/functions to make them more descriptive. - Fix a minor memleak. This is only known to work on proof-of-concept test systems. *Please* anyone who was affec

Re: [PATCH] fix for partmap detection on RAID/LVM

2008-02-06 Thread Robert Millan
On Wed, Feb 06, 2008 at 10:18:40PM +0100, Robert Millan wrote: > + while (list) > + { > + probe_partmap (list->disk); > + list = list->next; > + } Ah yes, I forgot to free() the structure here. -- Robert Millan I know my rights; I want my phone call! What use is a pho

[PATCH] fix for partmap detection on RAID/LVM

2008-02-06 Thread Robert Millan
This is my proposed approach for fixing the partmap detection problem in LVM/RAID. The problem: grub-probe just tests for partmap in the target drive directly (which usually doesn't have any), and not in the physical drives that make the RAID array (or LVM volume). My proposed solution: RAID im