On Mon, Jan 21, 2008 at 05:52:50PM +0100, Marco Gerards wrote:
> Robert Millan <[EMAIL PROTECTED]> writes:
>
> > On Mon, Jan 21, 2008 at 04:10:37PM +0100, Marco Gerards wrote:
> >>
> >> If done efficiently, code shouldn't get too big. Perhaps it is better
> >> to integrate this into normal.mod?
Robert Millan <[EMAIL PROTECTED]> writes:
> On Mon, Jan 21, 2008 at 04:10:37PM +0100, Marco Gerards wrote:
>>
>> If done efficiently, code shouldn't get too big. Perhaps it is better
>> to integrate this into normal.mod? I wouldn't mind a few extra KB
>> there for such a feature.
>
> I don't th
On Mon, Jan 21, 2008 at 04:10:37PM +0100, Marco Gerards wrote:
>
> If done efficiently, code shouldn't get too big. Perhaps it is better
> to integrate this into normal.mod? I wouldn't mind a few extra KB
> there for such a feature.
I don't think code size matters that much for a non-kernel fea
Pavel Roskin <[EMAIL PROTECTED]> writes:
> On Mon, 2008-01-21 at 11:33 +0100, Marco Gerards wrote:
>> Jordi Mallach <[EMAIL PROTECTED]> writes:
>>
>> > On Tue, Jan 15, 2008 at 12:18:55AM +0100, Robert Millan wrote:
>> >> Is this better?
>> >> + char *msg = " The highlighted entry will be b
On Mon, Jan 21, 2008 at 09:18:19AM -0500, Pavel Roskin wrote:
>
> But I still think it would be an overkill. Even the Linux kernel
> doesn't offer any translation for its boot messages.
But Linux has no user interface. Well, other than cmdline params, dmesg
and such, but no real user interface
On Mon, 2008-01-21 at 11:33 +0100, Marco Gerards wrote:
> Jordi Mallach <[EMAIL PROTECTED]> writes:
>
> > On Tue, Jan 15, 2008 at 12:18:55AM +0100, Robert Millan wrote:
> >> Is this better?
> >> + char *msg = " The highlighted entry will be booted automatically
> >> in %ds.";
> >> +
Jordi Mallach <[EMAIL PROTECTED]> writes:
> On Tue, Jan 15, 2008 at 12:18:55AM +0100, Robert Millan wrote:
>> Is this better?
>> + char *msg = " The highlighted entry will be booted automatically in
>> %ds.";
>> + char *msg_end = grub_strchr (msg, '%');
>> +
>> + grub_printf
On Tue, Jan 15, 2008 at 12:18:55AM +0100, Robert Millan wrote:
> Is this better?
> + char *msg = " The highlighted entry will be booted automatically in
> %ds.";
> + char *msg_end = grub_strchr (msg, '%');
> +
> + grub_printf (second_stage ? msg_end : msg, timeout);
Yes; howe
On Tue, Jan 15, 2008 at 01:51:23PM +0100, Marco Gerards wrote:
> > +void
> > +print_timeout (int timeout, int offset, int second_stage)
>
> please make this function static.
>
> Otherwise, I do not see any problems.
Committed.
--
Robert Millan
I know my rights; I want my phone call!
What us
Robert Millan <[EMAIL PROTECTED]> writes:
> On Tue, Jan 15, 2008 at 01:25:25PM +0100, Marco Gerards wrote:
>> Robert Millan <[EMAIL PROTECTED]> writes:
>>
>> > On Mon, Jan 14, 2008 at 09:32:39PM +0100, Yoshinori K. Okuji wrote:
>> >> On Monday 14 January 2008 15:10, Robert Millan wrote:
>> >> > A
On Tue, Jan 15, 2008 at 01:25:25PM +0100, Marco Gerards wrote:
> Robert Millan <[EMAIL PROTECTED]> writes:
>
> > On Mon, Jan 14, 2008 at 09:32:39PM +0100, Yoshinori K. Okuji wrote:
> >> On Monday 14 January 2008 15:10, Robert Millan wrote:
> >> > As subject says. Based on suggestions from Vesa.
>
Robert Millan <[EMAIL PROTECTED]> writes:
> On Mon, Jan 14, 2008 at 09:32:39PM +0100, Yoshinori K. Okuji wrote:
>> On Monday 14 January 2008 15:10, Robert Millan wrote:
>> > As subject says. Based on suggestions from Vesa.
>>
>> Why do you want to use a nested function?
>
> No special reason; j
On Mon, Jan 14, 2008 at 09:32:25PM +0100, Jordi Mallach wrote:
> Hi Robert,
>
> On Mon, Jan 14, 2008 at 03:10:15PM +0100, Robert Millan wrote:
> > + char *prelude = " The highlighted entry will be booted
> > automatically in";
> > + grub_printf ("%s %ds.", second_stage ? "" : prel
Hi Robert,
On Mon, Jan 14, 2008 at 03:10:15PM +0100, Robert Millan wrote:
> + char *prelude = " The highlighted entry will be booted automatically
> in";
> + grub_printf ("%s %ds.", second_stage ? "" : prelude, timeout);
As you feared, this is not nice from a i18n POV. Concatenat
On Mon, Jan 14, 2008 at 09:32:39PM +0100, Yoshinori K. Okuji wrote:
> On Monday 14 January 2008 15:10, Robert Millan wrote:
> > As subject says. Based on suggestions from Vesa.
>
> Why do you want to use a nested function?
No special reason; just to restrict the namespace use to the scope where
On Monday 14 January 2008 15:10, Robert Millan wrote:
> As subject says. Based on suggestions from Vesa.
Why do you want to use a nested function?
Okuji
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
As subject says. Based on suggestions from Vesa.
--
Robert Millan
I know my rights; I want my phone call!
What use is a phone call, if you are unable to speak?
(as seen on /.)
* normal/menu.c (run_menu): Move timeout message to a separate
(local) function, print_timeout(). Use print_time
17 matches
Mail list logo
