Re: [PATCH] fix building bug with --enable-grub-emu-usb

2009-07-16 Thread Vladimir 'phcoder' Serbinenko
comitted On Sun, Jun 21, 2009 at 2:34 PM, Vladimir 'phcoder' Serbinenko wrote: > > >> >> Anyway, given that grub-emu is a debugging/development tool, I'm not sure >> it's that useful to export those flags to autoconf.  We could just live >> with #ifdefs in the code IMHO.  Distributors are going to

Re: [PATCH] fix building bug with --enable-grub-emu-usb

2009-06-21 Thread Vladimir 'phcoder' Serbinenko
> Anyway, given that grub-emu is a debugging/development tool, I'm not sure > it's that useful to export those flags to autoconf. We could just live > with #ifdefs in the code IMHO. Distributors are going to ship whatever we > choose as default for grub-emu anyway. > Actually the problem isn't gr

Re: [PATCH] fix building bug with --enable-grub-emu-usb

2009-06-21 Thread Robert Millan
On Fri, Jun 19, 2009 at 11:46:06AM -0400, Pavel Roskin wrote: > > Generally, please think how to reduce complexity, not how to add to it. > Complex systems are harder to maintain. In general, I completely agree with this. However grub-emu has very special requirements that could make it desireab

Re: [PATCH] fix building bug with --enable-grub-emu-usb

2009-06-19 Thread Vladimir 'phcoder' Serbinenko
On Fri, Jun 19, 2009 at 5:46 PM, Pavel Roskin wrote: > On Wed, 2009-06-17 at 15:27 +0200, Vladimir 'phcoder' Serbinenko wrote: > > Hello. This is a fix for problem in subject line. I believe this fix > > to be correct and legitimate but as I don't know ruby well could > > someone review it? If no

Re: [PATCH] fix building bug with --enable-grub-emu-usb

2009-06-19 Thread Pavel Roskin
On Wed, 2009-06-17 at 15:27 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. This is a fix for problem in subject line. I believe this fix > to be correct and legitimate but as I don't know ruby well could > someone review it? If nobody knows ruby in depth I think we can commit > this even with

[PATCH] fix building bug with --enable-grub-emu-usb

2009-06-17 Thread Vladimir 'phcoder' Serbinenko
Hello. This is a fix for problem in subject line. I believe this fix to be correct and legitimate but as I don't know ruby well could someone review it? If nobody knows ruby in depth I think we can commit this even without deep review -- Regards Vladimir 'phcoder' Serbinenko diff --git a/ChangeLo