Re: [PATCH] efi: Fix stack protector issues

2024-01-03 Thread Glenn Washburn
On Wed, 3 Jan 2024 16:36:57 +0100 Ard Biesheuvel wrote: > On Mon, 1 Jan 2024 at 03:52, Glenn Washburn > wrote: > > > > On Sun, 31 Dec 2023 11:56:18 +0100 > > Ard Biesheuvel wrote: > > > > > Hi Glenn, > > > > > > On Thu, 28 Dec 2023 at 03:26, Glenn Washburn > > > wrote: > > > > > > > > On Sat,

Re: [PATCH] efi: Fix stack protector issues

2024-01-03 Thread Ard Biesheuvel
On Mon, 1 Jan 2024 at 03:52, Glenn Washburn wrote: > > On Sun, 31 Dec 2023 11:56:18 +0100 > Ard Biesheuvel wrote: > > > Hi Glenn, > > > > On Thu, 28 Dec 2023 at 03:26, Glenn Washburn > > wrote: > > > > > > On Sat, 23 Dec 2023 12:45:35 +0100 > > > Ard Biesheuvel via Grub-devel wrote: > > > > > >

Re: [PATCH] efi: Fix stack protector issues

2023-12-31 Thread Glenn Washburn
On Sun, 31 Dec 2023 11:56:18 +0100 Ard Biesheuvel wrote: > Hi Glenn, > > On Thu, 28 Dec 2023 at 03:26, Glenn Washburn > wrote: > > > > On Sat, 23 Dec 2023 12:45:35 +0100 > > Ard Biesheuvel via Grub-devel wrote: > > > > > From: Ard Biesheuvel > > > > > > The 'ground truth' stack protector cook

Re: [PATCH] efi: Fix stack protector issues

2023-12-31 Thread Ard Biesheuvel
Hi Glenn, On Thu, 28 Dec 2023 at 03:26, Glenn Washburn wrote: > > On Sat, 23 Dec 2023 12:45:35 +0100 > Ard Biesheuvel via Grub-devel wrote: > > > From: Ard Biesheuvel > > > > The 'ground truth' stack protector cookie value is kept in a global > > variable, and loaded in every function prologue

Re: [PATCH] efi: Fix stack protector issues

2023-12-27 Thread Glenn Washburn
On Sat, 23 Dec 2023 12:45:35 +0100 Ard Biesheuvel via Grub-devel wrote: > From: Ard Biesheuvel > > The 'ground truth' stack protector cookie value is kept in a global > variable, and loaded in every function prologue and epilogue to store > it into resp. compare it with the stack slot holding t

[PATCH] efi: Fix stack protector issues

2023-12-23 Thread Ard Biesheuvel via Grub-devel
From: Ard Biesheuvel The 'ground truth' stack protector cookie value is kept in a global variable, and loaded in every function prologue and epilogue to store it into resp. compare it with the stack slot holding the cookie. If the comparison fails, the program aborts, and this might occur spurio