Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-10 Thread Chris Coulson
On 02/06/2020 13:53, Vladimir 'phcoder' Serbinenko wrote: > > > On Tue, Jun 2, 2020, 13:21 Dimitri John Ledkov > wrote: > > On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko > mailto:phco...@gmail.com>> wrote: > > > > > > > > On Mon, Jun 1

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-10 Thread Julian Andres Klode
On Mon, Jun 01, 2020 at 02:03:37PM +0100, Chris Coulson wrote: > When a file is verified, the entire contents of the verified file are > loaded in to memory and retained until the file handle is closed. A > consequence of this is that opening a loopback image can incur a > significant memory cost.

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Dimitri John Ledkov
On Tue, 2 Jun 2020, 13:53 Vladimir 'phcoder' Serbinenko, wrote: > > > On Tue, Jun 2, 2020, 13:21 Dimitri John Ledkov wrote: > >> On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko >> wrote: >> > >> > >> > >> > On Mon, Jun 1, 2020, 15:21 Chris Coulson >> wrote: >> >> >> >> When a file i

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 2, 2020, 13:21 Dimitri John Ledkov wrote: > On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > > > On Mon, Jun 1, 2020, 15:21 Chris Coulson > wrote: > >> > >> When a file is verified, the entire contents of the verified file are > >> loaded in to memory

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Dimitri John Ledkov
On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko wrote: > > > > On Mon, Jun 1, 2020, 15:21 Chris Coulson wrote: >> >> When a file is verified, the entire contents of the verified file are >> loaded in to memory and retained until the file handle is closed. A >> consequence of this is th

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 1, 2020, 15:21 Chris Coulson wrote: > When a file is verified, the entire contents of the verified file are > loaded in to memory and retained until the file handle is closed. A > consequence of this is that opening a loopback image can incur a > significant memory cost. > > As loopba

[PATCH] disk/loopback: Don't verify loopback images

2020-06-01 Thread Chris Coulson
When a file is verified, the entire contents of the verified file are loaded in to memory and retained until the file handle is closed. A consequence of this is that opening a loopback image can incur a significant memory cost. As loopback devices are just another disk implementation, don't treat