Re: [PATCH] Use common linker script for all i386-pc systems

2009-08-18 Thread Pavel Roskin
On Tue, 2009-05-19 at 17:15 -0400, Pavel Roskin wrote: > I appreciate a lot of work you put into the Apple CC support, but your > patch complicates the code a lot. All features have a maintenance > cost. Somebody will need to fix your code when it breaks. > Considering that it can only be

Re: [PATCH] Use common linker script for all i386-pc systems

2009-05-19 Thread Pavel Roskin
Quoting Vladimir 'phcoder' Serbinenko : Hello. On Sun, May 17, 2009 at 7:33 AM, Pavel Roskin wrote: This allows us to remove checks for the linker symbols for the beginning and the end of the .bss section.  Instead, we use the names from the linker script.  Another benefit is a better unifica

Re: [PATCH] Use common linker script for all i386-pc systems

2009-05-19 Thread Pavel Roskin
Quoting Christian Franke : Good idea. Patch works on Cygwin. Does it work on Linux, FreeBSD, ... ? It works on Linux. I assume it should work on every OS that has GNU ld. The variable TARGET_IMG_LDFLAGS_AC can also be removed, see attached patch. I think we can do a big cleanup. The star

Re: [PATCH] Use common linker script for all i386-pc systems

2009-05-18 Thread Vladimir 'phcoder' Serbinenko
On Mon, May 18, 2009 at 11:13 PM, Christian Franke wrote: > Vladimir 'phcoder' Serbinenko wrote: >> >> Hello. >> >> On Sun, May 17, 2009 at 7:33 AM, Pavel Roskin <...> wrote: >> >>> >>> This allows us to remove checks for the linker symbols for the beginning >>> and the end of the .bss section.  I

Re: [PATCH] Use common linker script for all i386-pc systems

2009-05-18 Thread Christian Franke
Vladimir 'phcoder' Serbinenko wrote: Hello. On Sun, May 17, 2009 at 7:33 AM, Pavel Roskin <...> wrote: This allows us to remove checks for the linker symbols for the beginning and the end of the .bss section. Instead, we use the names from the linker script. Another benefit is a better uni

Re: [PATCH] Use common linker script for all i386-pc systems

2009-05-17 Thread Vladimir 'phcoder' Serbinenko
Hello. On Sun, May 17, 2009 at 7:33 AM, Pavel Roskin wrote: > This allows us to remove checks for the linker symbols for the beginning > and the end of the .bss section.  Instead, we use the names from the > linker script.  Another benefit is a better unification of the build > system. > I have n

[PATCH] Use common linker script for all i386-pc systems

2009-05-16 Thread Pavel Roskin
This allows us to remove checks for the linker symbols for the beginning and the end of the .bss section. Instead, we use the names from the linker script. Another benefit is a better unification of the build system. ChangeLog: * aclocal.m4: Remove grub_CHECK_BSS_START_SYMBOL and