Re: [PATCH] Provide grub_dl_ref() and grub_dl_unref() for GRUB_UTIL

2009-05-04 Thread Pavel Roskin
Quoting David Miller : Change looks great, but probably you want to explicitly mention all of the C files where you got rid of the CPP conditional tests. OK, will do. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://l

Re: [PATCH] Provide grub_dl_ref() and grub_dl_unref() for GRUB_UTIL

2009-05-04 Thread David Miller
From: Pavel Roskin Date: Mon, 04 May 2009 20:13:24 -0400 > Hello! > > The GRUB code is full of constructs like > > #ifndef GRUB_UTIL > grub_dl_ref (my_mod); > #endif > > It's better to avoid having source files littered with preprocessor > conditionals. This patch implements grub_dl_ref() a

[PATCH] Provide grub_dl_ref() and grub_dl_unref() for GRUB_UTIL

2009-05-04 Thread Pavel Roskin
Hello! The GRUB code is full of constructs like #ifndef GRUB_UTIL grub_dl_ref (my_mod); #endif It's better to avoid having source files littered with preprocessor conditionals. This patch implements grub_dl_ref() and grub_dl_unref() as inline functions when GRUB_UTIL is defined. I'm not usin