Re: [PATCH] On Linux, read partition start offsets from sysfs if possible

2013-12-05 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Looks good. Go ahead. On 05.12.2013 13:17, Colin Watson wrote: > This lets us cope with block device drivers that don't implement > HDIO_GETGEO. Fixes Ubuntu bug #1237519. > > * grub-core/osdep/linux/hostdisk.c (sysfs_partition_path): New > function. > (sysfs_partition_start): Likewise. > (grub_u

Re: [PATCH] On Linux, read partition start offsets from sysfs if possible

2013-12-05 Thread Colin Watson
On Thu, Dec 05, 2013 at 12:17:23PM +, Colin Watson wrote: > This lets us cope with block device drivers that don't implement > HDIO_GETGEO. Fixes Ubuntu bug #1237519. Brandon Hansen also pointed out in this bug that hd_geometry.start is unsigned long rather than unsigned long long, and thus i

[PATCH] On Linux, read partition start offsets from sysfs if possible

2013-12-05 Thread Colin Watson
This lets us cope with block device drivers that don't implement HDIO_GETGEO. Fixes Ubuntu bug #1237519. * grub-core/osdep/linux/hostdisk.c (sysfs_partition_path): New function. (sysfs_partition_start): Likewise. (grub_util_find_partition_start_os): Try sysfs_partition_start before HDIO_GETGEO. -