Re: [PATCH] Journal support for ext2

2008-05-15 Thread Bean
Hi, This new patch is synced with the current cvs head, also some minor changes. If nobody objects, I'd commit this in a few days. 2008-05-15 Bean <[EMAIL PROTECTED]> * fs/fshelp.c (grub_fshelp_map_block): New function. (grub_fshelp_find_file): Use 64-bit type for pos and blo

Re: [PATCH] Journal support for ext2

2008-03-20 Thread Robert Millan
On Thu, Mar 20, 2008 at 02:03:45PM +0800, Bean wrote: > On Thu, Mar 20, 2008 at 8:12 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > > > Hi! > > > > Is this patch supposed to fix > 32-bit disk addressing in filesystems? I > > just setup a ~4 TB hard disk for testing (in qemu), and added a (gpt

Re: [PATCH] Journal support for ext2

2008-03-19 Thread Bean
On Thu, Mar 20, 2008 at 8:12 AM, Robert Millan <[EMAIL PROTECTED]> wrote: > > Hi! > > Is this patch supposed to fix > 32-bit disk addressing in filesystems? I > just setup a ~4 TB hard disk for testing (in qemu), and added a (gpt) > partition > at the end of it, surely above the 2 TiB barrier

Re: [PATCH] Journal support for ext2

2008-03-19 Thread Robert Millan
Hi! Is this patch supposed to fix > 32-bit disk addressing in filesystems? I just setup a ~4 TB hard disk for testing (in qemu), and added a (gpt) partition at the end of it, surely above the 2 TiB barrier. What I found puzzling is that grub-emu is capable of listing files in that partition _wi

Re: [PATCH] Journal support for ext2

2008-03-13 Thread Marco Gerards
Bean <[EMAIL PROTECTED]> writes: > On Thu, Mar 6, 2008 at 1:24 AM, Bean <[EMAIL PROTECTED]> wrote: >> Hi, >> >> I have converted all block type in fshelp to grub_disk_addr_t, the >> file system driver should be 64-bit enabled by now. > > Any comment ? i would like to check it in if there is no o

Re: [PATCH] Journal support for ext2

2008-03-13 Thread Bean
On Thu, Mar 6, 2008 at 1:24 AM, Bean <[EMAIL PROTECTED]> wrote: > Hi, > > I have converted all block type in fshelp to grub_disk_addr_t, the > file system driver should be 64-bit enabled by now. Any comment ? i would like to check it in if there is no objection. -- Bean _

Re: [PATCH] Journal support for ext2

2008-03-05 Thread Bean
Hi, I have converted all block type in fshelp to grub_disk_addr_t, the file system driver should be 64-bit enabled by now. 2008-03-05 Bean <[EMAIL PROTECTED]> * fs/fshelp.c (grub_fshelp_map_block): New function. (grub_fshelp_find_file): Use 64-bit type for pos and block address

Re: [PATCH] Journal support for ext2

2008-02-21 Thread Yoshinori K. Okuji
On Thursday 21 February 2008 04:12, Bean wrote: > On Thu, Feb 21, 2008 at 5:37 AM, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > > On Monday 18 February 2008 00:25, Bean wrote: > > > Some adjustment in this patch: as the get_block function is only used > > > when journal type is GRUB_FSHELP_JOU

Re: [PATCH] Journal support for ext2

2008-02-20 Thread Bean
On Thu, Feb 21, 2008 at 5:37 AM, Yoshinori K. Okuji <[EMAIL PROTECTED]> wrote: > On Monday 18 February 2008 00:25, Bean wrote: > > Some adjustment in this patch: as the get_block function is only used > > when journal type is GRUB_FSHELP_JOURNAL_TYPE_FILE, i move it to > > grub_fshelp_journal in

Re: [PATCH] Journal support for ext2

2008-02-20 Thread Yoshinori K. Okuji
On Monday 18 February 2008 00:25, Bean wrote: > Some adjustment in this patch: as the get_block function is only used > when journal type is GRUB_FSHELP_JOURNAL_TYPE_FILE, i move it to > grub_fshelp_journal instead of using it as a parameter for > grub_fshelp_map_block. also add changelog for reise

Re: [PATCH] Journal support for ext2

2008-02-18 Thread Robert Millan
On Mon, Feb 18, 2008 at 02:15:58PM +0800, Bean wrote: > On Feb 18, 2008 2:03 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > > On Mon, Feb 18, 2008 at 03:07:54AM +0800, Bean wrote: > > > Hi, > > > > > > This patch extends fshelp for general journal handling, it also > > > implement journaling for ex

Re: [PATCH] Journal support for ext2

2008-02-17 Thread Bean
On Feb 18, 2008 2:03 PM, Robert Millan <[EMAIL PROTECTED]> wrote: > On Mon, Feb 18, 2008 at 03:07:54AM +0800, Bean wrote: > > Hi, > > > > This patch extends fshelp for general journal handling, it also > > implement journaling for ext2 file system. > > In which situations is this needed, reading wr

Re: [PATCH] Journal support for ext2

2008-02-17 Thread Robert Millan
On Mon, Feb 18, 2008 at 03:07:54AM +0800, Bean wrote: > Hi, > > This patch extends fshelp for general journal handling, it also > implement journaling for ext2 file system. In which situations is this needed, reading writing or both? -- Robert Millan I know my rights; I want my phone call! W

Re: [PATCH] Journal support for ext2

2008-02-17 Thread Bean
Some adjustment in this patch: as the get_block function is only used when journal type is GRUB_FSHELP_JOURNAL_TYPE_FILE, i move it to grub_fshelp_journal instead of using it as a parameter for grub_fshelp_map_block. also add changelog for reiserfs.c. 2008-02-18 Bean <[EMAIL PROTECTED]>

Re: [PATCH] Journal support for ext2

2008-02-17 Thread Bean
This new patch add journal support for reiserfs file system. -- Bean diff --git a/fs/reiserfs.c b/fs/reiserfs.c index a4c60ca..610fadd 100644 --- a/fs/reiserfs.c +++ b/fs/reiserfs.c @@ -52,7 +52,8 @@ #define REISERFS_SUPER_BLOCK_OFFSET 0x1 #define REISERFS_MAGIC_LEN 12 -#define REISERFS_M

[PATCH] Journal support for ext2

2008-02-17 Thread Bean
Hi, This patch extends fshelp for general journal handling, it also implement journaling for ext2 file system. 2008-02-18 Bean <[EMAIL PROTECTED]> * fs/ext2.c (EXT3_FEATURE_COMPAT_HAS_JOURNAL): New macro. (EXT3_JOURNAL_MAGIC_NUMBER): Likewise. (EXT3_JOURNAL_DESCRIPTOR_B