Re: [PATCH] Initialize local relocator subchunk struct to all zeros

2022-07-19 Thread Daniel Kiper
On Fri, Jul 15, 2022 at 05:21:21PM -0400, Alec Brown wrote: > On Thu, Jul 14, 2022 at 03:38:04PM +0100, Darren Kenny wrote: > > Hi Ross, > > > > This looks good to me. > > > > On Thursday, 2022-07-14 at 09:41:28 -04, Ross Philipson wrote: > > > The way the code is written the tofree variable would

Re: [PATCH] Initialize local relocator subchunk struct to all zeros

2022-07-15 Thread Alec Brown
On Thu, Jul 14, 2022 at 03:38:04PM +0100, Darren Kenny wrote: > Hi Ross, > > This looks good to me. > > On Thursday, 2022-07-14 at 09:41:28 -04, Ross Philipson wrote: > > The way the code is written the tofree variable would never be > > passed to the free_subchunk() function uninitialized. Cover

Re: [PATCH] Initialize local relocator subchunk struct to all zeros

2022-07-14 Thread Darren Kenny
Hi Ross, This looks good to me. On Thursday, 2022-07-14 at 09:41:28 -04, Ross Philipson wrote: > The way the code is written the tofree variable would never be > passed to the free_subchunk() function uninitialized. Coverity > cannot determine this and flags the situation as "Using uninitialized

[PATCH] Initialize local relocator subchunk struct to all zeros

2022-07-14 Thread Ross Philipson
The way the code is written the tofree variable would never be passed to the free_subchunk() function uninitialized. Coverity cannot determine this and flags the situation as "Using uninitialized value...". The fix is just to initialize the local struct. Fixes: CID 314016 Signed-off-by: Ross Phil