Re: [PATCH] Function parameters support

2010-05-19 Thread BVK Chaitanya
Committed into exp. -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Function parameters support

2010-05-18 Thread Vladimir 'φ-coder/phcoder' Serbinenko
BVK Chaitanya wrote: > On Wed, May 5, 2010 at 11:06 PM, Seth Goldberg > wrote: > >> This is a *great* start, but can you please add support for $* ... >> >> > > Support for $@, $* and their double quoted forms is added. Its > available in people/bvk/func-params branch. > > One known bug

Re: [PATCH] Function parameters support

2010-05-11 Thread Seth Goldberg
Quoting BVK Chaitanya, who wrote the following on Wed, 12 May 2010: On Wed, May 5, 2010 at 11:06 PM, Seth Goldberg wrote:  This is a *great* start, but can you please add support for $* ... Support for $@, $* and their double quoted forms is added. Its available in people/bvk/func-params

Re: [PATCH] Function parameters support

2010-05-11 Thread BVK Chaitanya
On Wed, May 5, 2010 at 11:06 PM, Seth Goldberg wrote: > >  This is a *great* start, but can you please add support for $* ... > Support for $@, $* and their double quoted forms is added. Its available in people/bvk/func-params branch. One known bug is, "$@" currently expands to "" when no param

Re: [PATCH] Function parameters support

2010-05-11 Thread BVK Chaitanya
2010/5/9 Vladimir 'φ-coder/phcoder' Serbinenko : > The only place where new scope is added or removed is: > +  grub_list_push (GRUB_AS_LIST_P (&scope), GRUB_AS_LIST (&new_scope)); > + > +  ret = grub_script_execute (func->func); > + > +  grub_list_pop (GRUB_AS_LIST_P (&scope)); > + > So you can act

Re: [PATCH] Function parameters support

2010-05-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
BVK Chaitanya wrote: > Hi, > > > Attached patch adds function parameters ($1, $2, etc. and $#) support > to GRUB script.. Shell expansion for "$@" and $@ specials is not yet > available. > > PS: It needs to be applied over my earlier, remove grub_script_cmdblock > patch. > > + grub_e

Re: [PATCH] Function parameters support

2010-05-06 Thread BVK Chaitanya
On Wed, May 5, 2010 at 11:06 PM, Seth Goldberg wrote: > >  This is a *great* start, but can you please add support for $* as well as a > shift operator (though shift is not as useful when there are no looping > constructs) shift command is now available in people/bvk/shift-cmd branch. Support for

Re: [PATCH] Function parameters support

2010-05-05 Thread Seth Goldberg
Hi! Quoting BVK Chaitanya, who wrote the following on Wed, 5 May 2010: Hi, Attached patch adds function parameters ($1, $2, etc. and $#) support to GRUB script.. Shell expansion for "$@" and $@ specials is not yet available. This is a *great* start, but can you please add support for $*

[PATCH] Function parameters support

2010-05-05 Thread BVK Chaitanya
Hi, Attached patch adds function parameters ($1, $2, etc. and $#) support to GRUB script.. Shell expansion for "$@" and $@ specials is not yet available. PS: It needs to be applied over my earlier, remove grub_script_cmdblock patch. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar