Re: [PATCH] Fix target tool check logic

2009-04-14 Thread Pavel Roskin
On Wed, 2009-04-15 at 00:45 +0900, Yoshinori K. Okuji wrote: > On Saturday 11 April 2009 22:16:58 Pavel Roskin wrote: > > Quoting "Yoshinori K. Okuji" : > > > "test -n" should be avoided. Maybe this is not necessary nowadays, but my > > > old lesson was to use "test x$target_alias != x" instead for

Re: [PATCH] Fix target tool check logic

2009-04-14 Thread Yoshinori K. Okuji
On Saturday 11 April 2009 22:16:58 Pavel Roskin wrote: > Quoting "Yoshinori K. Okuji" : > > "test -n" should be avoided. Maybe this is not necessary nowadays, but my > > old lesson was to use "test x$target_alias != x" instead for portability. > > Well, "!=" was not very portable, either, maybe. >

Re: [PATCH] Fix target tool check logic

2009-04-11 Thread Pavel Roskin
Quoting "Yoshinori K. Okuji" : "test -n" should be avoided. Maybe this is not necessary nowadays, but my old lesson was to use "test x$target_alias != x" instead for portability. Well, "!=" was not very portable, either, maybe. I believe both "-n" and "!=" are found in Autoconf sources that ar

Re: [PATCH] Fix target tool check logic

2009-04-11 Thread Yoshinori K. Okuji
On Saturday 11 April 2009 13:58:26 Pavel Roskin wrote: > Hello! > > I promised this patch long ago, but didn't have a chance to implement > and test it. This patch would help users test GRUB using > cross-compilers. Many users would prefer to compile native GRUB > utilities (grub-mkimage etc) but

[PATCH] Fix target tool check logic

2009-04-10 Thread Pavel Roskin
Hello! I promised this patch long ago, but didn't have a chance to implement and test it. This patch would help users test GRUB using cross-compilers. Many users would prefer to compile native GRUB utilities (grub-mkimage etc) but create the bootloader for another platform. This is cur