Re: [PATCH] Fix syslinux_test in out-of-tree builds

2019-02-27 Thread Colin Watson
On Mon, Jan 14, 2019 at 02:15:14PM +0100, Daniel Kiper wrote: > On Wed, Jan 09, 2019 at 02:59:12PM +, Colin Watson wrote: > > +# Mimic simplify_filename from grub-core/lib/syslinux_parse.c, so that we > > OK, but I would like to see a comment before > grub-core/lib/syslinux_parse.c:simplify_fi

Re: [PATCH] Fix syslinux_test in out-of-tree builds

2019-01-14 Thread Daniel Kiper
On Wed, Jan 09, 2019 at 02:59:12PM +, Colin Watson wrote: > syslinux_parse simplifies some filenames by removing things like ".." > segments, but the tests assumed that @abs_top_srcdir@ would be > untouched, which is not true in the case of out-of-tree builds where > @abs_top_srcdir@ may contai

[PATCH] Fix syslinux_test in out-of-tree builds

2019-01-09 Thread Colin Watson
syslinux_parse simplifies some filenames by removing things like ".." segments, but the tests assumed that @abs_top_srcdir@ would be untouched, which is not true in the case of out-of-tree builds where @abs_top_srcdir@ may contain ".." segments. Performing the substitution requires some awkwardnes