Re: [PATCH] Fix CPUID documentation and return values

2009-08-01 Thread Robert Millan
On Fri, Jul 31, 2009 at 06:41:44PM +0200, Felix Zielcke wrote: > > Ah in the thread you said that > `if cpuid --long-mode; then ...; else ...; fi' > doestn't work. > > But I just tested this with > `if cpuid --long-mode; then echo true; else echo false; fi' > in qemu and in 32bit I get false and

Re: [PATCH] Fix CPUID documentation and return values

2009-07-31 Thread Felix Zielcke
Am Freitag, den 31.07.2009, 18:26 +0200 schrieb Robert Millan: > On Fri, Jul 31, 2009 at 06:19:11PM +0200, Felix Zielcke wrote: > > Am Freitag, den 31.07.2009, 18:07 +0200 schrieb Robert Millan: > > > On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko > > > wrote: > > > > On T

Re: [PATCH] Fix CPUID documentation and return values

2009-07-31 Thread Robert Millan
On Fri, Jul 31, 2009 at 06:19:11PM +0200, Felix Zielcke wrote: > Am Freitag, den 31.07.2009, 18:07 +0200 schrieb Robert Millan: > > On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote: > > > > On Tue, Jul 28,

Re: [PATCH] Fix CPUID documentation and return values

2009-07-31 Thread Felix Zielcke
Am Freitag, den 31.07.2009, 18:07 +0200 schrieb Robert Millan: > On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote: > > > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko > > > wrote: > > >

Re: [PATCH] Fix CPUID documentation and return values

2009-07-31 Thread Robert Millan
On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote: > > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> Hello. CPUID command currently doesn't return a real grub_err_t and > >

Re: [PATCH] Fix CPUID documentation and return values

2009-07-28 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan wrote: > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Hello. CPUID command currently doesn't return a real grub_err_t and >> errors aren't set which doesn't fit in grub2's design. >> Addirionally "help cpuid" doesn'

Re: [PATCH] Fix CPUID documentation and return values

2009-07-28 Thread Robert Millan
On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. CPUID command currently doesn't return a real grub_err_t and > errors aren't set which doesn't fit in grub2's design. > Addirionally "help cpuid" doesn't give really useful info. So for > future expandability an

[PATCH] Fix CPUID documentation and return values

2009-07-27 Thread Vladimir 'phcoder' Serbinenko
Hello. CPUID command currently doesn't return a real grub_err_t and errors aren't set which doesn't fit in grub2's design. Addirionally "help cpuid" doesn't give really useful info. So for future expandability and less confusion I propose the attached patch partially based on original patch by Robe