Re: [PATCH] Fix ACPI halt for certain DSDTs

2014-09-21 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Committed, thanks. On 03.07.2014 16:00, Valentin Dornauer wrote: > Thanks for the review, Andrey. > > On 2 Jul 2014, at 19:56, Andrey Borzenkov wrote: >>> + in skip_ext_op(), correctly parse OpRegionOp (TermArgs aren't always >>> + simply strings!); add function to skip TermArgs. >> >> It doe

Re: [PATCH] Fix ACPI halt for certain DSDTs

2014-08-19 Thread Valentin Dornauer
Hello GRUB people, any news on this patch? I’d be glad to clarify any open issues. Thanks! Valentin On 3 Jul 2014, at 16:00, Valentin Dornauer wrote: > Thanks for the review, Andrey. > > On 2 Jul 2014, at 19:56, Andrey Borzenkov wrote: >>> + in skip_ext_op(), correctly parse OpRegionOp (Ter

Re: [PATCH] Fix ACPI halt for certain DSDTs

2014-07-03 Thread Valentin Dornauer
Thanks for the review, Andrey. On 2 Jul 2014, at 19:56, Andrey Borzenkov wrote: >> +in skip_ext_op(), correctly parse OpRegionOp (TermArgs aren't always >> +simply strings!); add function to skip TermArgs. > > It does not really parse every possible value of Type2Opcode, so commit > mess

Re: [PATCH] Fix ACPI halt for certain DSDTs

2014-07-02 Thread Andrey Borzenkov
В Tue, 1 Jul 2014 01:55:22 +0200 Valentin Dornauer пишет: > Hello! > > GRUB2 currently seems to be unable to shut down my Fujitsu Lifebook > E744 laptop using ACPI. After some debugging, I nailed the problem > down to two problems within GRUB’s ‘acpihalt’ command. Please see > the attached patch

[PATCH] Fix ACPI halt for certain DSDTs

2014-06-30 Thread Valentin Dornauer
Hello! GRUB2 currently seems to be unable to shut down my Fujitsu Lifebook E744 laptop using ACPI. After some debugging, I nailed the problem down to two problems within GRUB’s ‘acpihalt’ command. Please see the attached patch for my solution. Without this patch I get the following: grub> halt