Re: [PATCH] Eliminate script line length limit

On Mon, Aug 24, 2009 at 5:46 PM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 04:39:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> +          but extends automaticlly when needed.  */ > > Typo :-) > > Other than this, it looks fine.  Thanks! > Fixed and comitted > -- > Robert Millan > >  The

Re: [PATCH] Eliminate script line length limit

On Mon, Aug 24, 2009 at 04:39:01PM +0200, Vladimir 'phcoder' Serbinenko wrote: > + but extends automaticlly when needed. */ Typo :-) Other than this, it looks fine. Thanks! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may a

Re: [PATCH] Eliminate script line length limit

On Sun, Aug 23, 2009 at 3:20 PM, Robert Millan wrote: > On Sat, Aug 22, 2009 at 04:30:08PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Making GNU GRUB more GNU ;) > > Good!  But please could you use NULL for pointers?  :-) > > Also, remember to include a ChangeLog entry. > > -- > Robert Millan >

Re: [PATCH] Eliminate script line length limit

On Sat, Aug 22, 2009 at 04:30:08PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Making GNU GRUB more GNU ;) Good! But please could you use NULL for pointers? :-) Also, remember to include a ChangeLog entry. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide

[PATCH] Eliminate script line length limit

Making GNU GRUB more GNU ;) -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/script/sh/function.c b/script/sh/function.c index 1e49c70..a3950a8 100644 --- a/script/sh/function.c +++ b/script/sh/function.c @@ -99,7 +99,7 @@ grub_