Re: [PATCH] ELF program header

2007-10-17 Thread Stefan Reinauer
* Robert Millan <[EMAIL PROTECTED]> [071014 14:00]: > > We tried the same but the patch was a lot bigger, trying to actually > > leave space in the beginning. Your patch might be enough, that would be > > really nice. > > That's the question. Do we really have to add more space, or is that space

Re: [PATCH] ELF program header

2007-10-16 Thread Marcin Kurek
Hell[o] > [...] I test this patch on Pegasos 1 and Pegasos 2 and in both cases grub image hangs on OF prompt when I tired to boot it :( Reverting it makes grub bootable again. -- --- Marcin 'Morgoth' Kurek --- ___ Grub-devel mailing list Grub-devel@

Re: [PATCH] ELF program header

2007-10-14 Thread Robert Millan
On Sat, Oct 13, 2007 at 12:03:37AM +0200, Stefan Reinauer wrote: > > /* FIXME: Should we support program headers at strange locations? */ > > if (ehdr->e_phoff + ehdr->e_phnum * ehdr->e_phentsize > MULTIBOOT_SEARCH) > > return grub_error (GRUB_ERR_BAD_OS, "program header at a too high > >

Re: [PATCH] ELF program header

2007-10-14 Thread Robert Millan
On Fri, Oct 12, 2007 at 03:24:06PM -0500, Andrei E. Warkentin wrote: > > I don't think the ELF TIS says anything about location of PHDRs. > That's the whole point of EHDR - so that the location, size of each > entry, and count can be variable. The only invalid case would be for > phoff or ph

Re: [PATCH] ELF program header

2007-10-12 Thread Stefan Reinauer
* Robert Millan <[EMAIL PROTECTED]> [071012 18:19]: > It seems that grub-mkimage generates awkward ELF files, in which the Program > header table is at the end of the file instead of right after the ELF header. > > > - Our own ELF loader doesn't like phdroff > 0x2000 either, from > loader/i

Re: [PATCH] ELF program header

2007-10-12 Thread Andrei E. Warkentin
12.10.2007, в 11:19, Robert Millan писал(а): It seems that grub-mkimage generates awkward ELF files, in which the Program header table is at the end of the file instead of right after the ELF header. I know very little about ELF, but: - This figure in ELF standard seems to indicate whi

[PATCH] ELF program header

2007-10-12 Thread Robert Millan
It seems that grub-mkimage generates awkward ELF files, in which the Program header table is at the end of the file instead of right after the ELF header. I know very little about ELF, but: - This figure in ELF standard seems to indicate which is the "normal" (not sure if mandatory) location