Re: [PATCH] Drop gnulib fix-base64.patch

2021-12-09 Thread Daniel Kiper
On Tue, Dec 07, 2021 at 03:34:29PM -0500, Robbie Harwood wrote: > Daniel Kiper writes: > > On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote: > >> Daniel Kiper writes: > >> > >> > Yeah, but I think it would require major overhaul. Does not it? If yes > >> > then maybe we should consi

Re: [PATCH] Drop gnulib fix-base64.patch

2021-12-07 Thread Robbie Harwood
Daniel Kiper writes: > On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote: >> Daniel Kiper writes: >> >> > Yeah, but I think it would require major overhaul. Does not it? If yes >> > then maybe we should consider move to the Kconfig or something like >> > that. >> >> Perhaps, but ple

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-30 Thread Daniel Kiper
On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote: > Daniel Kiper writes: > > > Yeah, but I think it would require major overhaul. Does not it? If yes > > then maybe we should consider move to the Kconfig or something like > > that. > > Perhaps, but please don't mistake me as voluntee

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-29 Thread Robbie Harwood
Daniel Kiper writes: > Yeah, but I think it would require major overhaul. Does not it? If yes > then maybe we should consider move to the Kconfig or something like > that. Perhaps, but please don't mistake me as volunteering for build system hacking - I'm mostly just here to upstream patches :)

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-25 Thread Daniel Kiper
On Wed, Nov 24, 2021 at 09:36:14AM -0500, Robbie Harwood wrote: > Daniel Kiper writes: > > > CC-ing Daren, Patrick and Vladimir... > > > > When I started looking at this issue I realized we have bigger problem > > here than lack of _GL_ATTRIBUTE_CONST definition. In general all _GL_* > > constants

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-24 Thread Robbie Harwood
Daniel Kiper writes: > CC-ing Daren, Patrick and Vladimir... > > When I started looking at this issue I realized we have bigger problem > here than lack of _GL_ATTRIBUTE_CONST definition. In general all _GL_* > constants land in config-util.h.in and finally in config-util.h. It > does not make a

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-23 Thread Daniel Kiper
CC-ing Daren, Patrick and Vladimir... On Tue, Nov 23, 2021 at 11:08:55AM -0500, Robbie Harwood wrote: > Daniel Axtens writes: > > > Robbie Harwood writes: > > > >> +/* For gnulib's base64 code. */ > >> +#define _GL_ATTRIBUTE_CONST /* empty */ > > > > Do we support any compiler so old or configur

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-23 Thread Robbie Harwood
Daniel Axtens writes: > Robbie Harwood writes: > >> +/* For gnulib's base64 code. */ >> +#define _GL_ATTRIBUTE_CONST /* empty */ > > Do we support any compiler so old or configuration so weird that we > can't simply use 'const' here? Unfortunately it's not quite that simple. _GL_ATTRIBUTE_CONS

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-23 Thread Daniel Axtens
Robbie Harwood writes: > Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and > subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f, > fix-base64.patch handled two problems we have using gnulib, which are > exerciesd by the base64 module but not directly caused by it. >

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-14 Thread Patrick Steinhardt
On Thu, Oct 28, 2021 at 03:22:27PM -0400, Robbie Harwood wrote: > Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and > subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f, > fix-base64.patch handled two problems we have using gnulib, which are > exerciesd by the base64 m

Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-03 Thread Darren Kenny
Hi Robbie, Just tried it in a build, and it works for me. On Thursday, 2021-10-28 at 15:22:27 -04, Robbie Harwood wrote: > Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and > subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f, > fix-base64.patch handled two problems

[PATCH] Drop gnulib fix-base64.patch

2021-10-28 Thread Robbie Harwood
Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f, fix-base64.patch handled two problems we have using gnulib, which are exerciesd by the base64 module but not directly caused by it. First, grub2 defines its own bool