On Tue, Dec 07, 2021 at 03:34:29PM -0500, Robbie Harwood wrote:
> Daniel Kiper writes:
> > On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote:
> >> Daniel Kiper writes:
> >>
> >> > Yeah, but I think it would require major overhaul. Does not it? If yes
> >> > then maybe we should consi
Daniel Kiper writes:
> On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote:
>> Daniel Kiper writes:
>>
>> > Yeah, but I think it would require major overhaul. Does not it? If yes
>> > then maybe we should consider move to the Kconfig or something like
>> > that.
>>
>> Perhaps, but ple
On Mon, Nov 29, 2021 at 06:21:46PM -0500, Robbie Harwood wrote:
> Daniel Kiper writes:
>
> > Yeah, but I think it would require major overhaul. Does not it? If yes
> > then maybe we should consider move to the Kconfig or something like
> > that.
>
> Perhaps, but please don't mistake me as voluntee
Daniel Kiper writes:
> Yeah, but I think it would require major overhaul. Does not it? If yes
> then maybe we should consider move to the Kconfig or something like
> that.
Perhaps, but please don't mistake me as volunteering for build system
hacking - I'm mostly just here to upstream patches :)
On Wed, Nov 24, 2021 at 09:36:14AM -0500, Robbie Harwood wrote:
> Daniel Kiper writes:
>
> > CC-ing Daren, Patrick and Vladimir...
> >
> > When I started looking at this issue I realized we have bigger problem
> > here than lack of _GL_ATTRIBUTE_CONST definition. In general all _GL_*
> > constants
Daniel Kiper writes:
> CC-ing Daren, Patrick and Vladimir...
>
> When I started looking at this issue I realized we have bigger problem
> here than lack of _GL_ATTRIBUTE_CONST definition. In general all _GL_*
> constants land in config-util.h.in and finally in config-util.h. It
> does not make a
CC-ing Daren, Patrick and Vladimir...
On Tue, Nov 23, 2021 at 11:08:55AM -0500, Robbie Harwood wrote:
> Daniel Axtens writes:
>
> > Robbie Harwood writes:
> >
> >> +/* For gnulib's base64 code. */
> >> +#define _GL_ATTRIBUTE_CONST /* empty */
> >
> > Do we support any compiler so old or configur
Daniel Axtens writes:
> Robbie Harwood writes:
>
>> +/* For gnulib's base64 code. */
>> +#define _GL_ATTRIBUTE_CONST /* empty */
>
> Do we support any compiler so old or configuration so weird that we
> can't simply use 'const' here?
Unfortunately it's not quite that simple. _GL_ATTRIBUTE_CONS
Robbie Harwood writes:
> Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and
> subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f,
> fix-base64.patch handled two problems we have using gnulib, which are
> exerciesd by the base64 module but not directly caused by it.
>
On Thu, Oct 28, 2021 at 03:22:27PM -0400, Robbie Harwood wrote:
> Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and
> subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f,
> fix-base64.patch handled two problems we have using gnulib, which are
> exerciesd by the base64 m
Hi Robbie,
Just tried it in a build, and it works for me.
On Thursday, 2021-10-28 at 15:22:27 -04, Robbie Harwood wrote:
> Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and
> subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f,
> fix-base64.patch handled two problems
Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and
subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f,
fix-base64.patch handled two problems we have using gnulib, which are
exerciesd by the base64 module but not directly caused by it.
First, grub2 defines its own bool
12 matches
Mail list logo