Re: [PATCH] Detect endian in cpio fs

2009-08-28 Thread Vladimir 'phcoder' Serbinenko
On Fri, Aug 28, 2009 at 2:20 PM, Bean wrote: > On Fri, Aug 28, 2009 at 8:03 PM, Vladimir 'phcoder' > Serbinenko wrote: >> On Thu, Aug 27, 2009 at 10:27 AM, Bean wrote: >>> Hi, >>> >>> This patch allows to access big/little endian cpio archive from >>> big/little endian machine. >> Quick glance show

Re: [PATCH] Detect endian in cpio fs

2009-08-28 Thread Bean
On Fri, Aug 28, 2009 at 8:03 PM, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Aug 27, 2009 at 10:27 AM, Bean wrote: >> Hi, >> >> This patch allows to access big/little endian cpio archive from >> big/little endian machine. > Quick glance showed that you use swap_bytes. Could you use > grub_*_to_c

Re: [PATCH] Detect endian in cpio fs

2009-08-28 Thread Vladimir 'phcoder' Serbinenko
On Thu, Aug 27, 2009 at 10:27 AM, Bean wrote: > Hi, > > This patch allows to access big/little endian cpio archive from > big/little endian machine. Quick glance showed that you use swap_bytes. Could you use grub_*_to_cpu* instead? This would simplify the future maintainability if someone decides t

[PATCH] Detect endian in cpio fs

2009-08-27 Thread Bean
Hi, This patch allows to access big/little endian cpio archive from big/little endian machine. -- Bean gitgrub home: http://github.com/grub/grub/ my fork page: http://github.com/bean123/grub/ diff --git a/fs/cpio.c b/fs/cpio.c index 1ec4ebe..2affa2e 100644 --- a/fs/cpio.c +++ b/fs/cpio.c @@ -76