Re: [PATCH] Create environment block safely

2009-10-02 Thread richardvo...@gmail.com
>> You might also need to check for the alternate name, in case the >> operation failed after writing the new content and unlinking the old >> file, but before renaming the new file. > > There is no old file here, or if there is then the user has already > explicitly indicated that they don't care

Re: [PATCH] Create environment block safely

2009-10-02 Thread Colin Watson
On Thu, Oct 01, 2009 at 09:31:55PM -0500, richardvo...@gmail.com wrote: > On Wed, Sep 30, 2009 at 5:54 PM, Colin Watson wrote: > > If grub-editenv create is interrupted, it's theoretically possible for > > it to create an incomplete block that future grub-editenv calls won't > > recognise. It woul

Re: [PATCH] Create environment block safely

2009-10-01 Thread richardvo...@gmail.com
On Wed, Sep 30, 2009 at 5:54 PM, Colin Watson wrote: > If grub-editenv create is interrupted, it's theoretically possible for > it to create an incomplete block that future grub-editenv calls won't > recognise. It would be better for it to atomically create either a > complete block or nothing. An

Re: [PATCH] Create environment block safely

2009-10-01 Thread Colin Watson
On Wed, Sep 30, 2009 at 11:54:30PM +0100, Colin Watson wrote: > If grub-editenv create is interrupted, it's theoretically possible for > it to create an incomplete block that future grub-editenv calls won't > recognise. It would be better for it to atomically create either a > complete block or not

[PATCH] Create environment block safely

2009-09-30 Thread Colin Watson
If grub-editenv create is interrupted, it's theoretically possible for it to create an incomplete block that future grub-editenv calls won't recognise. It would be better for it to atomically create either a complete block or nothing. Any objections? 2009-09-30 Colin Watson * util/grub