Re: [PATCH] Compiler warning in grub_cmdline_get

2009-08-28 Thread Colin Watson
On Fri, Aug 28, 2009 at 02:48:45PM +0200, Robert Millan wrote: > On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote: > > 2009-08-27 Colin Watson > > > > * normal/cmdline.c (grub_cmdline_get): Supply a format string as > > the first argument to grub_printf. > > Thanks Colin.

Re: [PATCH] Compiler warning in grub_cmdline_get

2009-08-28 Thread Robert Millan
On Thu, Aug 27, 2009 at 12:55:18AM +0100, Colin Watson wrote: > I don't think this can actually cause a real problem, but it's a > compiler warning since it might (e.g. if prompt ever contained "%"). > > /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c: > In function ‘gr

[PATCH] Compiler warning in grub_cmdline_get

2009-08-26 Thread Colin Watson
I don't think this can actually cause a real problem, but it's a compiler warning since it might (e.g. if prompt ever contained "%"). /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+20090826/normal/cmdline.c: In function ‘grub_cmdline_get’: /home/cjwatson/src/ubuntu/grub2/tmp/grub2-1.96+200908