It seems this has been leftover, probably because my response looked like
I objected to it (which I don't, it's perfectly reasonable cleanup).
I'm committing it.
On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote:
> `grub_module_header_types' should not be a field at all. Move enum
>
On Sun, Aug 23, 2009 at 01:08:05PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Sun, Aug 23, 2009 at 12:50 PM, Robert Millan wrote:
> > On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote:
> >> +enum
> >> +{
> >> + OBJ_TYPE_ELF,
> >> + OBJ_TYPE_MEMDISK,
> >> + OBJ_TYPE_CONFIG
> >> +
On Sun, Aug 23, 2009 at 12:50 PM, Robert Millan wrote:
> On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote:
>> +enum
>> +{
>> + OBJ_TYPE_ELF,
>> + OBJ_TYPE_MEMDISK,
>> + OBJ_TYPE_CONFIG
>> +};
>
> Do we actually use OBJ_TYPE_CONFIG ? I think it's there in the framework,
> but we don'
On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote:
> +enum
> +{
> + OBJ_TYPE_ELF,
> + OBJ_TYPE_MEMDISK,
> + OBJ_TYPE_CONFIG
> +};
Do we actually use OBJ_TYPE_CONFIG ? I think it's there in the framework,
but we don't provide any means to use it. Instead, grub-mkrescue puts grub.cfg
`grub_module_header_types' should not be a field at all. Move enum
outside struct.
Keep using an 8-bit integer for `type', but make it unsigned. Remove all
byteswapping for `type', as it only has one byte.
Make `size' 32-bit, as grub-mkimage already assumes. 4 gigabytes
should be enough for a
