Bean <[EMAIL PROTECTED]> writes:
[...]
>> > thanks, if there is no problem, i would commit this now.
>>
>> If you mean your patch, that's fine for me. Please do not forget to
>> rename script_1. Are there any other issues I brought up?
>
> ok, commited.
Thanks! :-)
--
Marco
___
On Jan 15, 2008 10:33 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Bean <[EMAIL PROTECTED]> writes:
>
>
> > On Jan 15, 2008 8:41 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> >> Right. I am completely unhappy with the lexer as it is now... :-/
> >> The main reason for writing it manually is tha
Bean <[EMAIL PROTECTED]> writes:
> On Jan 15, 2008 8:41 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> Right. I am completely unhappy with the lexer as it is now... :-/
>> The main reason for writing it manually is that flex depends on all
>> kinds of stuff I do not want in GRUB. Like reading f
On Jan 15, 2008 8:41 PM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> Right. I am completely unhappy with the lexer as it is now... :-/
> The main reason for writing it manually is that flex depends on all
> kinds of stuff I do not want in GRUB. Like reading files, etc.
>
> Thanks a lot for fixing
Bean <[EMAIL PROTECTED]> writes:
>> > if grub_error is set, it will effect the parser, caused menu not to be
>> > showed, etc.
>>
>> Right, but do you want to see a menu if not everything is correctly executed?
>
> the problem is that it's not always an error when grub_errno is set,
> for example,
> > if grub_error is set, it will effect the parser, caused menu not to be
> > showed, etc.
>
> Right, but do you want to see a menu if not everything is correctly executed?
the problem is that it's not always an error when grub_errno is set,
for example, the test command use it to report whether
Bean <[EMAIL PROTECTED]> writes:
> On Jan 14, 2008 2:42 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
>> > @@ -99,6 +101,9 @@ grub_script_execute_cmdline (struct grub_script_cmd
>> > *cmd)
>> >grubcmd = grub_command_find (cmdline->cmdname);
>> >if (! grubcmd)
>> > {
>> > + /* Ign
On Jan 14, 2008 2:42 AM, Marco Gerards <[EMAIL PROTECTED]> wrote:
> > @@ -99,6 +101,9 @@ grub_script_execute_cmdline (struct grub_script_cmd *cmd)
> >grubcmd = grub_command_find (cmdline->cmdname);
> >if (! grubcmd)
> > {
> > + /* Ignore errors. */
> > + grub_errno = GRUB_ER
Bean <[EMAIL PROTECTED]> writes:
Hi,
> I write a patch for parser related bug, it fix the following problems:
>
> 1, major modification for parse.y, now it should work better. For example,
>
> if echo aa; echo bb; then echo cc; fi
>
> it works properly now.
Nice :-)
> 2, Check for undefined var
Hi,
I write a patch for parser related bug, it fix the following problems:
1, major modification for parse.y, now it should work better. For example,
if echo aa; echo bb; then echo cc; fi
it works properly now.
2, Check for undefined variable. for example, if AA is not defined,
echo $AA
caus
10 matches
Mail list logo
