Re: [PATCH] Backup old boot sectors before installation

2010-01-07 Thread r...@aybabtu.com
On Tue, Dec 29, 2009 at 03:21:08PM +0800, Zhu Yi wrote: > On Tue, 2009-12-29 at 11:59 +0800, richardvo...@gmail.com wrote: > > > If we decide so, we go back to option 1 (my original > > implementation). > > > Because the backup file format is not important any more as it is > > > totally transparen

Re: [PATCH] Backup old boot sectors before installation

2009-12-28 Thread Zhu Yi
On Tue, 2009-12-29 at 11:59 +0800, richardvo...@gmail.com wrote: > > If we decide so, we go back to option 1 (my original > implementation). > > Because the backup file format is not important any more as it is > > totally transparent to the restorers. Am I right? > > Another option would be to st

Re: [PATCH] Backup old boot sectors before installation

2009-12-28 Thread richardvo...@gmail.com
On Mon, Dec 28, 2009 at 9:21 PM, Zhu Yi wrote: > On Tue, 2009-12-29 at 06:04 +0800, Isaac Dupree wrote: >> > Option 1~3 requires the recover has the knowledge of the backup file >> > format somehow, but a simple dd is enough for option 4. What do you >> > think? >> >> If the partitioning had been

Re: [PATCH] Backup old boot sectors before installation

2009-12-28 Thread Zhu Yi
On Tue, 2009-12-29 at 06:04 +0800, Isaac Dupree wrote: > > Option 1~3 requires the recover has the knowledge of the backup file > > format somehow, but a simple dd is enough for option 4. What do you > > think? > > If the partitioning had been changed in the mean time, 4 would overwrite > it with

Re: [PATCH] Backup old boot sectors before installation

2009-12-28 Thread Isaac Dupree
Zhu Yi wrote: On Fri, 2009-12-25 at 05:21 +0800, Robert Millan wrote: I think making a backup is a fine idea, but I'd rather avoid the "option creep". It doesn't hurt to simply dump the files in /boot/grub/. If user later discovers that valuable data was overwritten, she can figure out how to

Re: [PATCH] Backup old boot sectors before installation

2009-12-27 Thread Zhu Yi
On Fri, 2009-12-25 at 05:21 +0800, Robert Millan wrote: > I think making a backup is a fine idea, but I'd rather avoid the "option > creep". It doesn't hurt to simply dump the files in /boot/grub/. If user > later discovers that valuable data was overwritten, she can figure out > how to call dd j

Re: [PATCH] Backup old boot sectors before installation

2009-12-24 Thread Robert Millan
On Fri, Dec 11, 2009 at 05:26:01PM +0800, Zhu Yi wrote: > Add a feature to backup the old boot sectors before overwritting > them with grub2 boot and core images. Users can later recover the > previous boot sectors with grub-install --recover option. > > P.S. I found this might be a useful feature

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread Isaac Dupree
Zhu Yi wrote: On Mon, 2009-12-14 at 11:24 +0800, Isaac Dupree wrote: hmm bootloader installation is often done by distro install-CDs. Will the distro be smart enough to save these backups to the disk somewhere sensible, rather than to the temporary in-memory filesystem? The backup files

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread Zhu Yi
On Mon, 2009-12-14 at 11:24 +0800, Isaac Dupree wrote: > hmm > bootloader installation is often done by distro install-CDs. > > Will the distro be smart enough to save these backups to the disk > somewhere sensible, rather than to the temporary in-memory > filesystem? The backup files will

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread Zhu Yi
On Mon, 2009-12-14 at 10:58 +0800, Isaac Dupree wrote: > maybe the boot sector is small enough that we could just keep > separate > additional backup files each time grub-setup/grub-install is used? > e.g. > backup-1 > backup-2 > backup-3 > > or maybe using date/time instead of sequential numberi

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread Isaac Dupree
richardvo...@gmail.com wrote: An automatic backup is valuable both for savvy users who know how but forgot, and for those who will find the backup and restore procedures online only after their computer is bricked. hmm bootloader installation is often done by distro install-CDs. Will the d

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread Zhu Yi
On Mon, 2009-12-14 at 10:59 +0800, kashyap garimella wrote: > In conclusion, I believe this backup feature is useful and > either > implementation should do the work. If we can merge the good > parts of > them, we can get a better one. I just curious why the

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread richardvo...@gmail.com
>> In conclusion, I believe this backup feature is useful and either >> implementation should do the work. If we can merge the good parts of >> them, we can get a better one. I just curious why the thread is stuck >> since September. Any blocking issues with it? Can we keep the topic >> moving forw

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread kashyap garimella
On Mon, Dec 14, 2009 at 8:18 AM, Zhu Yi wrote: > On Fri, 2009-12-11 at 17:39 +0800, Felix Zielcke wrote: > > > > Someone already made a patch for this inside grub-setup > > See here and also for the discussion of it: > > http://lists.gnu.org/archive/html/grub-devel/2009-09/msg00242.html > > Thank

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread Isaac Dupree
Zhu Yi wrote: 3. The backup policy. Garimella's patch backups every time before grub-setup overwrote the boot sectors. There might be a problem when someone run grub-setup/grub-install twice. So the backup image ends up with the grub2 boot sectors. This makes the recovery for the "real" boot sec

Re: [PATCH] Backup old boot sectors before installation

2009-12-13 Thread Zhu Yi
On Fri, 2009-12-11 at 17:39 +0800, Felix Zielcke wrote: > > Someone already made a patch for this inside grub-setup > See here and also for the discussion of it: > http://lists.gnu.org/archive/html/grub-devel/2009-09/msg00242.html Thanks. If I knew this patch, I won't try to write one my own. I d

Re: [PATCH] Backup old boot sectors before installation

2009-12-11 Thread Carles Pina i Estany
Hi, On Dec/11/2009, Felix Zielcke wrote: > Am Freitag, den 11.12.2009, 17:26 +0800 schrieb Zhu Yi: > > Add a feature to backup the old boot sectors before overwritting > > them with grub2 boot and core images. Users can later recover the > > previous boot sectors with grub-install --recover optio

Re: [PATCH] Backup old boot sectors before installation

2009-12-11 Thread Felix Zielcke
Am Freitag, den 11.12.2009, 17:26 +0800 schrieb Zhu Yi: > Add a feature to backup the old boot sectors before overwritting > them with grub2 boot and core images. Users can later recover the > previous boot sectors with grub-install --recover option. > > P.S. I found this might be a useful feature

[PATCH] Backup old boot sectors before installation

2009-12-11 Thread Zhu Yi
Add a feature to backup the old boot sectors before overwritting them with grub2 boot and core images. Users can later recover the previous boot sectors with grub-install --recover option. P.S. I found this might be a useful feature after I overwrote my second PGP encrypted hard disk (Windows XP i