Re: [PATCH] Add testpci command (v4)

2013-04-05 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.01.2013 06:12, Jonathan McDowell wrote: > On Sun, Jan 20, 2013 at 11:27:28PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> > On 13.10.2012 00:18, Jonathan McDowell wrote: > (some code) >> > ARG_TYPE_INT means that the argument is decimal integer but it's not the >> > case here. >>

Re: [PATCH] Add testpci command (v5)

2013-01-27 Thread Jonathan McDowell
On Thu, Jan 24, 2013 at 09:12:41PM -0800, Jonathan McDowell wrote: > On Sun, Jan 20, 2013 at 11:27:28PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: > > On 13.10.2012 00:18, Jonathan McDowell wrote: > (some code) > > ARG_TYPE_INT means that the argument is decimal integer but it's not the

Re: [PATCH] Add testpci command (v4)

2013-01-25 Thread Andrey Borzenkov
On Fri, Jan 25, 2013 at 12:42 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 25.01.2013 06:22, Andrey Borzenkov wrote: > >> Does not "testpci" without parameters always return TRUE? >> > > No, it tests for presence of PCI bus. This is actually a potentially > useful functionality. Ah, OK.

Re: [PATCH] Add testpci command (v4)

2013-01-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.01.2013 06:22, Andrey Borzenkov wrote: > Does not "testpci" without parameters always return TRUE? > No, it tests for presence of PCI bus. This is actually a potentially useful functionality. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko signature.asc Description: OpenPGP digital si

Re: [PATCH] Add testpci command (v4)

2013-01-24 Thread Andrey Borzenkov
Does not "testpci" without parameters always return TRUE? On Fri, Jan 25, 2013 at 9:12 AM, Jonathan McDowell wrote: > On Sun, Jan 20, 2013 at 11:27:28PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> On 13.10.2012 00:18, Jonathan McDowell wrote: > (some code) >> ARG_TYPE_INT means that

Re: [PATCH] Add testpci command (v4)

2013-01-24 Thread Jonathan McDowell
On Sun, Jan 20, 2013 at 11:27:28PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 13.10.2012 00:18, Jonathan McDowell wrote: (some code) > ARG_TYPE_INT means that the argument is decimal integer but it's not the > case here. > Please follow indent style. > You need to check grub_errno t

Re: [PATCH] Add testpci command (v3)

2013-01-20 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.10.2012 00:18, Jonathan McDowell wrote: > - > === modified file 'docs/grub.texi' > --- docs/grub.texi2012-07-31 22:18:57 + > +++ docs/grub.texi2012-10-12 22:13:23 + > @@ -3302,6 +3302,7 @@ > * search:: Search devices by file, label, or UUID > * send

Re: [PATCH] Add testpci command (v3)

2012-10-12 Thread Jonathan McDowell
On Wed, Oct 10, 2012 at 05:21:45PM -0700, Jonathan McDowell wrote: > On Thu, Sep 27, 2012 at 02:42:11PM -0700, Jonathan McDowell wrote: > > I have a machine with both Linux and Windows installed on the hard > > drive. Linux runs on the bare metal and I occasionally run the Windows > > install in a

Re: [PATCH] Add testpci command (v2)

2012-10-10 Thread Andrey Borzenkov
В Ср., 10/10/2012 в 17:21 -0700, Jonathan McDowell пишет: > On Thu, Sep 27, 2012 at 02:42:11PM -0700, Jonathan McDowell wrote: > > I have a machine with both Linux and Windows installed on the hard > > drive. Linux runs on the bare metal and I occasionally run the Windows > > install in a VM using

Re: [PATCH] Add testpci command (v2)

2012-10-10 Thread Jonathan McDowell
On Thu, Sep 27, 2012 at 02:42:11PM -0700, Jonathan McDowell wrote: > I have a machine with both Linux and Windows installed on the hard > drive. Linux runs on the bare metal and I occasionally run the Windows > install in a VM using KVM pointed at /dev/sda. However if I'm not quick > enough, or Win

Re: [PATCH] Add testpci command

2012-09-28 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.09.2012 23:42, Jonathan McDowell wrote: > I have a machine with both Linux and Windows installed on the hard > drive. Linux runs on the bare metal and I occasionally run the Windows > install in a VM using KVM pointed at /dev/sda. However if I'm not quick > enough, or Windows decides to rebo

Re: [PATCH] Add testpci command

2012-09-28 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 28.09.2012 14:10, Andrey Borzenkov wrote: > В Чт., 27/09/2012 в 14:42 -0700, Jonathan McDowell пишет: > >> | if testpci 8086:1237; then > > What about making it "testpci --vendor XXX --product YYY" to leave room > for possible extensions in the future? This is a good idea. It allows to easil

Re: [PATCH] Add testpci command

2012-09-28 Thread Andrey Borzenkov
В Чт., 27/09/2012 в 14:42 -0700, Jonathan McDowell пишет: > | if testpci 8086:1237; then What about making it "testpci --vendor XXX --product YYY" to leave room for possible extensions in the future? -andrey ___ Grub-devel mailing list Grub-devel@gnu

Re: [PATCH] Add testpci command

2012-09-27 Thread Seth Goldberg
Bah. Ignore that. I see your problem now. --S Quoting Seth Goldberg, who wrote the following on Thu, 27 Sep 2012: Why don't you just put a file on that virtual disk somewhere, call it _I_AM_A_VIRTUAL_MACHINE_, and just test for its existence using the comprehensive filesystem support

Re: [PATCH] Add testpci command

2012-09-27 Thread Seth Goldberg
Why don't you just put a file on that virtual disk somewhere, call it _I_AM_A_VIRTUAL_MACHINE_, and just test for its existence using the comprehensive filesystem support of GRUB 2 ? --S Quoting Jonathan McDowell, who wrote the following on Thu, 27 Sep 2012: I have a machine with both L

[PATCH] Add testpci command

2012-09-27 Thread Jonathan McDowell
I have a machine with both Linux and Windows installed on the hard drive. Linux runs on the bare metal and I occasionally run the Windows install in a VM using KVM pointed at /dev/sda. However if I'm not quick enough, or Windows decides to reboot when I'm not around to notice, the grub running unde