Am Dienstag, den 05.08.2008, 15:36 +0200 schrieb Felix Zielcke:
> Am Dienstag, den 05.08.2008, 15:03 +0200 schrieb Felix Zielcke:
>
> >
> > I moved it now to include/util/misc.h so in the future it can be used
> > for all utils.
>
> I just recompiled it with an 'svn up' before and a full compile
Am Dienstag, den 05.08.2008, 15:03 +0200 schrieb Felix Zielcke:
>
> I moved it now to include/util/misc.h so in the future it can be used
> for all utils.
I just recompiled it with an 'svn up' before and a full compile is
broken with that way.
I just include config.h now which defines this.
2
Felix Zielcke <[EMAIL PROTECTED]> writes:
> Am Freitag, den 01.08.2008, 17:09 +0200 schrieb Felix Zielcke:
>
>> Maybe there's a way to make it even better so please comment all of you
>> grub-devels :)
>
> Thanks to Robert who suggested asprintf
>
> I hope the #define _GNU_SOURCE which is needed f
Am Freitag, den 01.08.2008, 17:09 +0200 schrieb Felix Zielcke:
> Maybe there's a way to make it even better so please comment all of you
> grub-devels :)
Thanks to Robert who suggested asprintf
I hope the #define _GNU_SOURCE which is needed for it isn't a problem,
you use anyway gcc specific ext
Am Freitag, den 01.08.2008, 15:12 +0200 schrieb Robert Millan:
> This looks fine, but I'd suggest to avoid hardcoding numbers when possible.
> So
> if you're adding 5 because that's the size of "/dev/", I think it's a good
> idea
> to use sizeof("/dev/")-1, and so on. This way the code is much
On Wed, Jul 30, 2008 at 09:11:22PM +0200, Felix Zielcke wrote:
> + else if (os_dev[7] == '/' && os_dev[8] >= '0' && os_dev[8] <= '9')
> + {
> + memcpy (grub_dev, os_dev + 5, 2);
> + memcpy (grub_dev + 2, os_dev + 8, 5);
> + grub_dev[7] = '\0';
> + }
This looks fine,
Here's a patch to add support for the /dev/md/N form of mdraid devices.
2008-07-30 Felix Zielcke <[EMAIL PROTECTED]>
* util/getroot.c: Add support for /dev/md/N style mdraid devices.
Index: util/getroot.c
===
--- util/g
