Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.11.2013 16:23, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 04:19:48PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall) mov lr, pc ldr pc, grub_uboot_syscall_ptr str r8, gd_backup

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Leif Lindholm
On Sat, Nov 16, 2013 at 04:19:48PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > >> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall) > >> mov lr, pc > >> ldr pc, grub_uboot_syscall_ptr > >> str r8, gd_backup > >> + str r9, gd_backup + 4 > >>

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.11.2013 15:45, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 03:28:35PM +0100, Leif Lindholm wrote: >> I pushed the above, and almost immediately I realised that in this >> situation we also need to store u-boot's version of r9 on return: >> >> diff --git a/grub-core/kern/arm/uboot/startup.S

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Leif Lindholm
On Sat, Nov 16, 2013 at 03:28:35PM +0100, Leif Lindholm wrote: > I pushed the above, and almost immediately I realised that in this > situation we also need to store u-boot's version of r9 on return: > > diff --git a/grub-core/kern/arm/uboot/startup.S > b/grub-core/kern/arm/uboot/start > index df

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.11.2013 15:28, Leif Lindholm wrote: > Argh... > > I pushed the above, and almost immediately I realised that in this > situation we also need to store u-boot's version of r9 on return: > > diff --git a/grub-core/kern/arm/uboot/startup.S > b/grub-core/kern/arm/uboot/start > index df1e329..2

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Leif Lindholm
On Sat, Nov 16, 2013 at 03:03:16PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > Updated patch attached. > > Go ahead. Argh... I pushed the above, and almost immediately I realised that in this situation we also need to store u-boot's version of r9 on return: diff --git a/grub-core/k

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.11.2013 14:53, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 02:17:51PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >>> From an ABI perspective, grub_uboot_syscall is a veneer: >>> the only visible side effect it is permitted to have is to corrupt r12. >>> >> According to wikipedi

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Leif Lindholm
On Sat, Nov 16, 2013 at 02:17:51PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > From an ABI perspective, grub_uboot_syscall is a veneer: > > the only visible side effect it is permitted to have is to corrupt r12. > > > According to wikipedia: > "Subroutines must preserve the contents o

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Andrey Borzenkov
В Sat, 16 Nov 2013 14:17:51 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 16.11.2013 14:00, Leif Lindholm wrote: > > On Sat, Nov 16, 2013 at 01:49:51PM +0100, Vladimir 'φ-coder/phcoder' > > Serbinenko wrote: > >> On 16.11.2013 13:39, Leif Lindholm wrote: > >>> - str r9, transition_

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.11.2013 14:00, Leif Lindholm wrote: > On Sat, Nov 16, 2013 at 01:49:51PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> On 16.11.2013 13:39, Leif Lindholm wrote: >>> - str r9, transition_space + 8 >> You need to save r9. Otherwise GRUB will crash if compiled with clang. > >

Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Leif Lindholm
On Sat, Nov 16, 2013 at 01:49:51PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 16.11.2013 13:39, Leif Lindholm wrote: > > - str r9, transition_space + 8 > You need to save r9. Otherwise GRUB will crash if compiled with clang. Hmm, but this is a bug in clang in that case. From

Re: [PATCH] [ARM] Enable boot module for arm

2013-11-16 Thread Andrey Borzenkov
В Sat, 16 Nov 2013 01:45:31 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 15.11.2013 20:13, Andrey Borzenkov wrote: > > В Sat, 27 Jul 2013 06:21:56 +0200 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >> On 27.07.2013 05:46, Andrey Borzenkov wrote: > >>> В Thu, 25 Jul 2013 17:

[PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

2013-11-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.11.2013 13:39, Leif Lindholm wrote: > - str r9, transition_space + 8 You need to save r9. Otherwise GRUB will crash if compiled with clang. signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.or

Re: [PATCH] [ARM] Enable boot module for arm

2013-11-16 Thread Leif Lindholm
On Sat, Nov 16, 2013 at 01:45:31AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > Now the problem is to do anything useful hard disk is needed and > > default u-boot for versatileqemu does not seem to offer any support (or > > may be it is qemu -M versatilepb). Were you successful in runn

Re: [PATCH] [ARM] Enable boot module for arm

2013-11-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 15.11.2013 20:13, Andrey Borzenkov wrote: > В Sat, 27 Jul 2013 06:21:56 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 27.07.2013 05:46, Andrey Borzenkov wrote: >>> В Thu, 25 Jul 2013 17:04:34 +0200 >>> Vladimir 'φ-coder/phcoder' Serbinenko пишет: >>> > ARM branch won't

Re: [PATCH] [ARM] Enable boot module for arm

2013-11-15 Thread Andrey Borzenkov
В Sat, 27 Jul 2013 06:21:56 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 27.07.2013 05:46, Andrey Borzenkov wrote: > > В Thu, 25 Jul 2013 17:04:34 +0200 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >>> > >> ARM branch won't be maintained anymore. My main problem with arm > >

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-28 Thread Andrey Borzenkov
В Sun, 28 Jul 2013 22:18:41 +0400 Andrey Borzenkov пишет: > В Sun, 28 Jul 2013 20:01:29 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > On 28.07.2013 18:51, Andrey Borzenkov wrote: > > > Load Address: 0800 > > > Entry Point: 0800 > > This obviously can't work if this

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-28 Thread Andrey Borzenkov
В Sun, 28 Jul 2013 20:01:29 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 28.07.2013 18:51, Andrey Borzenkov wrote: > > Load Address: 0800 > > Entry Point: 0800 > This obviously can't work if this address is unavailable. You need to > change linking address. > If you

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-28 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 28.07.2013 18:51, Andrey Borzenkov wrote: Load Address: 0800 Entry Point: 0800 This obviously can't work if this address is unavailable. You need to change linking address. ___ Grub-devel mailing list Grub-devel@gnu.org https://li

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-28 Thread Andrey Borzenkov
В Sat, 27 Jul 2013 16:44:39 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > It would be the first step, but my problem is, I cannot make it work > > even using concatenation. u-boot does show me correct image info for > > embedded grub, but I cannot launch it. Using default load address >

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
It would be the first step, but my problem is, I cannot make it work even using concatenation. u-boot does show me correct image info for embedded grub, but I cannot launch it. Using default load address 0x0800 qemu errors out because address is not in RAM (and it will not let me change amount

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-26 Thread Andrey Borzenkov
В Sat, 27 Jul 2013 06:21:56 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 27.07.2013 05:46, Andrey Borzenkov wrote: > > В Thu, 25 Jul 2013 17:04:34 +0200 > > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > >>> > >> ARM branch won't be maintained anymore. My main problem with arm > >

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.07.2013 05:46, Andrey Borzenkov wrote: В Thu, 25 Jul 2013 17:04:34 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: ARM branch won't be maintained anymore. My main problem with arm currently is that testsuite works neither for arm-efi nor for arm-uboot and I didn't find a way to make

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-26 Thread Andrey Borzenkov
В Thu, 25 Jul 2013 17:04:34 +0200 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > ARM branch won't be maintained anymore. My main problem with arm > currently is that testsuite works neither for arm-efi nor for arm-uboot > and I didn't find a way to make qemu load file from iso from either

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.07.2013 16:45, Francesco Lavra wrote: On 07/25/2013 04:36 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 21.07.2013 15:20, Francesco Lavra wrote: Since the last merge of mainline into the arm branch, building for arm fails because commands/boot.c is not compiled anymore. The boot mod

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-25 Thread Francesco Lavra
On 07/25/2013 04:36 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 21.07.2013 15:20, Francesco Lavra wrote: >> Since the last merge of mainline into the arm branch, building for arm >> fails because commands/boot.c is not compiled anymore. The boot module >> should be enabled for arm too. >>

Re: [PATCH] [ARM] Enable boot module for arm

2013-07-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 21.07.2013 15:20, Francesco Lavra wrote: Since the last merge of mainline into the arm branch, building for arm fails because commands/boot.c is not compiled anymore. The boot module should be enabled for arm too. Few lines down you have: enable = arm_efi; enable = arm_uboot; Didn't it

[PATCH] [ARM] Enable boot module for arm

2013-07-21 Thread Francesco Lavra
Since the last merge of mainline into the arm branch, building for arm fails because commands/boot.c is not compiled anymore. The boot module should be enabled for arm too. 2013-07-21 Francesco Lavra * grub-core/Makefile.core.def (boot): Enable on ARM. === modified file 'grub-core/Mak