Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-07 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Mon, 07 Dec 2009 12:52:01 +0100 > It already works on MIPS and AFAICT only thing it needs to work is PCI. > Do you mean that accessing PCI on sparc is a lot of work? Even just calculating the register addresses is a lot of work. You can't

Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
David Miller wrote: > From: Vladimir 'φ-coder/phcoder' Serbinenko > Date: Mon, 07 Dec 2009 12:05:24 +0100 > > >> Committed. >> David Miller wrote: >> >>> I tried to surmise other ways to do this more cleanly, such as >>> resolving the path and looking for some device property inside of the

Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-07 Thread David Miller
From: Vladimir '$B&U(B-coder/phcoder' Serbinenko Date: Mon, 07 Dec 2009 12:05:24 +0100 > Committed. > David Miller wrote: >> I tried to surmise other ways to do this more cleanly, such as >> resolving the path and looking for some device property inside of the >> resulting node, but there simpl

Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Committed. David Miller wrote: > I tried to surmise other ways to do this more cleanly, such as > resolving the path and looking for some device property inside of the > resulting node, but there simply isn't anything we can check for. > > If you find a cleaner way we can commit it later. I was

[PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

2009-12-06 Thread David Miller
We skip CDROMs in the block device iterator because they simply can't be openned safely unless we absolutely know there is a CDROM drive there and there is in fact a disc in the drive. Openning it blindly results in either a 10 second hang during the open call, or even worse a crash in OpenFirmwa