Re: [PATC] Unit testing framework adjusted over trunk

2010-01-14 Thread BVK Chaitanya
Hi, This has been committed to trunk with some minor changes. Its been reviewed by Vladimir (over IRC). thanks, -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATC] Unit testing framework adjusted over trunk

2010-01-12 Thread BVK Chaitanya
An updated patch is attached with some fixes mentioned below: 1. Added --boot=[fd|hd|cd] option support to grub-shell script. By default grub-shell script now starts Qemu with disk image, but with --boot=fd or --boot=cd options, Qemu will be booted with floppy or cdrom image respectively. This

Re: [PATC] Unit testing framework adjusted over trunk

2010-01-09 Thread BVK Chaitanya
Some minor comments: + +if ! diff -q ${outfile1} ${outfile2} >/dev/null +then + echo "$1: GRUB and BASH outputs (${outfile1}, ${outfile2}) did not match" + status=1 +else +rm -f ${outfile1} ${outfile2} +fi + 1. In the above echo statement, $1 doesn't resolve to the testcase file name, use

[PATC] Unit testing framework adjusted over trunk

2010-01-08 Thread BVK Chaitanya
Hi, Attached is the patch that adds unit-testing framework support to GRUB. Its been adjusted to work over trunk branch, and has few changes from what is available in my people/bvk/unit-testing-support branch. Since my all of my other works has one-or-two unit tests, this is a pre-requisite and