Re: [Design] nested partitions: Unify grub_partition and grub_disk

2009-04-14 Thread Yoshinori K. Okuji
On Monday 13 April 2009 23:00:37 Robert Millan wrote: > On Sat, Apr 11, 2009 at 11:58:05PM +0200, phcoder wrote: > > Ping. Is it ok for me to implement it this way? > > I'd really like it if Okuji could give his impression on this one, if > possible. I don't think I am the right one to ask, becaus

Re: [Design] nested partitions: Unify grub_partition and grub_disk

2009-04-13 Thread Robert Millan
On Sat, Apr 11, 2009 at 11:58:05PM +0200, phcoder wrote: > Ping. Is it ok for me to implement it this way? I'd really like it if Okuji could give his impression on this one, if possible. > phcoder wrote: >> I forgot to speak about another question: partition naming. I see 2 >> possibilities >>

Re: [Design] nested partitions: Unify grub_partition and grub_disk

2009-04-11 Thread phcoder
Ping. Is it ok for me to implement it this way? phcoder wrote: I forgot to speak about another question: partition naming. I see 2 possibilities 1) purely numeric unified naming scheme. It means that (hd0,1,a) becomes (hd0,1,1) On one hand mixed number-letter scheme is similar to what freebsd us

Re: [Design] nested partitions: Unify grub_partition and grub_disk

2009-03-07 Thread phcoder
Bean wrote: Hi, Hello. I was looking into nested partitions issue and propose to unify grub_partition and grub_disk. In this case when a code calls grub_disk_read with a >grub_disk_t which represents a partition it will correct the offset and call grub_disk_read with underlying partition or

Re: [Design] nested partitions: Unify grub_partition and grub_disk

2009-03-07 Thread Bean
Hi, >Hello. I was looking into nested partitions issue and propose to unify >grub_partition and grub_disk. In this case when a code calls grub_disk_read >with a >grub_disk_t which represents a partition it will correct the offset >and call grub_disk_read with underlying partition or disk. In th

Re: [Design] nested partitions: Unify grub_partition and grub_disk

2009-03-07 Thread phcoder
I forgot to speak about another question: partition naming. I see 2 possibilities 1) purely numeric unified naming scheme. It means that (hd0,1,a) becomes (hd0,1,1) On one hand mixed number-letter scheme is similar to what freebsd uses but on the other hand numerical scheme is versatile and allo

Re: [Design] nested partitions: Unify grub_partition and grub_disk

2009-03-07 Thread Robert Millan
On Sat, Mar 07, 2009 at 03:58:46PM +0100, phcoder wrote: > Hello. I was looking into nested partitions issue and propose to unify > grub_partition and grub_disk. In this case when a code calls > grub_disk_read with a grub_disk_t which represents a partition it will > correct the offset and ca

[Design] nested partitions: Unify grub_partition and grub_disk

2009-03-07 Thread phcoder
Hello. I was looking into nested partitions issue and propose to unify grub_partition and grub_disk. In this case when a code calls grub_disk_read with a grub_disk_t which represents a partition it will correct the offset and call grub_disk_read with underlying partition or disk. In this way no