RE: Weird theme issue when using an image object

2013-11-08 Thread Vladimir Testov
Fixed in the trunk. The problem was about intersecting elements and their redraw. Now we can use intersecting, overlaying etc elements, they will be correctly redrawn. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru

Re: Fwd: Re: Request for IRC chat about patches, which aren't accepted.

2013-07-25 Thread Vladimir Testov
rad.w...@oracle.com>> wrote: > > On Tue, Jul 23, 2013 at 07:57:43PM +0400, Vladimir Testov wrote: > > Hello! > > > > I would like to meet in IRC to go through some my patches which > > aren't > > > accepted yet. &

Re: Request for IRC chat about patches, which aren't accepted.

2013-07-25 Thread Vladimir Testov
On Tuesday, July 23, 2013 01:00:03 PM Konrad Rzeszutek Wilk wrote: > Which IRC server do you frequent? irc://irc.gnu.org/grub (as far as I know) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab

Request for IRC chat about patches, which aren't accepted.

2013-07-23 Thread Vladimir Testov
best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug

2013-07-22 Thread Vladimir Testov
op offsets for non-selected item and for selected item. So the meanings of the values are cleared and easy-to-get. I can do these changes in a separate patch if it's needed. Just the patch and the renaming are about the same concept so it should be applied together. -- With best re

Re: [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice

2013-07-22 Thread Vladimir Testov
On Saturday, July 20, 2013 06:18:04 PM Andrey Borzenkov wrote: > В Wed, 17 Jul 2013 21:55:58 +0400 > > Vladimir Testov пишет: > > See screenshots included. > > > > If the center slice is NULL then west or north slice is also NULL > > Why? As far as I can t

[PATCH] [9/11] grub-core/gfxmenu/gui_list.c - new options: scrollbar padding

2013-07-19 Thread Vladimir Testov
s set then real spacing between the list and the scrollbar will be item_padding + scrollbar_left_pad. That way the usual behaviour of item_padding is saved. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new8/grub-core/gfxmenu/gui_l

Re: [PATCH] [7/?] grub-core/gfxmenu/gui_list.c - scrollbar thumb offsets

2013-07-19 Thread Vladimir Testov
Sanity checks fixed. Rare case with too big scrollbar frame was incorrectly handled. On Thursday, July 18, 2013 07:57:14 PM Vladimir Testov wrote: > New options > scrollbar_thumb_top_offset > scrollbar_thumb_bottom_offset > > With these two options we can make scrollbar thumb w

Re: [PATCH] [8/11] grub-core/gfxmenu/gui_list.c - new option: scrollbar_slice

2013-07-19 Thread Vladimir Testov
Updated because [7/11] patch has been updated. On Friday, July 19, 2013 05:41:38 PM Vladimir Testov wrote: > scrollbar_slice = "east" \ "center" \ "west" > > Typically, the scrollbar is drawn in the east slice. > > Now we can decide where we would li

[PATCH] [7/?] grub-core/gfxmenu/gui_list.c - scrollbar thumb offsets

2013-07-18 Thread Vladimir Testov
frame. positive value means we move to the bottom negative value means we move to the top in the example given (see screenshots) scrollbar_thumb_top_offset = -5 scrollbar_thumb_bottom_offset = 5 Sanity checks are present. -- With best regards, ___ Vladimir Testov,

[PATCH] [6/?] grub-core/gfxmenu/gui_list.c - sanity checks for the scrollbar

2013-07-17 Thread Vladimir Testov
height of south slice). So the scrollbar thumb will be drawn incorrectly. In this case we set the height of the thumb to it's vertical padding and recount the position of the thumb. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur

[PATCH] [5/?] grub-core/gfxmenu/gui_list.c - print scrollbar in separate viewport

2013-07-17 Thread Vladimir Testov
fixed. Now we can use any kind of styled box for thumb and frame. scrollbar_width is total width of the scrollbar backward compatibility is contained -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new4/grub-core/gfxmenu

[PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice

2013-07-17 Thread Vladimir Testov
regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru<>diff -Naur grub-2.01/grub-core/gfxmenu/widget-box.c grub-box-draw/grub-core/gfxmenu/widget-box.c --- grub-2.01/grub-core/gfxmenu/widget-box.c 2013-02-25 16:54:27.0 +0400 +++ grub-box-draw/grub-core/g

Re: [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug

2013-07-16 Thread Vladimir Testov
2013-07-16 Vladimir Testov * grub-core/gfxmenu/gui_list.c: Baseline misalignment bugfix. On Monday, July 15, 2013 05:35:15 PM Vladimir Testov wrote: > See screenshots included. > > If the selected entry font is specified and the font has different size than > non-selected

Re: [PATCH] [3/?] grub-core/gfxmenu/gui_list.c - some code cleaning

2013-07-16 Thread Vladimir Testov
Like that? :) 2013-07-16 Vladimir Testov * grub-core/gfxmenu/gui_list.c: Code cleaning. Create colors only once. Define selected_item_font and selected_item_color so these values won't be recount multiple times on each redrawing. On Monday, July 15, 2013 05:35:

[PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug

2013-07-15 Thread Vladimir Testov
See screenshots included. If the selected entry font is specified and the font has different size than non-selected entry's font size (e.g. selected entry has larger font) then the baseline of the font will be misaligned. -- With best regards, ___ Vladimir T

Re: [PATCH] [3/?] grub-core/gfxmenu/gui_list.c - some code cleaning

2013-07-15 Thread Vladimir Testov
Yeah, the patch. On Monday, July 15, 2013 05:31:11 PM Vladimir Testov wrote: > First. The structure should be changed a little to apply the 4th patch and > some of the following patches. > Second. After applying the patch GRUB won't count some values during every > redrawing

[PATCH] [3/?] grub-core/gfxmenu/gui_list.c - some code cleaning

2013-07-15 Thread Vladimir Testov
gards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] [2/?] grub-core/gfxmenu/gui_list.c - menu entry's width bug

2013-07-11 Thread Vladimir Testov
, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru<><>diff -Naur grub-new/grub-core/gfxmenu/gui_list.c grub-new2/grub-core/gfxmenu/gui_list.c --- grub-new/grub-core/gfxmenu/gui_list.c 2013-07-09 15:27:35.337936761 +0400 +++ grub-new2/grub-core/gfxmenu/gui_list.c 2013-07-11 18:17:38.856

Re: [PATCH] [2/2] set terminal window in theme file

2013-06-27 Thread Vladimir Testov
Patch has been remade to meet the requirements. On Friday, April 26, 2013 05:06:17 PM Vladimir Testov wrote: > There can be cases when we would like to move terminal window. For example, > it follows our theme design. > > So, > > options: > terminal-top > termin

[PATCH] please fix the typo in the changelog

2013-06-26 Thread Vladimir Testov
On Monday, May 13, 2013 05:24:58 PM Vladimir Testov wrote: > 2013-04-29 Vladimir Testov > > * grub-core/gfxmenu/circular_progress.c: Set start_angle in degrees > with syntax "XXX deg"/"XXX °". > > should be gui_circular_progress.c (not ci

Re: Grub2 designer's guide.

2013-06-05 Thread Vladimir Testov
On Wednesday, June 05, 2013 03:29:25 PM Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 05.06.2013 12:24, Vladimir Testov wrote: > > Agree. I think it should be called "Grub2 designer's guide" > > > > Maybe I'll move the guide to

Re: Grub2 designer's guide.

2013-06-05 Thread Vladimir Testov
rg wrote: > >> On Jun 4, 2013, at 1:59 AM, Vladimir Testov wrote: > >>> I've completed the article I was working on. > >>> > >>> http://wiki.rosalab.ru/en/index.php/Grub2_theme_/_designer%27s_guide > >>> > >>> Please, take a

Re: Would it be possible to have a version of grub with all of Vladmir Testov's patches

2013-06-04 Thread Vladimir Testov
g/archive/html/grub-devel/2011-04/msg00083.html[1]. I realize these are all aesthetics, and everyone is focused on technical patches. -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.ru [1] http://lists.gnu.org/arc

Grub2 designer's guide.

2013-06-04 Thread Vladimir Testov
ivate messages please so the mailing list won't be spammed with conversations of this kind) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu

please fix typo in the changelog

2013-05-13 Thread Vladimir Testov
2013-04-29 Vladimir Testov * grub-core/gfxmenu/circular_progress.c: Set start_angle in degrees with syntax "XXX deg"/"XXX °". should be gui_circular_progress.c (not circular_progress.c) -- With best regards, ___ Vladimir Tes

Re: Would it be possible to have a version of grub with all of Vladmir Testov's patches

2013-05-13 Thread Vladimir Testov
d easily by users. Perhaps, there could even be a plugin of sorts that a user could just easily install. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@g

Re: 15 Patches, which aren't commented or accepted yet

2013-04-29 Thread Vladimir Testov
On Sunday, April 28, 2013 01:18:34 PM Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Could you come to IRC one of these daŷs so we can go through them quicker? O.K. Nickname: icedphoenix. -- With best regards, _______ Vladimir Testov, ROSA Laboratory. w

15 Patches, which aren't commented or accepted yet

2013-04-26 Thread Vladimir Testov
support: I can't make it work with existing line-breaking mechanism and need some help to understand why. Thanks to all! -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing

[PATCH] [2/2] set terminal window in theme file

2013-04-26 Thread Vladimir Testov
. Safe. (if some part of the terminal window is going to fall of the screen rectangle, parameters will be correspondingly auto- adjusted) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new4/docs/grub.texi grub-new5/docs

[RFC][PATCH] [1/2] remove outdated code

2013-04-26 Thread Vladimir Testov
Hi folks, There is some oudated and unused code. I suggest we should remove it. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new3/docs/grub.texi grub-new4/docs/grub.texi --- grub-new3/docs/grub.texi 2013-04-19 03:55

[RFC][PATCH] multistring support in gui_label

2013-04-23 Thread Vladimir Testov
Hi, folks! On Tuesday, April 23, 2013 03:58:24 PM Vladimir Testov wrote: > still has two problems I've mentioned before I can't get what I have missed. text = "@KEYMAP_LONG@" muiltiline = "true" the problem lays in the first quote near 'e'. (see scree

Re: [RFC][PATCH] documentation update

2013-04-23 Thread Vladimir Testov
know what exactly inline patch is. I have corrected errors. Please, take a look at the new version. :) -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.01/docs/grub.texi grub-new/docs/grub.texi --- grub-2.01/docs/grub.texi

Re: [PATCH] multistring support in gui_label

2013-04-23 Thread Vladimir Testov
Meanwhile, patch was rebuild for upstream version still has two problems I've mentioned before -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new2/grub-core/gfxmenu/font.c grub-new3/grub-core/gfxmenu/font.c --- grub

Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-04-23 Thread Vladimir Testov
Smth like that? (presumed "documentation update - draft" patch is applied) On Friday, April 19, 2013 06:16:36 PM Andrey Borzenkov wrote: > В Fri, 12 Apr 2013 11:27:21 +0400 > > Vladimir Testov пишет: > > >I think "XXX deg" is enough. It avoids confusio

[PATCH] documentation update - draft

2013-04-23 Thread Vladimir Testov
subj see attached file -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.01/docs/grub.texi grub-new/docs/grub.texi --- grub-2.01/docs/grub.texi 2013-03-28 23:28:47.0 +0400 +++ grub-new/docs/grub.texi 2013-04-19 03:45

Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir Testov
On Wednesday, April 17, 2013 01:02:44 PM Vladimir Testov wrote: > O.k. Here it is. > > from grub-core/font/font.c line 1387 function blit_comb : > >do_blit (combining_glyphs[i], > > > >

Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir Testov
On Wednesday, April 17, 2013 01:02:44 PM Vladimir Testov wrote: > Suggested patch to fix this problem (second one) is attached. Nope, it won't help. I'll think again... -- With best regards, _______ Vladimir Testov, ROSA Laboratory. w

Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir Testov
unicode_glyph is to call grub_font_get_constructed_device_width. But it is miscalculated in some cases. So these two values are different in some cases (This is all about problem 2) Suggested patch to fix this problem (second one) is attached. I will remake the patch for multistring suppo

Re: [PATCH] multistring support in gui_label

2013-04-16 Thread Vladimir Testov
fixed. :) Thank for the reply. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] multistring support in gui_label

2013-04-16 Thread Vladimir Testov
eryLongWordSoItCannotBePrintedEntirelyOnOneLine" See how the line-breaking works. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru<><>diff -Naur grub-2.00/grub-core/gfxmenu/font.c grub-new/grub-core/gfxmenu/font.c --- grub-2.00/grub-core/gfxmenu/font

Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-04-12 Thread Vladimir Testov
Ok. Please tell me where and how should I do it. :) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-04-11 Thread Vladimir Testov
Oh, I think that version of patch is safer. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_circular_progress.c grub-new/grub-core/gfxmenu/gui_circular_progress.c --- grub-2.00/grub-core/gfxmenu

Re: [3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-04-11 Thread Vladimir Testov
s", like it was before -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_circular_progress.c grub-new/grub-core/gfxmenu/gui_circular_progress.c --- grub-2.00/grub-core/gfxmenu/gui_circular_progress.c 201

Re: [3/4] [PATCH] start angle (option of circular_progress)

2013-04-11 Thread Vladimir Testov
iour (in parrots) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_circular_progress.c grub-new/grub-core/gfxmenu/gui_circular_progress.c --- grub-2.00/grub-core/gfxmenu/gui_circular_progress.c 2010-12-01 17:45:43.00

[PATCH] [11/11] [gfxmenu/list] some more code cleaning

2013-04-11 Thread Vladimir Testov
subj -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-newA/grub-core/gfxmenu/gui_list.c grub-newB/grub-core/gfxmenu/gui_list.c --- grub-newA/grub-core/gfxmenu/gui_list.c 2013-04-10 12:51:47.579232188 +0400 +++ grub-newB/grub

[PATCH] [10/11] [gfxmenu/list] item_pixmap_style

2013-04-11 Thread Vladimir Testov
remake of one of my previous patches Now it is much better. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new9/grub-core/gfxmenu/gui_list.c grub-newA/grub-core/gfxmenu/gui_list.c --- grub-new9/grub-core/gfxmenu/gui_list.c

[PATCH] [9/11] [gfxmenu/list] minmax functions (taken from GRUB2 source code)

2013-04-11 Thread Vladimir Testov
functions currently included in grub2 source code. (grub_min, grub_max) patch only for compatibility so someone could make grub2 binaries from grub-2.00.tar.gz -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/include

[PATCH] [8/11] [gfxmenu/list] scrollbar_thumb_offset

2013-04-11 Thread Vladimir Testov
I've found that I miss this options if I want to do something like scrollvar thumb, rounded on the edges. (see screenshots) tmp1 - the bottom position - before tmp2 - the bottom position - after (with offsets) -- With best regards, ___ Vladimir Testov,

[PATCH] [7/11] [gfxmenu/list] scrollbar padding

2013-04-11 Thread Vladimir Testov
New options to manage scrollbar's padding. Ask if it should be commented and supported with screenshots. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new7/grub-core/gfxmenu/gui_list.c grub-new8/grub-core/gfxmenu/gui_l

[PATCH] [6/11] [gfxmenu/list] print scrollbar in the center slice

2013-04-11 Thread Vladimir Testov
efore. I don't think this patch should go with included screenshots. But I can easily make and sent them if it will be necessary. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new6/grub-core/gfxmenu/gui_list.c grub-new7

[PATCH] [3/11] [gfxmenu/list] some code cleaning

2013-04-11 Thread Vladimir Testov
reduce number of calculations, make the code more clear -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new3/grub-core/gfxmenu/gui_list.c grub-new4/grub-core/gfxmenu/gui_list.c --- grub-new3/grub-core/gfxmenu/gui_list.c 2013

Re: [PATCH] [1/11] [gfxmenu/list] fixed height detemination

2013-04-11 Thread Vladimir Testov
tem_pixmap_style - because: > 1) height of the center slice is item_height - 1 > 2) selected_bottom_pad hasn't been taken into account > -- > With best regards, > ___ > Vladimir Testov, ROSA Laboratory. > www.rosa

[PATCH] [0/11] [gfxmenu/list] - "version" parameter

2013-04-11 Thread Vladimir Testov
n) or it could be 201 version, 202 version etc. -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-new/grub-core/gfxmenu/gui_list.c --- grub-2.00/grub-core/gfxmenu/gui_list.c 2011-12-14 14:36:0

Re: [PATCH] fix menu size calculation in presence of selected item pixmap

2013-04-09 Thread Vladimir Testov
selected item is: sel_top_pad + sel_bottom_pad + item_height - 1 So the number of shown items is miscalculated. And in some cases we will have the bottom item not fully drawn. I can sent a screenshot. -- With best regards, ___ Vladimir Testov,

[PATCH][BUGFIX] wrong determination of first printed entry in some cases

2013-03-27 Thread Vladimir Testov
the default entry isn't shown. Nevertheless, they appear as soon as we press "up" key. screeshots attached after the patch the described problem is fixed -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru<><><&

RE: [PATCH] multistring support in gui_label

2013-03-22 Thread Vladimir Testov
muiltistring changed to multiline (now we have multiline) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_label.c grub-new/grub-core/gfxmenu/gui_label.c --- grub-2.00/grub-core/gfxmenu/gui_label.c

[PATCH] multistring support in gui_label

2013-03-21 Thread Vladimir Testov
t = 600 width = 1 color = "cyan" align = "right" text = "@KEYMAP_LONG@" multistring = "true" } -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core

[PATCH] seems to be missed grub_free (new one)

2013-03-21 Thread Vladimir Testov
This time grub is building with this patch and I've rechecked twice. In the nearby function grub_free is present in similar case. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/font.c grub-new2

Re: [4/4] [PATCH] incorrect calculation of radius in circular_progress.

2013-03-20 Thread Vladimir Testov
fixed. variables changed to outer_diameter and inner_diameter It is more human-readable also -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gfxmenu

Re: [3/4] [PATCH] start angle (option of circular_progress)

2013-03-20 Thread Vladimir Testov
new option: start_angle_degrees maybe like that? :) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gfxmenu/gui_circular_progress.c --- grub-2.00/grub-core

[3/4] [PATCH] start angle (option of circular_progress) is measured in unusual quantities

2013-03-13 Thread Vladimir Testov
rt_angle = -64 after: start_angle = -90 nothing else is affected -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new2/grub-core/gfxmenu/gui_circular_progress.c grub-new3/grub-core/gfxmenu/gui_circular_progress.c --- grub-ne

[2/4] [PATCH] first state of the timeouts is non-zero.

2013-03-13 Thread Vladimir Testov
I think progress bar, starting for zero looks more usual and more adequate. See screenshots. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new/grub-core/gfxmenu/view.c grub-new2/grub-core/gfxmenu/view.c --- grub-new/grub

[1/4] [PATCH] circular progress bar: one tick is always missed

2013-03-13 Thread Vladimir Testov
Number of printed ticks is always decreased by 1. (see screenshots) num_ticks = 8 Before - current state. After - after applying the patch. Appear - ticks are appearing. Disappear - ticks are disappearing. -- With best regards, ___ Vladimir Testov, ROSA Laboratory

Re: [PATCH] missed grub_free in icon_manager

2013-03-07 Thread Vladimir Testov
>And actually it is. Did you disable warnings and/or -Werror? As this >shouldn't even compile. Sorry for wasting your time... -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru___ Grub-de

[PATCH] missed grub_free in icon_manager

2013-03-07 Thread Vladimir Testov
Missed grub_free in gfxmenu/icon_manager.c If I'm not mistaken, it should be there. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/icon_manager.c grub-new/grub-core/gfxmenu/icon_manager.c --- grub

Re: [PATCH] fixed progress_bar highlight_style box displaying

2013-03-06 Thread Vladimir Testov
, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru<><><><>___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] gfxterm: check elements' properties and hadle errors.

2013-03-06 Thread Vladimir Testov
ject is closed. -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.ru___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] gfxterm: check elements' properties and hadle errors.

2013-03-06 Thread Vladimir Testov
lem with a value (e.g. we tried to set integer value to a option, which accepts string value.) If you concerns are about right that - I can slightly remake the patch to show more detailed information about the error. Cheers. -- With best regards, ___ Vladimir Test

Re: [PATCH] fixed progress_bar highlight_style box displaying

2013-03-06 Thread Vladimir Testov
c. Should I sent some screenshots, describing what exactly has been changed and why? -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.ru___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] gfxterm: check elements' properties and hadle errors.

2013-03-06 Thread Vladimir Testov
g parsed? Please, try to be more concrete. :) -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.ru___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] fixed progress_bar highlight_style box displaying

2013-03-06 Thread Vladimir Testov
In current state we could not correctly use styled box for highlight_style. We could set only center slice for highlight_style. Otherwise highlighted area won't be correctly displayed. Patch included. -- With best regards, ___ Vladimir Testov, ROSA Labor

[PATCH] gfxterm: check elements' properties and hadle errors.

2013-03-04 Thread Vladimir Testov
GRUB does not show errors about non-existing properties or wrong values. property name and error hadling works only for global properties This patch fixes this misbehavior. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00

I would like to contact with theming authors or to get commit rights and became responsible for grub2 theming.

2013-02-25 Thread Vladimir Testov
ideas to share. I wish to participate in developing. (maybe not only theming) :) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.

message-font, message-color, message-bgcolor can be set in theme but never used

2013-02-22 Thread Vladimir Testov
code that uses parameters mentioned. ... #endif Should the parameters be removed or some code will happen to be written? -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list

Re: fixed item-height, item-spacing, max-elements-shown etc

2013-02-22 Thread Vladimir Testov
ght now. With details and schemes. :) It will take some time to finish. -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] fix selected item's height

2013-02-22 Thread Vladimir Testov
's height. The formula you have presented do not consider the fact that selected item's height is decreased by 1. Patch included. -- With best regards, _______ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c

Once again, about unset parameter in circular progress bar.

2013-02-21 Thread Vladimir Testov
I'm just wish to help. Waiting for feedback. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: ticks_disappear option in circular_progress has no default value

2013-02-08 Thread Vladimir Testov
should be used. (In current situations there is no default value and I see some kind of instability if none "ticks_disappear" was mentioned in a theme.) Thanks. ) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new/g

ticks_disappear option in circular_progress has no default value

2013-02-06 Thread Vladimir Testov
ticks_disappear option in circular_progress has no default value And it's no good. fix included -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-new/grub-core/gfxmenu/gui_circular_progress.c grub-new2/grub-core/gf

Re: fixed item-height, item-spacing, max-elements-shown etc

2013-02-06 Thread Vladimir Testov
Oh. One more white-space removed. That's better. -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-new/grub-core/gfxmenu/gui_list.c --- grub-2.00/grub-core/gfxmenu/gui_list.c 2011-12-

Re: fixed item-height, item-spacing, max-elements-shown etc

2013-02-06 Thread Vladimir Testov
Here it is. :) (fixed) -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-new/grub-core/gfxmenu/gui_list.c --- grub-2.00/grub-core/gfxmenu/gui_list.c 2011-12-14 14:36:07.0 +0400

Re: fixed item-height, item-spacing, max-elements-shown etc

2013-02-05 Thread Vladimir Testov
Sorry, misprint. Should be "horizontal_pad" rather than "vertical_pad" in the patch included. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

fixed item-height, item-spacing, max-elements-shown etc

2013-02-05 Thread Vladimir Testov
I'm going to write some patches for GRUB2 - mainly for theme handling. First one - I've faced some bug: maximum number of displayed boot elements is counted in presumption that element's height is item_height and distance between elements is item_spacing. Nevertheless, this conceptions does not

Bug found and fixed. Patch is attached to the letter.

2012-12-04 Thread Vladimir Testov
fixes the problem. Now `grub-mkconfig -s 10 -c 9 -d 2 -a -o ... ...` makes the font I need. Hope it will be useful. And hope it will be added to upstream (as well as my previous patch). -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur

Re: How can I contribute the patch to the upstream?

2012-11-29 Thread Vladimir Testov
You're welcome to add this patch to the upstream. =(^_^)= -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.rudiff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-new/grub-core/gfxmenu/gui_list.c --- grub-2.00/grub-core/gfxmenu/gui_list.c

UPD. link for the picture from the previous post (How can I contribute to the upstream?)

2012-11-29 Thread Vladimir Testov
http://s019.radikal.ru/i609/1211/60/16cd55a5b492.png -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

How can I contribute the patch to the upstream?

2012-11-29 Thread Vladimir Testov
best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru<>___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel