[PATCH] loader/multiboot: do not add modules before successful download

2024-10-30 Thread Valentin Gehrke
, it is futile to retry a failed download as the corrupted module will be forwarded either way. Signed-off-by: Valentin Gehrke Reviewed-by: Daniel Kiper --- grub-core/loader/multiboot.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/grub-core/loader/multiboot.c b

[PATCH] loader/multiboot: do not add modules before successful download

2024-10-30 Thread Valentin Gehrke
Multiboot modules that could not be read successfully (e.g. via network) should not be added to the list of modules to forward to the operating system that is to be booted subsequently. This patch is necessary because even if a grub.cfg checks whether or not a module was successfully downloaded, i

Re: [PATCH] loader/multiboot: do not add modules before successful download

2024-10-25 Thread Valentin Gehrke
Hey Daniel, did you have time yet to give the patch in my last email a try? I just want to make sure the email didn't get overlooked. Best regards, Valentin. On Tue, 10 Sep 2024 16:10:47 +0200 Valentin Gehrke wrote: > > Sorry, this patch does not apply to the upstream. >

Re: [PATCH] loader/multiboot: do not add modules before successful download

2024-09-10 Thread Valentin Gehrke
> Sorry, this patch does not apply to the upstream. > > Daniel Oops. My bad. There was some unfortunate line wrapping in the diff in the @@ lines caused by my email client. This time it should work. I rebased the commit onto current master, just to be sure. From: Valentin Gehrke Date

[PATCH] loader/multiboot: do not add modules before successful download

2024-08-23 Thread Valentin Gehrke
, an attempt to retry a failed download is futile because the corrupted module will be forwarded either way. Signed-off-by: Valentin Gehrke --- grub-core/loader/multiboot.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/grub-core/loader/multiboot.c b/grub-core/loader