Re: [PATCH v2 2/2] cmdline: fix command line parsing in grub

2025-07-31 Thread Shreenidhi Shedi
On 17/06/25 16:31, Shreenidhi Shedi wrote: On 11/06/25 01:34, Shreenidhi Shedi wrote: On 23/05/25 22:22, Shreenidhi Shedi wrote: On 20/05/25 19:15, Daniel Kiper wrote: On Mon, May 19, 2025 at 11:49:55PM +0530, Shreenidhi Shedi wrote: From: Shreenidhi Shedi Previously, the command line

Re: [PATCH v2 2/2] cmdline: fix command line parsing in grub

2025-06-17 Thread Shreenidhi Shedi
On 11/06/25 01:34, Shreenidhi Shedi wrote: On 23/05/25 22:22, Shreenidhi Shedi wrote: On 20/05/25 19:15, Daniel Kiper wrote: On Mon, May 19, 2025 at 11:49:55PM +0530, Shreenidhi Shedi wrote: From: Shreenidhi Shedi Previously, the command line construction function

Re: [PATCH v2 2/2] cmdline: fix command line parsing in grub

2025-06-10 Thread Shreenidhi Shedi
On 23/05/25 22:22, Shreenidhi Shedi wrote: On 20/05/25 19:15, Daniel Kiper wrote: On Mon, May 19, 2025 at 11:49:55PM +0530, Shreenidhi Shedi wrote: From: Shreenidhi Shedi Previously, the command line construction function (grub_create_loader_cmdline) escaped single and double quotes, which

Re: [PATCH v2 2/2] cmdline: fix command line parsing in grub

2025-05-23 Thread Shreenidhi Shedi
On 20/05/25 19:15, Daniel Kiper wrote: On Mon, May 19, 2025 at 11:49:55PM +0530, Shreenidhi Shedi wrote: From: Shreenidhi Shedi Previously, the command line construction function (grub_create_loader_cmdline) escaped single and double quotes, which is unnecessary and potentially problematic

[PATCH v2 2/2] cmdline: fix command line parsing in grub

2025-05-19 Thread Shreenidhi Shedi
From: Shreenidhi Shedi Previously, the command line construction function (grub_create_loader_cmdline) escaped single and double quotes, which is unnecessary and potentially problematic since the kernel command line handler does not support escaped quotes. This patch removes the escaping of

[PATCH v2 0/2] Fix cfg file parsing and command line parsing

2025-05-19 Thread Shreenidhi Shedi
leter - Improved commit message as suggested by Daniel Kiper v2 changes: - Handle '\r' along with '\n' in envblk -- Shreenidhi Shedi -- 2.49.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v2 1/2] envblk: ignore empty new lines while parsing env files

2025-05-19 Thread Shreenidhi Shedi
From: Shreenidhi Shedi Environment files may contain empty lines, which should be ignored during parsing. Currently, these lines are not skipped and resulting in incorrect behavior. This patch adds a check to skip empty lines along with those starting with `#'. Signed-off-by: Shreenidhi

Re: [PATCH v1 1/2] envblk: ignore empty new lines while parsing env files

2025-05-19 Thread Shreenidhi Shedi
On 19/05/25 22:43, Daniel Kiper wrote: On Sun, May 18, 2025 at 01:21:20PM +0530, Shreenidhi Shedi wrote: From: Shreenidhi Shedi Environment files may contain empty lines, which should be ignored during parsing. Currently, these lines are not skipped and resulting in incorrect behavior. This

[PATCH v1 0/2] Fix cfg file parsing and command line parsing

2025-05-18 Thread Shreenidhi Shedi
leter - Improved commit message as suggested by Daniel Kiper -- Shreenidhi Shedi -- 2.49.0 ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v1 2/2] cmdline: fix command line parsing in grub

2025-05-18 Thread Shreenidhi Shedi
From: Shreenidhi Shedi Previously, the command line construction function (grub_create_loader_cmdline) escaped single and double quotes, which is unnecessary and potentially problematic since the kernel command line handler does not support escaped quotes. This patch removes the escaping of

[PATCH v1 1/2] envblk: ignore empty new lines while parsing env files

2025-05-18 Thread Shreenidhi Shedi
From: Shreenidhi Shedi Environment files may contain empty lines, which should be ignored during parsing. Currently, these lines are not skipped and resulting in incorrect behavior. This patch adds a check to skip empty lines along with those starting with `#'. Signed-off-by: Shreenidhi

[PATCH 1/2] envblk: ignore empty new lines while parsing env files

2025-05-15 Thread Shreenidhi Shedi
From: Shreenidhi Shedi Signed-off-by: Shreenidhi Shedi --- grub-core/lib/envblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/lib/envblk.c b/grub-core/lib/envblk.c index 2e4e78b13..f08dabaad 100644 --- a/grub-core/lib/envblk.c +++ b/grub-core/lib/envblk.c

[PATCH 2/2] cmdline: fix command line parsing in grub

2025-05-15 Thread Shreenidhi Shedi
From: Shreenidhi Shedi - Stop escaping single and double quotes - Kernel command line handler doesn't support escape quotes Signed-off-by: Shreenidhi Shedi --- grub-core/lib/cmdline.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/grub-cor