Please see inline, thanks for reviewing.
Le 6/10/25 à 7:36 PM, sudhakar a écrit :
On 2025-06-10 15:24, Renaud Métrich via Grub-devel wrote:
When network booting is used, trying to chainload to the local disk
(which is used in deployment tools such as Red Hat Satellite) may fail
when searching
x" ]; then
chainloader ($prefix)/EFI/redhat/shimx64.efi
...
8< 8< 8< ----
The code is easily extensible to handle other arguments in the future if
needed.
Signed-off-by: Renaud Métrich
---
docs/grub.texi
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
index 7b8316d41..a70f243d0 100644
--- a/grub-core/commands/efi/lsefi.c
+++ b/grub-core
Hi Daniel,
Sorry I missed your email, please see inline.
Le 3/21/25 à 3:51 PM, Daniel Kiper a écrit :
On Wed, Mar 19, 2025 at 01:47:57PM +0100, Renaud Métrich via Grub-devel wrote:
When network booting is used, trying to chainload to the local disk
(which is used in deployment tools such as
erstand or am wrong.
Thank you!
Andrew
On Wed, Mar 19, 2025 at 7:53 AM Renaud Métrich via Grub-devel
wrote:
When network booting is used, trying to chainload to the local disk
(which is used in deployment tools such as Red Hat Satellite) may fail
when searching for the boot loader, e.g. /EFI/
https://issues.redhat.com/browse/RHEL-44336
Signed-off-by: Renaud Métrich
---
grub-core/osdep/linux/getroot.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/grub-core/osdep/linux/getroot.c b/grub-core/osdep/linux/getroot.c
index 7dd775d2a..0c6c12945 100644
Yes exactly, there are BIOS or UEFI implementations that support DDF
containers natively.
I've sent the new version of the patch right now.
Le 4/14/25 à 11:47 AM, Vladimir 'phcoder' Serbinenko a écrit :
Le ven. 21 juin 2024, 11:21, Renaud Métrich a
écrit :
DDF an
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
index 7b8316d41..bda25a3a9 100644
--- a/grub-core/commands/efi/lsefi.c
+++ b/grub-core/commands/efi/lsefi.c
x" ]; then
chainloader ($prefix)/EFI/redhat/shimx64.efi
...
8< 8< 8< ----
The code is easily extensible to handle other arguments in the future if
needed.
Signed-off-by: Renaud Métrich
---
NEWS
Serbinenko a écrit :
The need to connect looks like an internal implementation detail. Can
we treat it as such and connect when needed automatically rather than
having an extra configuration knob?
On Fri, Jun 28, 2024 at 2:14 PM Renaud Métrich wrote:
When efi.quickboot is enabled on VMWare (whi
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
index 7b8316d41..bda25a3a9 100644
--- a/grub-core/commands/efi/lsefi.c
+++ b/grub-core/commands/efi/lsefi.c
uot;$prefix" ]; then
chainloader ($prefix)/EFI/redhat/grubx64/efi
...
8< 8< ---- 8< ----
The code is easily extensible to handle other arguments in the future if
needed.
Signed-off-by: Renaud Métrich
---
NEWS
DDF and IMSM are very similar in handling, especially these should not
be considered as RAID abstraction.
This fixes the requirement of having a device map when probing DDF
containers.
Fixes https://issues.redhat.com/browse/RHEL-44336
Signed-off-by: Renaud Métrich
---
grub-core/osdep/linux
- 8<
The root cause is the code exiting prematurely when the data->addresses
buffer has been allocated in recv_hook(), even if there was no address
returned last time recv_hook() executed.
Signed-off-by: Renaud Métrich
---
grub-core/net/dns.c | 22 ++
Signed-off-by: Renaud Métrich
---
grub-core/net/dns.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/grub-core/net/dns.c b/grub-core/net/dns.c
index f28d1099f..6993a4aba 100644
--- a/grub-core/net/dns.c
+++ b/grub-core/net/dns.c
@@ -355,6 +355,7 @@ recv_hook (grub_net_udp_socket_t sock
Signed-off-by: Renaud Métrich
---
grub-core/net/dns.c | 48 ++---
1 file changed, 15 insertions(+), 33 deletions(-)
diff --git a/grub-core/net/dns.c b/grub-core/net/dns.c
index afa389494..f28d1099f 100644
--- a/grub-core/net/dns.c
+++ b/grub-core/net
- 8<
The root cause is the code exiting prematurely when the data->addresses
buffer has been allocated in recv_hook(), even if there was no address
returned last time recv_hook() executed.
This patch additionally simplifies the error handling
t; 8< 8<
This happens because the implementation is broken, it does a "add" internally.
Signed-off-by: Renaud Métrich
---
grub-core/net/dns.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/grub-core/net/dns.c b/grub-core
t' command"
Renaud.
Le 8/28/22 à 21:51, Glenn Washburn a écrit :
On Tue, 15 Feb 2022 14:05:20 +0100
Renaud Métrich wrote:
This set of patches fixes a memory leak in 'lsefi' command and
introduces a new 'connectefi pciroot|scsi' command which recursively
connects
uot;$prefix" ]; then
chainloader ($prefix)/EFI/redhat/grubx64/efi
...
8< 8< ---- 8< ----
The code is easily extensible to handle other arguments in the future if
needed.
Signed-off-by: Renaud Métrich
---
NEWS
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
index f46ba3b49..241be79f9 100644
--- a/grub-core/commands/efi/lsefi.c
+++ b/grub-core/commands/efi/lsefi.c
s root envvar
to 'md/boot_efi' which cannot be used for chainloading since there is no
effective EFI device behind.
Signed-off-by: Renaud Métrich
---
docs/grub.texi | 5 -
grub-core/commands/search.c | 19 +++
grub-core/commands/search_wrap.c |
When using 'search' on EFI systems, we sometimes want to exclude devices
that are not EFI disks (e.g. md, lvm).
This is typically used when wanting to chainload when having a software
raid (md) for EFI partition:
with no option, 'search --file /EFI/redhat/shimx64.efi' sets root envvar
to 'md/boot_e
When using --no-floppy and a floppy was encountered, iterate_device()
was returning 1, causing the iteration to stop instead of continuing.
Signed-off-by: Renaud Métrich
---
grub-core/commands/search.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/commands
Signed-off-by: Renaud Métrich
---
grub-core/commands/search.c | 8
grub-core/commands/search_wrap.c | 13 +++--
include/grub/search.h| 14 +++---
3 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/grub-core/commands/search.c b/grub-core
.
Signed-off-by: Peter Jones
Le 2/24/22 à 20:39, Daniel Kiper a écrit :
On Tue, Feb 15, 2022 at 02:05:21PM +0100, Renaud Métrich wrote:
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/commands/efi/lsefi.c b/grub
s root envvar
to 'md/boot_efi' which cannot be used for chainloading since there is no
effective EFI device behind.
Signed-off-by: Renaud Métrich
---
docs/grub.texi | 5 -
grub-core/commands/search.c | 19 +++
grub-core/commands/search_wrap.c |
When using --no-floppy and a floppy was encountered, iterate_device()
was returning 1, causing the iteration to stop instead of continuing.
Signed-off-by: Renaud Métrich
---
grub-core/commands/search.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/commands
Signed-off-by: Renaud Métrich
---
grub-core/commands/search.c | 8
grub-core/commands/search_wrap.c | 13 +++--
include/grub/search.h| 14 +++---
3 files changed, 22 insertions(+), 13 deletions(-)
diff --git a/grub-core/commands/search.c b/grub-core
When using 'search' on EFI systems, we sometimes want to exclude devices
that are not EFI disks (e.g. md, lvm).
This is typically used when wanting to chainload when having a software
raid (md) for EFI partition:
with no option, 'search --file /EFI/redhat/shimx64.efi' sets root envvar
to 'md/boot_e
Please ignore, deprecated by "efi: new 'connectefi' command" (v3).
Sorry for the mess.
Le 2/14/22 à 14:25, Renaud Métrich a écrit :
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/command
Please ignore, deprecated by "efi: new 'connectefi' command" (v3).
Sorry for the mess.
Le 2/14/22 à 14:23, Renaud Métrich a écrit :
When efi.quickboot is enabled on VMWare (which is the default for
hardware release 16 and later), it may happen that not all EFI devices
a
lt; 8< 8<
connectefi scsi
unset prefix
search --file --set=prefix /EFI/redhat/grubx64.efi
if [ -n "$prefix" ]; then
chainloader ($prefix)/EFI/redhat/grubx64/efi
...
8< 8< 8< ----
The c
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
index d1ce99af4..b1f2d4695 100644
--- a/grub-core/commands/efi/lsefi.c
+++ b/grub-core/commands/efi/lsefi.c
This set of patches fixes a memory leak in 'lsefi' command and
introduces a new 'connectefi pciroot|scsi' command which recursively
connects the corresponding EFI handles.
This is required on VMWare with efi.quickBoot enabled when chainloading
to grub on the harddisk from a network boot, otherwise
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
index 7acba3b39..f0b9201f1 100644
--- a/grub-core/commands/efi/lsefi.c
+++ b/grub-core/commands/efi/lsefi.c
In the future, if really needed, the code may be enhanced to avoid the
recursion and only connect PCI devices block devices.
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 52 ++
grub-core/disk/efi/efidisk.c | 13 +
grub-core/kern/ef
From: Fedora Ninjas
Signed-off-by: Renaud Métrich
---
grub-core/commands/efi/lsefi.c | 4
1 file changed, 4 insertions(+)
diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
index 7acba3b39..f0b9201f1 100644
--- a/grub-core/commands/efi/lsefi.c
+++ b/grub-core
Le 2/10/22 à 15:53, Ard Biesheuvel a écrit :
Hello all,
Please don't top post. I am not going to rearrange the text below and
just reply to each chunk if it seems relevant.
On Thu, 10 Feb 2022 at 14:02, Alexander Graf wrote:
On 09.02.22 18:20, Renaud Métrich wrote:
Hi,
I observ
, Renaud Métrich wrote:
When efi.quickboot is enabled on VMWare (which is the default for
hardware release 16 and later), it may happen that not all EFI devices
are connected. Due to this, browsing the devices in make_devices() just
fails to find devices, in particular partitions for a given disk.
This
result, which is 0 (EFI_SUCCESS)
or 14 (EFI_NOT_FOUND) when the handle is not a controller.
Signed-off-by: Renaud Métrich
---
grub-core/disk/efi/efidisk.c | 10 ++
grub-core/kern/efi/efi.c | 13 +
include/grub/efi/efi.h | 5 +
3 files changed, 28 insertions
Please ignore, resent properly using a git send-email command.
Le 2/1/22 à 11:38, Renaud Métrich a écrit :
When efi.quickboot is enabled on VMWare (which is the default for
hardware release 16 and later), it may happen that not all EFI devices
are connected.
Due to this, browsing the
So Glenn, I'm new to Grub developer, in the past I was relying on Javier
Martinez Canillas ...
Just sent v3.
Le 2/7/22 à 22:32, Glenn Washburn a écrit :
On Mon, 7 Feb 2022 12:12:14 +0100
Renaud Métrich wrote:
Please find inline the new patch integrating Glenn's comments (new
&quo
s root envvar
to 'md/boot_efi' which cannot be used for chainloading since there is no
effective EFI device behind.
This commit also refactors handling of --no-floppy option.
Signed-off-by: Renaud Métrich
---
grub-core/commands/search.c | 27 +++
grub-co
When using --no-floppy and a floppy was encountered, iterate_device()
was returning 1, causing the iteration to stop instead of continuing.
Signed-off-by: Renaud Métrich
---
grub-core/commands/search.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/commands
typically used when wanting to chainload when having a software
raid (md) for EFI partition:
with no option, 'search --file /EFI/redhat/shimx64.efi' sets root envvar
to 'md/boot_efi' which cannot be used for chainloading since there is no
effective EFI device behind.
Signed-off-by:
See inline, sorry for the format.
Le 2/4/22 à 23:28, Glenn Washburn a écrit :
On Tue, 1 Feb 2022 11:36:01 +0100
Renaud Métrich wrote:
When using 'search' on EFI systems, we sometimes want to exclude devices
that are not EFI disks (e.g. md, lvm).
This is typically used when
boot_efi' which cannot be used for chainloading since there is no
effective EFI device behind.
Signed-off-by: Renaud Métrich
diff --git a/grub-core/commands/search.c b/grub-core/commands/search.c
index ed090b3af..5e1e88643 100644
--- a/grub-core/commands/search.c
+++ b/grub-core/commands/sea
(EFI_NOT_FOUND) when the handle is not a controller.
Signed-off-by: Renaud Métrich
diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c
index f077b5f55..0b16c3868 100644
--- a/grub-core/disk/efi/efidisk.c
+++ b/grub-core/disk/efi/efidisk.c
@@ -387,6 +387,16 @@ static void
e
these above, the fallback mechanism is not used at all, set is
detected correctly.
However the mechanism is necessary for HP DL380p Gen 8 systems.
Renaud.
On 1/8/21 3:00 PM, Renaud Métrich wrote:
Hello,
It appears that the proposal works fine on all systems I could test
except one: a HP DL380p
_keyboard_fallback_set" environment variable in
grub.cfg that would end using a specific set if query_mode() fails.
See proposed patch in attachment.
Renaud.
On 12/14/20 5:47 PM, Renaud Métrich wrote:
Hi Vladimir,
Thanks for the hint, this was obvious now.
Please find attached the new pat
, Vladimir 'phcoder' Serbinenko wrote:
On Fri, Dec 4, 2020 at 5:53 AM Renaud Métrich wrote:
Hi,
Testing the proposed patch on my old Asus N53SN in Legacy failed: as soon as
at_keyboard is selected, the keys are corrupted and it's impossible to do
anything.
Digging into this,
uot;):
commit 5e8d6963c50cd727bfb5614448f9c80743a59de1 (HEAD -> master)
Author: Renaud Métrich
Date: Thu Dec 3 09:43:21 2020 +0100
Force using set_scancodes() code querying the driver.
This solves issues when query_mode() returns 2 but the driver continues
to send keycodes suitable for set 1 (se
Hi there,
A french Red Hat customer reported that in Legacy mode (the code isn't
used with UEFI), immediately after switching |terminal_input| to
|at_keyboard|, the keyboard was just not usable due to invalid key mappings.
This happens on various laptop models from various manufacturers with
F
54 matches
Mail list logo
