Re: [PATCH] grub2: add support to search for partuuid

2019-05-28 Thread Nick Vinson
On 5/27/19 1:07 AM, Michael Grzeschik wrote: > With this feature the grub-shell is able to search for partuuid strings. > This reduces the complexity to find the correct boot partition on > systems with unspecified device connectivity. > > Signed-off-by: Michael Grzeschik > --- > grub-core/Mak

Re: [PATCH v2] Optimization calculation expression of FOR_MODULES(var)

2019-04-11 Thread Nick Vinson
You cannot remove sizeof(A) from the expression, as doing so may cause the updated expression to compute a different answer. Consider ((H*)var)->size = 64, B = 32, and A = 64. In the original form, you have the expression (64 + 64 - 1) / 64 * 64 / 32 which equals 2. In your proposal, you have the

Re: [PATCH] Add knobs to allow non-initrd boot config

2019-02-15 Thread Nick Vinson
Paul, Let me start of by saying that I am a contributor and do not have any authority to approve or deny patches to GRUB. That said I do have a few comments below that I would like for you to consider. On 2/15/19 3:07 AM, Paul Menzel wrote: > Date: Thu, 10 Nov 2016 13:44:25 -0500 > > Add GRUB_F

Re: [GRUB PARTUUID PATCH V10 4/4] Update grub script template files

2018-04-17 Thread Nick Vinson
On 04/17/2018 06:36 AM, Daniel Kiper wrote: > On Mon, Apr 16, 2018 at 10:36:26PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documentation. The following table >> shows how GRUB_DISABLE_LINUX_UUID, GRUB_

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-16 Thread Nick Vinson
On 04/16/2018 04:47 AM, Daniel Kiper wrote: > On Wed, Apr 11, 2018 at 07:45:01AM -0700, Nick Vinson wrote: >> On 04/11/2018 01:31 AM, Daniel Kiper wrote: >>> On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: >>>> On 04/10/2018 01:52 PM, Daniel Kiper wrote:

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-11 Thread Nick Vinson
On 04/11/2018 01:31 AM, Daniel Kiper wrote: > On Tue, Apr 10, 2018 at 08:00:04PM -0700, Nick Vinson wrote: >> On 04/10/2018 01:52 PM, Daniel Kiper wrote: >>> On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: >>>> Update grub-mkconfig.in and 10_linux.

Re: [GRUB PARTUUID PATCH V9 0/5] Add PARTUUID detection support

2018-04-10 Thread Nick Vinson
On 04/10/2018 01:56 PM, Daniel Kiper wrote: > On Sat, Apr 07, 2018 at 04:28:09PM -0700, Nicholas Vinson wrote: >> Changes from Patch v8: >> - Renamed GRUB_ENABLE_LINUX_PARTUUID to GRUB_DISABLE_LINUX_PARTUUID >> - Updated the 10_linux logic so GRUB_ENABLE_LINUX_PARTUUID and >> GRUB_E

Re: [GRUB PARTUUID PATCH V9 4/5] Update grub script template files

2018-04-10 Thread Nick Vinson
On 04/10/2018 01:52 PM, Daniel Kiper wrote: > On Sat, Apr 07, 2018 at 04:28:13PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documentation. The following table >> shows how GRUB_DISABLE_LINUX_UUID, GRU

Re: [GRUB PARTUUID PATCH V8 4/4] Update grub script template files

2018-04-04 Thread Nick Vinson
On 04/04/2018 01:23 PM, Daniel Kiper wrote: > On Wed, Mar 28, 2018 at 08:32:54AM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. >> >> Signed-off-by: Nicholas Vinson >> --- >> docs/grub.texi

Re: [GRUB PARTUUID PATCH V7 3/4] Add PARTUUID detection support to grub-probe

2018-03-27 Thread Nick Vinson
On 03/27/2018 01:52 PM, Daniel Kiper wrote: > On Mon, Mar 26, 2018 at 11:07:58PM -0700, Nicholas Vinson wrote: >> Add PARTUUID detection support grub-probe for MBR and GPT partition >> schemes. >> >> Signed-off-by: Nicholas Vinson >> --- >> util/grub-probe.c | 48 +

Re: [GRUB PARTUUID PATCH V6 3/4] Add PARTUUID detection support to grub-probe

2018-03-22 Thread Nick Vinson
On 03/22/2018 06:51 AM, Daniel Kiper wrote: > On Sun, Mar 18, 2018 at 12:06:02PM -0700, Nicholas Vinson wrote: >> Add PARTUUID detection support grub-probe for MBR and GPT partition >> schemes. >> >> Signed-off-by: Nicholas Vinson >> --- >> util/grub-probe.c | 51 +

Re: [GRUB PARTUUID PATCH V6 4/4] Update grub script template files

2018-03-22 Thread Nick Vinson
On 03/22/2018 06:56 AM, Daniel Kiper wrote: > On Sun, Mar 18, 2018 at 12:06:03PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. >> >> Signed-off-by: Nicholas Vinson >> --- >> docs/grub.texi

Re: [GRUB PARTUUID PATCH V5 3/3] Update grub script template files

2018-03-18 Thread Nick Vinson
On 02/20/2018 09:45 AM, Daniel Kiper wrote: > On Sun, Feb 04, 2018 at 11:47:37AM -0800, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. > > As earlier lack of SOB. Otherwise LGTM. Will be added in V6

Re: [GRUB PARTUUID PATCH V5 2/3] Add PARTUUID detection support to grub-probe

2018-03-18 Thread Nick Vinson
On 02/20/2018 09:41 AM, Daniel Kiper wrote: > On Sun, Feb 04, 2018 at 11:47:36AM -0800, Nicholas Vinson wrote: >> Add PARTUUID detection support grub-probe for MBR and GPT partition >> schemes. The Linux kernel supports mounting the root filesystem by >> Linux device name or by the Partition [GU]U

Re: [GRUB PARTUUID PATCH V5 1/3] Update grub_gpt_partentry; centralize guid prints

2018-03-18 Thread Nick Vinson
Sorry for the delay in responding. I just now saw these replies. On 02/20/2018 09:30 AM, Daniel Kiper wrote: > On Sun, Feb 04, 2018 at 11:47:35AM -0800, Nicholas Vinson wrote: >> To help clean the code and simplify the code in util/grub-probe.c, this >> patch renames grub_gpt_part_type to grub_gp

Re: [GRUB PARTUUID PATCH V4 0/3] Add PARTUUID detection support

2017-07-23 Thread Nick Vinson
Hello, I submitted this patch set back in May and have not heard anything. I noticed it also has not been merged into the GRUB tree. Is there some issue with the patches that I still need to fix? If so, please let me know so I can make the corrections and submit an updated patch set. Thanks, N

Re: [GRUB PARTUUID PATCH V3 0/5] Add PARTUUID detection support

2017-05-08 Thread Nick Vinson
I would like to remind grub-devel of this patch set. Since the last time I submitted this, Flex-2.6.4 has been released, so Part 1 of this patch set can now be dropped. Part 5 is optional and can be removed if the development team does not approve of its changes. Finally, this is the version tha

Re: [PATCH 1/1] add --partuuid to probe

2017-02-14 Thread Nick Vinson
I'll need to check it against the 2.02 sources, but even if it needs updating, it shouldn't be too hard to do it. I can add your changes to the patchset. -Nick On 02/14/2017 11:39 AM, Steve Kenton wrote: > Nick, > > What is the state of your patch set? I think mine is much smaller if you > want

Re: Grub module to return partuuid of a device such as (hd0, gpt1) at boot time

2016-08-15 Thread Nick Vinson
der version of this patch set that I submitted back in June. You may find the review comments helpful. The link to the comments are: http://lists.gnu.org/archive/html/grub-devel/2016-07/msg00043.html Thanks, Nicholas Vinson > > On August 14, 2016 9:43:14 PM CDT, Nick Vinson wrote: >

Re: Grub module to return partuuid of a device such as (hd0, gpt1) at boot time

2016-08-15 Thread Nick Vinson
Steve, I'm not part of the mailing list and I only periodically check it. However, I was wondering if your request is the same as the code request that I made earlier this month (http://lists.gnu.org/archive/html/grub-devel/2016-08/msg00018.html). If not could you tell me how it's different? If t

Re: [GRUB PARTUUID PATCH 2/2] Update grub script template files

2016-07-27 Thread Nick Vinson
On 07/26/2016 10:01 PM, Andrei Borzenkov wrote: > 20.06.2016 04:37, Nicholas Vinson пишет: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. >> >> Signed-off-by: Nicholas Vinson >> --- >> util/grub-mkconfig.in | 2 ++ >> util/grub.d/10_linux.in | 11 +

Re: [GRUB PARTUUID PATCH 2/2] Update grub script template files

2016-07-19 Thread Nick Vinson
My apologies. It looks like most of my reply was cut-off when this email was sent. I'm pasting the missing part below. Thanks, Nicholas Vinson > I found a minor error in my original patch for 10_linux.in. I created the > patch > below to fix it. My apologies for not noticing it in the origin