Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-06 Thread Nick Terrell
> On Nov 6, 2019, at 4:40 AM, David Sterba wrote: > > On Tue, Nov 05, 2019 at 09:19:59AM +, Michael Chang wrote: >> The zstd support in btrfs has dependenciy to zstd module and core.img >> grows its size significantly to 75KB on my system. The resulted image >> cannot be installed into btrfs

Re: [PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-26 Thread Nick Terrell
> On Nov 19, 2018, at 12:34 PM, Daniel Kiper wrote: > > On Mon, Nov 19, 2018 at 11:20:06AM -0800, Nick Terrell wrote: >> Hi all, >> >> This patch set imports the upstream zstd library, adds zstd support to the >> btrfs module, and adds a test case. I'v

[PATCH v7 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
ssion. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell Reviewed-by: Daniel Kiper --- v1 -> v2: - Fix comments from Daniel Kiper. v2 -> v3: - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). - Fi

[PATCH v7 0/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
Hi all, This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without zstd compression and rebooting. Best, Nick Terrell Changelog: v1 -> v2: - S

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-19 Thread Nick Terrell
> On Nov 19, 2018, at 7:11 AM, Daniel Kiper wrote: > >> On Mon, Nov 19, 2018 at 03:22:51PM +0100, Daniel Kiper wrote: >>> On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote: >>> - Adds zstd support to the btrfs module. >>> - Adds a test cas

[PATCH v6 0/2] btrfs: Add zstd support to grub btrfs

2018-11-15 Thread Nick Terrell
Hi all, This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without zstd compression and rebooting. Best, Nick Terrell Changelog: v1 -> v2: - S

[PATCH v6 2/2] btrfs: Add zstd support to grub btrfs

2018-11-15 Thread Nick Terrell
ssion. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Kiper. v2 -> v3: - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). - Fix style and formatting comments

[PATCH v5 2/2] btrfs: Add zstd support to grub btrfs

2018-11-12 Thread Nick Terrell
ssion. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Kiper. v2 -> v3: - Use grub_error() to set grub_errno in grub_btrfs_zstd_decompress(). - Fix style and formatting comments

[PATCH v5 0/2] btrfs: Add zstd support to grub btrfs

2018-11-12 Thread Nick Terrell
Hi all, This patch set imports the upstream zstd library, adds zstd support to the btrfs module, and adds a test case. I've also tested the patch set by storing my boot partition in btrfs with and without zstd compression and rebooting. Best, Nick Terrell Changelog: v1 -> v2: - S

Re: [PATCH v4 1/2] Import upstream zstd-1.3.6

2018-11-06 Thread Nick Terrell
> On Nov 6, 2018, at 6:48 AM, Daniel Kiper wrote: > > On Wed, Oct 31, 2018 at 10:56:16AM -0700, Nick Terrell wrote: >> Import zstd-1.3.6 from upstream [1]. Only the files need for decompression >> are imported. Additionally makes zstd a module by adding module.c which &g

[PATCH v4 2/2] btrfs: Add zstd support to grub btrfs

2018-10-31 Thread Nick Terrell
Adds zstd support to the btrfs module. Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd compression. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Ki

[PATCH v4 0/2] btrfs: Add zstd support to grub btrfs

2018-10-31 Thread Nick Terrell
"zstd-1.3.6/lib" DST_LIB="grub-core/lib/zstd" rm -rf $DST_LIB mkdir -p $DST_LIB cp $SRC_LIB/zstd.h $DST_LIB/ cp $SRC_LIB/common/*.[hc] $DST_LIB/ cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ rm $DST_LIB/{pool.[hc],threading.[hc]} rm -rf zstd-1.3.6* echo SUCCESS! ``` Best, Nick Terrell

Re: [PATCH V10] Add support for BTRFS raid5/6 to GRUB

2018-10-22 Thread Nick Terrell
> On Oct 22, 2018, at 4:02 AM, Daniel Kiper wrote: > > On Thu, Oct 18, 2018 at 07:55:32PM +0200, Goffredo Baroncelli wrote: >> >> Hi All, >> >> the aim of this patches set is to provide support for a BTRFS raid5/6 >> filesystem in GRUB. >> >> The first patch, implements the basic support fo

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Nick Terrell
> On Oct 11, 2018, at 11:15 AM, Daniel Kiper wrote: > > Hi Nick, > > CC-ing Goffredo. > > On Tue, Oct 09, 2018 at 04:21:35PM -0700, Nick Terrell wrote: >> Hi all, >> >> This patch set imports the upstream zstd library, adds zstd support to the >

Re: [PATCH v3 2/2] btrfs: Add zstd support to grub btrfs

2018-10-11 Thread Nick Terrell
> On Oct 11, 2018, at 10:55 AM, Daniel Kiper wrote: > > On Tue, Oct 09, 2018 at 04:21:37PM -0700, Nick Terrell wrote: >> Adds zstd support to the btrfs module. >> >> Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd >> compression.

Re: [PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-10 Thread Nick Terrell
> On Oct 10, 2018, at 12:34 AM, Paul Menzel wrote: > > Sorry for being ignorant, but you explain, why the library needs to be > imported and it is not enough to use that library as an external dependency? > > Importing the library means, it has to be maintained in the GRUB repository, > whi

[PATCH v3 2/2] btrfs: Add zstd support to grub btrfs

2018-10-09 Thread Nick Terrell
Adds zstd support to the btrfs module. Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd compression. A test case was also added to the test suite that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Ki

[PATCH v3 0/2] btrfs: Add zstd support to grub btrfs

2018-10-09 Thread Nick Terrell
"zstd-1.3.6/lib" DST_LIB="grub-core/lib/zstd" rm -rf $DST_LIB mkdir -p $DST_LIB cp $SRC_LIB/zstd.h $DST_LIB/ cp $SRC_LIB/common/*.[hc] $DST_LIB/ cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ rm $DST_LIB/{pool.[hc],threading.[hc]} rm -rf zstd-1.3.6* echo SUCCESS! --- Best, Nick Terrell

Re: [PATCH v2 2/2] btrfs: Add zstd support to grub btrfs

2018-10-09 Thread Nick Terrell
> On Oct 9, 2018, at 12:07 PM, Daniel Kiper wrote: > On Mon, Oct 08, 2018 at 04:06:21PM -0700, Nick Terrell wrote: >> Adds zstd support to the btrfs module. I'm not sure that my changes to the >> Makefiles are correct, please let me know if I need to do something >>

[PATCH v2 2/2] btrfs: Add zstd support to grub btrfs

2018-10-08 Thread Nick Terrell
that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- v1 -> v2: - Fix comments from Daniel Kiper Makefile.util.def| 10 +++- grub-core/Makefile.core.def | 10 +++- grub-core/fs/btrfs.c | 105 ++- grub-core/lib

[PATCH v2 0/2] btrfs: Add zstd support to grub btrfs

2018-10-08 Thread Nick Terrell
"zstd-1.3.6/lib" DST_LIB="grub-core/lib/zstd" rm -rf $DST_LIB mkdir -p $DST_LIB cp $SRC_LIB/zstd.h $DST_LIB/ cp $SRC_LIB/common/*.[hc] $DST_LIB/ cp $SRC_LIB/decompress/*.[hc] $DST_LIB/ rm $DST_LIB/{pool.[hc],threading.[hc]} rm -rf zstd-1.3.6* echo SUCCESS! --- Best, Nick Terrell

Re: [PATCH 1/3] btrfs: Import kernel zstd

2018-09-21 Thread Nick Terrell
> On Sep 21, 2018, at 11:10 AM, Daniel Kiper wrote: > > On Mon, Aug 27, 2018 at 06:36:52PM -0700, Nick Terrell wrote: >> Import xxhash and zstd from the upstream kernel as-is. This will not >> compile. The next patch in the series contains all the changes needed to &g

Re: [PATCH 0/3] btrfs: Add zstd support to btrfs

2018-09-11 Thread Nick Terrell
> On Sep 11, 2018, at 3:23 AM, David Sterba wrote: > > On Mon, Aug 27, 2018 at 06:36:51PM -0700, Nick Terrell wrote: >> Hi all, >> >> This patch set imports the upstream kernel zstd library, patches it to work >> in grub, adds zstd support to the btrfs m

[PATCH 2/3] btrfs: Patch the kernel zstd

2018-08-27 Thread Nick Terrell
ypedef. * Remove the module code. * Switch the memcpy() in ZSTD_copy8() to __builtin_memcpy(). Signed-off-by: Nick Terrell --- grub-core/lib/zstd/bitstream.h | 6 grub-core/lib/zstd/decompress.c | 56 ++ grub-core/lib/zstd/error_private.h | 3 +- grub

[PATCH 3/3] btrfs: Add zstd support to btrfs

2018-08-27 Thread Nick Terrell
that fails before the patch, and passes after. Signed-off-by: Nick Terrell --- Makefile.util.def| 8 - grub-core/Makefile.core.def | 10 -- grub-core/fs/btrfs.c | 85 +++- tests/btrfs_test.in | 1 + tests/util/gr

[PATCH 0/3] btrfs: Add zstd support to btrfs

2018-08-27 Thread Nick Terrell
this project! I started my patch from where he left off. Best, Nick Terrell Nick Terrell (3): Import kernel zstd Patch the kernel zstd Add btrfs zstd support Makefile.util.def |8 +- grub-core/Makefile.core.def | 10 +- grub-core/fs/btrfs.c|