Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module

2018-10-09 Thread Michel Hermier
That said maybe it's better for readability to do it in 2 patch, one for moving the file and one for the renaming. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 5/8] verifiers: Rename verify module to pgp module

2018-10-09 Thread Michel Hermier
This is to be expected. Patch file format is dumb and doesn't know about files moving. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3 2/6] efi: add grub_efi_get_ram_base() function for arm64

2018-07-06 Thread Michel Hermier
Le ven. 6 juil. 2018 à 17:17, Daniel Kiper a écrit : > On Wed, Jun 27, 2018 at 06:17:16PM +0100, Leif Lindholm wrote: > > Since ARM platforms do not have a common memory map, add a helper > > function that finds the lowest address region with the EFI_MEMORY_WB > > attribute set in the UEFI memory

Re: Can't read md0 with grub

2018-01-11 Thread Michel Hermier
First idea check that your grub.cfg was updated. Pointing to older kernel really looks like it was not updated. Le 11 janv. 2018 4:18 PM, "Joseph Parmelee" a écrit : Good morning: I have been using a raid1 array (version 09) with grub for several years. My grub.cfg file loads module mdraid09.mo

Re: [PATCH] Better ahci error handling

2018-01-02 Thread Michel Hermier
Hi, IS_FATAL_ERROR sounds like a utility macro, I would add a parameter to test the flags and make it return a Bool compatible value. My 2 cents comments. Cheers Le 2 janv. 2018 11:05, "Stefan Fritsch" a écrit : Hi, on a Fujitsu E744 laptop we have a problem that sometimes there is a very long

Re: Grub2: add UEFI support for accessing memory address above 4GB.

2017-03-08 Thread Michel Hermier
es over 32 MiB. "Modern TFTP" (with larger/negotiated block size and 16-bit block numbers that are allowed to roll over) has no limit at all. > On Tue, Mar 7, 2017, 09:09 Michel Hermier wrote: > > Because I don't trust automatic detection. Even if one say it is 200% safe, ther

Re: Grub2: add UEFI support for accessing memory address above 4GB.

2017-03-07 Thread Michel Hermier
Le 7 mars 2017 18:22, "Vladimir 'phcoder' Serbinenko" a écrit : On Tue, Mar 7, 2017, 09:09 Michel Hermier wrote: > > > Le 7 mars 2017 17:24, "Vladimir 'phcoder' Serbinenko" > a écrit : > > > > On Tue, Mar 7, 2017, 08:15 Le

Re: Grub2: add UEFI support for accessing memory address above 4GB.

2017-03-07 Thread Michel Hermier
Le 7 mars 2017 17:24, "Vladimir 'phcoder' Serbinenko" a écrit : On Tue, Mar 7, 2017, 08:15 Leif Lindholm wrote: > On Tue, Mar 07, 2017 at 01:55:01AM +, Yufuping wrote: > > Who can add the new feature for grub2: > > Add UEFI support for accessing memory address above 4GB. > > Presumably yo

Re: talking grub?

2016-04-29 Thread Michel Hermier
Hi, Considering the complexity of voice generation, maybe it would be more simple to support braille displays which should be less complex to implement. Not speaking that most blind people using computers should have one I guess, since it sounds more productive to me. My 2 cents to the subject. Che

Re: [PATCH] Allow user-defined functions to override builtins.

2014-05-25 Thread Michel Hermier
Le 22 mai 2014 09:32, "Vladimir 'φ-coder/phcoder' Serbinenko" < phco...@gmail.com> a écrit : > > On 19.05.2014 08:37, Glenn Washburn wrote: > > Currently, builtin commands take precedence over user-defined > > functions. This patch reverses that precedence, so that users can > > "override" builtin

Re: [PATCH 2/2] Allow user-defined functions to override builtins. [take 2]

2014-05-22 Thread Michel Hermier
I don't know the code much, but i think your change looks like a hack. I fell missing an internal command registration in main.c, a small function to handle the command, and an extra parameter in grub_script_execute_cmdline to allow/exclude user defined commands so that it can be called from builti

Re: [PATCH] Allow user-defined functions to override builtins.

2014-05-19 Thread Michel Hermier
Le 19/05/2014 08:37, Glenn Washburn a écrit : Currently, builtin commands take precedence over user-defined functions. This patch reverses that precedence, so that users can "override" builtin commands. Builtin commands may be accessed by issuing the command prefixed by an '@' character. If you

[Fwd: [PATCH] Some pxe fixes.]

2009-05-01 Thread Michel Hermier
UNUSED macro. Michel Index: ChangeLog === --- ChangeLog (révision 2154) +++ ChangeLog (copie de travail) @@ -1,3 +1,9 @@ +2009-05-01 Michel Hermier + + * fs/i386/pc/pxe.c (grub_pxefs_read): Fix returned values