Re: [PATCH 1/2] Include function name on debug traces

2025-04-23 Thread Leo Sandoval via Grub-devel
On Wed, Apr 23, 2025 at 10:30 AM Vladimir 'phcoder' Serbinenko < phco...@gmail.com> wrote: > > > Le mer. 23 avr. 2025, 01:39, Leo Sandoval a écrit : > >> >> >> On Tue, Apr 15, 2025 at 9:28 AM Vladimir 'phcoder' Serbinenko < >> p

Re: [PATCH 1/2] Include function name on debug traces

2025-04-22 Thread Leo Sandoval via Grub-devel
b2/ > > Regards > Vladimir 'phcoder' Serbinenko > > Le sam. 12 avr. 2025, 01:03, Leo Sandoval via Grub-devel < > grub-devel@gnu.org> a écrit : > >> Together with the line number, the debug trace with the function name >> provides a bit more con

[PATCH 2/2] Prepend debug traces with absolute and relative timestamps

2025-04-11 Thread Leo Sandoval via Grub-devel
From: Renaud Métrich Debug traces with timestamps are useful to detect performance issues. To enable it, include '--with-debug-timestamps' argument on the configure step. Signed-off-by: Renaud Métrich Signed-off-by: Leo Sandoval --- config.h.in | 1 + configure.ac

[PATCH 1/2] Include function name on debug traces

2025-04-11 Thread Leo Sandoval via Grub-devel
Together with the line number, the debug trace with the function name provides a bit more context and could be useful when inspecting log. Signed-off-by: Leo Sandoval --- grub-core/kern/misc.c | 4 ++-- include/grub/misc.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff

Re: [PATCH] powerpc: increase MIN RMA size for CAS negotiation

2025-02-18 Thread Leo Sandoval
LGTM Reviewed-by: Leo Sandoval On Mon, Feb 17, 2025 at 12:44 PM Mukesh Kumar Chaurasiya < mchau...@linux.ibm.com> wrote: > On Wed, Jan 15, 2025 at 05:46:05PM +0530, Avnish Chouhan wrote: > > Change RMA size from 512 MB to 768 MB which will result > > in more memory at

Re: [PATCH] term/ns8250: return in case of a null SPCR base addresses

2025-01-22 Thread Leo Sandoval
Please ignore this patch, a better approach is https://lists.gnu.org/archive/html/grub-devel/2025-01/msg00093.html On Thu, Jan 9, 2025 at 10:37 AM Leo Sandoval wrote: > Serial SPCR MMIO null address are invalid, so return from function, > otherwise > invalid 'mmio,0' port

[PATCH] disk/ahci.c: remove conditional operator for endtime

2025-01-22 Thread Leo Sandoval
The conditional makes no sense when the two possible expressions have the same value, so remove it (perhaps the compiler does it for us but better to remove it). Signed-off-by: Leo Sandoval --- grub-core/disk/ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core

[PATCH] term/nns8250-spcr: return if redirection is disabled

2025-01-21 Thread Leo Sandoval
et invalid ports for those particular machines that redirection is disabled and at some point hanging the booting execution when reading the grub.cfg configuration file. Signed-off-by: Benjamin Herrenschmidt Reviewed-by: Leo Sandoval --- grub-core/term/ns8250-spcr.c | 5 + 1 file changed, 5

[PATCH] term/ns8250: return in case of a null SPCR base addresses

2025-01-09 Thread Leo Sandoval
Serial SPCR MMIO null address are invalid, so return from function, otherwise invalid 'mmio,0' port names are generated halting the system when running terminal_input|output commands. Signed-off-by: Leo Sandoval --- grub-core/term/ns8250.c | 3 +++ 1 file changed, 3 insertions(+) di

Re: [PATCH v1 14/15] grub-install: install on EFI if forced

2024-11-04 Thread Leo Sandoval
On Sun, Nov 3, 2024 at 7:09 PM Neal Gompa wrote: > On Thu, Oct 31, 2024 at 3:43 PM Leo Sandoval wrote: > > > > From: Marta Lewandowska > > > > UEFI Secure Boot requires signed grub binaries to work, so grub- > > install should not be used. However, users who

Re: [PATCH v1 11/15] grub-install: disable support for EFI platforms

2024-11-04 Thread Leo Sandoval
On Sun, Nov 3, 2024 at 7:08 PM Neal Gompa wrote: > > On Thu, Oct 31, 2024 at 3:43 PM Leo Sandoval wrote: > > > > From: Jan Hlavac > > > > For each platform, GRUB is shipped as a kernel image and a set of > > modules. These files are then used by the grub-inst

[PATCH v1 11/15] grub-install: disable support for EFI platforms

2024-10-31 Thread Leo Sandoval
From: Jan Hlavac For each platform, GRUB is shipped as a kernel image and a set of modules. These files are then used by the grub-install utility to install GRUB on a specific device. However, in order to support UEFI Secure Boot, the resulting EFI binary must be signed by a recognized private ke

[PATCH v1 01/15] misc: Make "exit" take a return code.

2024-10-31 Thread Leo Sandoval
From: Peter Jones This adds "exit" with a return code. With this patch, any "exit" command /may/ include a return code, and on platforms that support returning with an exit status, we will do so. By default we return the same exit status we did before this patch. Signed-off-by: Peter Jones --

[PATCH v1 1/5] btrfs: Add ability to boot from subvolumes

2024-10-31 Thread Leo Sandoval
From: Jeff Mahoney This patch adds the ability to specify a different root on a btrfs filesystem too boot from other than the default one. btrfs-list-snapshots will list the subvolumes available on the filesystem. set btrfs_subvol= and set btrfs_subvolid= will specify which subvolume to use an

[PATCH v1 02/15] efi/init: Make efi machines load an env block from a variable

2024-10-31 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- grub-core/Makefile.core.def | 1 + grub-core/kern/efi/init.c | 34 ++ 2 files changed, 35 insertions(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 1571421d7..0bffbfea9 100644 -

[PATCH v1 10/15] env: Add efi-export-env and efi-load-env commands

2024-10-31 Thread Leo Sandoval
From: Peter Jones This adds "efi-export-env VARIABLE" and "efi-load-env", which manipulate the environment block stored in the EFI variable GRUB_ENV-91376aff-cba6-42be-949d-06fde81128e8. Signed-off-by: Peter Jones --- grub-core/Makefile.core.def | 6 ++ grub-core/commands/efi/env.c | 170 ++

[PATCH v1 05/15] efi/api: Add PRIxGRUB_EFI_STATUS and use it.

2024-10-31 Thread Leo Sandoval
From: Peter Jones This avoids syntax checkers getting confused about if it's llx or lx. Signed-off-by: Peter Jones --- include/grub/efi/api.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h index d44d00ad7..5f3cd4cc0 100644 --- a/inc

[PATCH v1 08/15] misc: align struct efi_variable better...

2024-10-31 Thread Leo Sandoval
From: Peter Jones --- include/grub/efiemu/runtime.h | 2 +- include/grub/types.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/grub/efiemu/runtime.h b/include/grub/efiemu/runtime.h index 2ff429845..6363fd522 100644 --- a/include/grub/efiemu/runtime.h +++ b

[PATCH v1 12/15] connectefi: new 'connectefi' command

2024-10-31 Thread Leo Sandoval
From: Renaud Métrich When efi.quickboot is enabled on VMWare (which is the default for hardware release 16 and later), it may happen that not all EFI devices are connected. Due to this, browsing the devices in make_devices() just fails to find devices, in particular disks or partitions for a give

[PATCH v1 2/5] btrfs: fix a bad null check

2024-10-31 Thread Leo Sandoval
From: Peter Jones current gcc complains: grub-core/fs/btrfs.c: In function ‘grub_cmd_btrfs_info’: grub-core/fs/btrfs.c:2745:7: error: the comparison will always evaluate as ‘true’ for the address of ‘label’ will never be NULL [-Werror=address] 2745 | if (data->sblock.label) |

[PATCH v1 4/5] btrfs: Allow specifying btrfs_relative_path to follow the default subvolume

2024-10-31 Thread Leo Sandoval
From: Michael Chang This patch enables the use of a relative path to the btrfs default subvolume by setting the environment variable btrfs_relative_path=[y1]. In contrast to using an absolute path from the toplevel root, which always reads files consistently from a fixed location, the relative pa

[PATCH v1 3/5] btrfs: export btrfs_subvol and btrfs_subvolid

2024-10-31 Thread Leo Sandoval
From: Michael Chang We should export btrfs_subvol and btrfs_subvolid to have both visible to subsidiary configuration files loaded using configfile. Signed-off-by: Michael Chang --- grub-core/fs/btrfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/b

[PATCH v1 13/15] nx: set the nx compatible flag in EFI grub images

2024-10-31 Thread Leo Sandoval
From: Peter Jones For NX, we need the grub binary to announce that it is compatible with the NX feature. This implies that when loading the executable grub image, several attributes are true: - the binary doesn't need an executable stack - the binary doesn't need sections to be both executable

[PATCH v1 04/15] chainloader: Use grub_efi_...() memory helpers where reasonable.

2024-10-31 Thread Leo Sandoval
From: Peter Jones This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we get more reasonable type checking. Signed-off-by: Peter Jones --- grub-core/loader/efi/chainloader.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v1 03/15] efi: Add grub_efi_allocate_pool() and grub_efi_free_pool() wrappers.

2024-10-31 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- include/grub/efi/efi.h | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/include/grub/efi/efi.h b/include/grub/efi/efi.h index a5cd99e5a..8d98203a7 100644 --- a/include/grub/efi/efi.h +++ b/

[PATCH v1 07/15] grub-install: Don't guess /boot/efi/ as HFS+ on ppc machines in grub-install

2024-10-31 Thread Leo Sandoval
From: Peter Jones This should never be trying this, and since we've consolidated the grubenv to always be on /boot/efi/EFI/fedora/, this code causes it to always make the wrong decision. Resolves: rhbz#1484474 Signed-off-by: Peter Jones --- util/grub-install.c | 12 +--- 1 file change

[PATCH v1 06/15] efi: don't use int for efi status

2024-10-31 Thread Leo Sandoval
From: Peter Jones --- grub-core/kern/efi/efi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/kern/efi/efi.c b/grub-core/kern/efi/efi.c index 885d7c642..2bb8a0e7a 100644 --- a/grub-core/kern/efi/efi.c +++ b/grub-core/kern/efi/efi.c @@ -177,7 +177,7 @@ grub_reboot (

[PATCH v1 14/15] grub-install: install on EFI if forced

2024-10-31 Thread Leo Sandoval
From: Marta Lewandowska UEFI Secure Boot requires signed grub binaries to work, so grub- install should not be used. However, users who have Secure Boot disabled and wish to use the command should not be prevented from doing so if they invoke --force. fixes bz#1917213 / bz#2240994 Signed-off-by

[PATCH v1 0/5] Fedora Rawhide BTRFS patches

2024-10-31 Thread Leo Sandoval
This series contains BTRFS patches taken from Fedora Rawhide [1]. Some of these patches have already being sent [2][3] however, as suggested by Daniel Kiper, to make the review easier, I took only BTRFS related patches from [1][2][3] and create the series. [1] https://src.fedoraproject.org/rpms/gr

[PATCH v1 15/15] 25_bli.in 30_uefi_firmware.in: load EFI commands inside test expressions

2024-10-31 Thread Leo Sandoval
These two commands may fail interrumping the normal boot process, so placing these inside test expressions is a safer approach. Resolves: #2305291 Suggested-by: Kan-Ru Chen: Signed-off-by: Leo Sandoval --- util/grub.d/25_bli.in | 4 +++- util/grub.d/30_uefi-firmware.in | 3 +-- 2

[PATCH v1 09/15] console: Work around some minor include path weirdnesses

2024-10-31 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- include/grub/arm/efi/console.h| 24 include/grub/arm64/efi/console.h | 24 include/grub/i386/efi/console.h | 24 include/grub/x86_64/efi/console.h | 24

[PATCH v1 00/15] Fedora Rawhide (non-network) EFI patches

2024-10-31 Thread Leo Sandoval
support for EFI platforms Leo Sandoval (1): 25_bli.in 30_uefi_firmware.in: load EFI commands inside test expressions Marta Lewandowska (1): grub-install: install on EFI if forced Peter Jones (11): misc: Make "exit" take a return code. efi/init: Make efi machines load an

[PATCH v1 5/5] btrfs: Fixup for newer compiler

2024-10-31 Thread Leo Sandoval
From: Peter Jones --- grub-core/fs/btrfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index d47f9ab03..7024decf5 100644 --- a/grub-core/fs/btrfs.c +++ b/grub-core/fs/btrfs.c @@ -217,7 +217,7 @@ struct grub_btrfs_inode grub_u

Re: [PATCH v3 00/16] First Distro-agnostic series taken from Fedora Rawhide

2024-10-30 Thread Leo Sandoval
Hi Daniel, Thanks for your feedback, comment inline. On Wed, Oct 30, 2024 at 10:40 AM Daniel Kiper wrote: > Leo, > > On Thu, Oct 10, 2024 at 03:43:18PM -0600, Leo Sandoval wrote: > > This is the first patch series, taken from Fedora Rawhide spec [1] that > > is distro-agn

[PATCH] legacycfg.c: avoid closing file twice

2024-10-16 Thread Leo Sandoval
quot;. grub-2.06/grub-core/commands/legacycfg.c:201: deref_arg: Calling "grub_file_close" dereferences freed pointer "file". # 199| if (!args) # 200| { # 201|-> grub_file_close (file); # 202| grub_free (suffix); # 203|

[PATCH v3 28/29] efi: Add grub_efi_allocate_pool() and grub_efi_free_pool() wrappers.

2024-10-14 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- include/grub/efi/efi.h | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/include/grub/efi/efi.h b/include/grub/efi/efi.h index a5cd99e5a..8d98203a7 100644 --- a/include/grub/efi/efi.h +++ b/

[PATCH v3 29/29] chainloader: Use grub_efi_...() memory helpers where reasonable.

2024-10-14 Thread Leo Sandoval
From: Peter Jones This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we get more reasonable type checking. Signed-off-by: Peter Jones --- grub-core/loader/efi/chainloader.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v3 18/29] grub-set-password.in: Add friendly grub2 password config tool (#985962)

2024-10-14 Thread Leo Sandoval
From: Robert Marshall Provided a tool for users to reset the grub2 root user password without having to alter the grub.cfg. The hashed password now lives in a root-only-readable configuration file. Resolves: rhbz#985962 Signed-off-by: Robert Marshall [pjones: fix the efidir in grub-setpassword

[PATCH v3 22/29] btrfs: Add ability to boot from subvolumes

2024-10-14 Thread Leo Sandoval
From: Jeff Mahoney This patch adds the ability to specify a different root on a btrfs filesystem too boot from other than the default one. btrfs-list-snapshots will list the subvolumes available on the filesystem. set btrfs_subvol= and set btrfs_subvolid= will specify which subvolume to use an

[PATCH v3 25/29] btrfs: Allow specifying btrfs_relative_path to follow the default subvolume

2024-10-14 Thread Leo Sandoval
From: Michael Chang This patch enables the use of a relative path to the btrfs default subvolume by setting the environment variable btrfs_relative_path=[y1]. In contrast to using an absolute path from the toplevel root, which always reads files consistently from a fixed location, the relative pa

[PATCH v3 26/29] grub-mkconfig: Add GRUB_BTRFS_SNAPSHOT_BOOTING simple configuration

2024-10-14 Thread Leo Sandoval
From: Michael Chang To support btrfs rollback and snapshot booting, a simple configuration setting GRUB_BTRFS_SNAPSHOT_BOOTING is introduced to enable this at the configuration level. When set to "yes," grub-mkconfig will set btrfs_relative_path=y, and all paths produced by grub-mkrelpath will be

[PATCH v3 00/29] Second Distro-agnostic series taken from Fedora Rawhide

2024-10-14 Thread Leo Sandoval
This is the second patch series, taken from Fedora Rawhide spec [1] that is distro-agnostic. The goal is to merge most of them so all the community/distros would benefit. Thanks to Michael Chang for suggesting and providing updated summaries and descriptions. Changes since v2: - modified 00

[PATCH v3 24/29] btrfs: export btrfs_subvol and btrfs_subvolid

2024-10-14 Thread Leo Sandoval
From: Michael Chang We should export btrfs_subvol and btrfs_subvolid to have both visible to subsidiary configuration files loaded using configfile. Signed-off-by: Michael Chang --- grub-core/fs/btrfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/b

[PATCH v3 27/29] btrfs: add btrfs-get-default-subvol command

2024-10-14 Thread Leo Sandoval
From: Michael Chang Introduce the "btrfs-get-default-subvol" command to output the default subvolume's name or id to the console, or to a variable specified via "-o". Some example usage: 1. Output the default subvolume's name or path: btrfs-get-default-subvol -p ($root) 2. Output the default

[PATCH v3 23/29] btrfs: fix a bad null check

2024-10-14 Thread Leo Sandoval
From: Peter Jones current gcc complains: grub-core/fs/btrfs.c: In function ‘grub_cmd_btrfs_info’: grub-core/fs/btrfs.c:2745:7: error: the comparison will always evaluate as ‘true’ for the address of ‘label’ will never be NULL [-Werror=address] 2745 | if (data->sblock.label) |

[PATCH v3 20/29] grub-get-kernel-settings.in: Add grub-get-kernel-settings and use it in 10_linux

2024-10-14 Thread Leo Sandoval
From: Peter Jones This patch adds grub-get-kernel-settings, which reads the system kernel installation configuration from /etc/sysconfig/kernel, and outputs ${GRUB_...} variables suitable for evaluation by grub-mkconfig. Those variables are then used by 10_linux to choose whether or not to creat

[PATCH v3 17/29] 10_linux.in: Make grub2-mkconfig construct titles that look like the ones we want elsewhere.

2024-10-14 Thread Leo Sandoval
From: Peter Jones Resolves: rhbz#1215839 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in index 3105c31e4..0115dd0c0 100644 --- a/util

[PATCH v3 21/29] 30_os-prober.in: just build chainloader entries, don't try any xnu xnu.

2024-10-14 Thread Leo Sandoval
From: Peter Jones Since our bugs tell us that the xnu boot entries really just don't work most of the time, and they create piles of extra boot entries, because they can't quite figure out 32-vs-64 and other stuff like that. It's rediculous, and we should just boot their bootloader through the c

[PATCH v3 19/29] net/tcp: add window scaling support

2024-10-14 Thread Leo Sandoval
From: Josef Bacik Sometimes we have to provision boxes across regions, such as California to Sweden. The http server has a 10 minute timeout, so if we can't get our 250mb image transferred fast enough our provisioning fails, which is not ideal. So add tcp window scaling on open connections and

Re: [PATCH v2 00/30] Second Distro-agnostic series taken from Fedora Rawhide

2024-10-14 Thread Leo Sandoval
On Sat, Oct 12, 2024 at 8:55 AM Neal Gompa wrote: > On Fri, Oct 11, 2024 at 6:39 PM Leo Sandoval wrote: > > > > This is the second patch series, taken from Fedora Rawhide spec [1] that > > is distro-agnostic. The goal is to merge most of them so all the > community/d

[PATCH v2 29/30] efi: Add grub_efi_allocate_pool() and grub_efi_free_pool() wrappers.

2024-10-11 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- include/grub/efi/efi.h | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/include/grub/efi/efi.h b/include/grub/efi/efi.h index a5cd99e5a..8d98203a7 100644 --- a/include/grub/efi/efi.h +++ b/

[PATCH v2 30/30] chainloader: Use grub_efi_...() memory helpers where reasonable.

2024-10-11 Thread Leo Sandoval
From: Peter Jones This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we get more reasonable type checking. Signed-off-by: Peter Jones --- grub-core/loader/efi/chainloader.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v2 24/30] btrfs: export btrfs_subvol and btrfs_subvolid

2024-10-11 Thread Leo Sandoval
From: Michael Chang We should export btrfs_subvol and btrfs_subvolid to have both visible to subsidiary configuration files loaded using configfile. Signed-off-by: Michael Chang --- grub-core/fs/btrfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/b

[PATCH v2 26/30] btdfs: grub2-btrfs-05-grub2-mkconfig

2024-10-11 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang --- util/grub-mkconfig.in | 3 ++- util/grub-mkconfig_lib.in | 4 util/grub.d/00_header.in| 26 +- util/grub.d/10_linux.in | 4 util/grub.d/20_linux_xen.in | 4 5 files changed, 39 insert

[PATCH v2 20/30] grub-get-kernel-settings.in: Add grub-get-kernel-settings and use it in 10_linux

2024-10-11 Thread Leo Sandoval
From: Peter Jones This patch adds grub-get-kernel-settings, which reads the system kernel installation configuration from /etc/sysconfig/kernel, and outputs ${GRUB_...} variables suitable for evaluation by grub-mkconfig. Those variables are then used by 10_linux to choose whether or not to creat

[PATCH v2 17/30] 10_linux.in: Make grub2-mkconfig construct titles that look like the ones we want elsewhere.

2024-10-11 Thread Leo Sandoval
From: Peter Jones Resolves: rhbz#1215839 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in index 3105c31e4..0115dd0c0 100644 --- a/util

[PATCH v2 19/30] net/tcp: add window scaling support

2024-10-11 Thread Leo Sandoval
From: Josef Bacik Sometimes we have to provision boxes across regions, such as California to Sweden. The http server has a 10 minute timeout, so if we can't get our 250mb image transferred fast enough our provisioning fails, which is not ideal. So add tcp window scaling on open connections and

[PATCH v2 21/30] 30_os-prober.in: just build chainloader entries, don't try any xnu xnu.

2024-10-11 Thread Leo Sandoval
From: Peter Jones Since our bugs tell us that the xnu boot entries really just don't work most of the time, and they create piles of extra boot entries, because they can't quite figure out 32-vs-64 and other stuff like that. It's rediculous, and we should just boot their bootloader through the c

[PATCH v2 23/30] btrfs: fix a bad null check

2024-10-11 Thread Leo Sandoval
From: Peter Jones current gcc complains: grub-core/fs/btrfs.c: In function ‘grub_cmd_btrfs_info’: grub-core/fs/btrfs.c:2745:7: error: the comparison will always evaluate as ‘true’ for the address of ‘label’ will never be NULL [-Werror=address] 2745 | if (data->sblock.label) |

[PATCH v2 25/30] btrfs: grub2-btrfs-03-follow_default

2024-10-11 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c | 107 ++- 1 file changed, 76 insertions(+), 31 deletions(-) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index 14e38a4df..d47f9ab03 1006

[PATCH v2 00/30] Second Distro-agnostic series taken from Fedora Rawhide

2024-10-11 Thread Leo Sandoval
This is the second patch series, taken from Fedora Rawhide spec [1] that is distro-agnostic. The goal is to merge most of them so all the community/distros would benefit. Changes since v1: - delete 0024-efinet-and-bootp-add-support-for-dhcpv6.patch build issue, so for the moment discart

[PATCH v2 22/30] btrfs: Add ability to boot from subvolumes

2024-10-11 Thread Leo Sandoval
From: Jeff Mahoney This patch adds the ability to specify a different root on a btrfs filesystem too boot from other than the default one. btrfs-list-snapshots will list the subvolumes available on the filesystem. set btrfs_subvol= and set btrfs_subvolid= will specify which subvolume to use an

[PATCH v2 27/30] btrfs: Fallback to old subvol name scheme to support old snapshot config

2024-10-11 Thread Leo Sandoval
From: Andrei Borzenkov Ref: bsc#953538 --- grub-core/fs/btrfs.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index d47f9ab03..c5b3fd116 100644 --- a/grub-core/fs/btrfs.c +++ b/grub-core/fs/btrfs.c

[PATCH v2 28/30] btrfs: Grub not working correctly with btrfs snapshots (bsc#1026511)

2024-10-11 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c | 238 +++ 1 file changed, 238 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index c5b3fd116..1c9e14008 100644 --- a/grub-co

[PATCH v2 18/30] grub-set-password.in: Add friendly grub2 password config tool (#985962)

2024-10-11 Thread Leo Sandoval
From: Robert Marshall Provided a tool for users to reset the grub2 root user password without having to alter the grub.cfg. The hashed password now lives in a root-only-readable configuration file. Resolves: rhbz#985962 Signed-off-by: Robert Marshall [pjones: fix the efidir in grub-setpassword

[PATCH v3 01/16] ieee1275/openfw: IBM client architecture (CAS) reboot support

2024-10-10 Thread Leo Sandoval
From: Paulo Flabiano Smorigo This is an implementation of IBM client architecture (CAS) reboot for GRUB. There are cases where the POWER firmware must reboot in order to support specific features requested by a kernel. The kernel calls ibm,client-architecture-support and it may either return or

[PATCH v3 08/16] normal: Add fw_path variable (revised)

2024-10-10 Thread Leo Sandoval
From: Paulo Flabiano Smorigo This patch makes grub look for its config file on efi where the app was found. It was originally written by Matthew Garrett, and adapted to fix the "No modules are loaded on grub2 network boot" issue: https://bugzilla.redhat.com/show_bug.cgi?id=857936 Signed-off-by:

[PATCH v3 00/16] First Distro-agnostic series taken from Fedora Rawhide

2024-10-10 Thread Leo Sandoval
This is the first patch series, taken from Fedora Rawhide spec [1] that is distro-agnostic. The goal is to merge most of them so all the community/distros would benefit. Changes since v2: - modified 0003-Disable-GRUB-video-support-for-IBM-power-machines.patch shorter commit description

[PATCH v3 12/16] 10_linux.in: Don't require a password to boot entries generated by grub-mkconfig.

2024-10-10 Thread Leo Sandoval
From: Peter Jones When we set a password, we just want that to mean you can't /edit/ an entry. Resolves: rhbz#1030176 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/grub.d/10_linux.in b/util/grub.d/10_linux.in in

[PATCH v3 11/16] Makefile.common: Add .eh_frame to list of relocations stripped

2024-10-10 Thread Leo Sandoval
From: Fedora Ninjas Signed-off-by: Peter Jones --- conf/Makefile.common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf/Makefile.common b/conf/Makefile.common index b8f216f6c..ece9ed8a1 100644 --- a/conf/Makefile.common +++ b/conf/Makefile.common @@ -41,7 +41,7 @@ CFLAG

[PATCH v3 14/16] normal/main: Try mac/guid/etc before grub.cfg on tftp config files.

2024-10-10 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- grub-core/normal/main.c | 93 ++--- 1 file changed, 49 insertions(+), 44 deletions(-) diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c index fd8be685a..973e7d733 100644 --- a/grub-core/normal/mai

[PATCH v3 03/16] ieee1275: Disable GRUB video support for IBM power machines

2024-10-10 Thread Leo Sandoval
From: Paulo Flabiano Smorigo GRUB gets the display card node address from OpenFirmware, however this address is truncated to 32-bits (OpenFirmware works on 32-bits, so GRUB) effectively getting an invalid address. This change disables the video support on IBM power machines. More details can be f

[PATCH v3 06/16] efi/init: Make efi machines load an env block from a variable

2024-10-10 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- grub-core/Makefile.core.def | 1 + grub-core/kern/efi/init.c | 34 ++ 2 files changed, 35 insertions(+) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 1571421d7..0bffbfea9 100644 -

[PATCH v3 07/16] 20_ppc_terminfo.in: Migrate ieee1275/PPC from Yaboot to Grub2

2024-10-10 Thread Leo Sandoval
From: Mark Hamzy Add configuration support for ieee1275/PPC ofconsole serial terminal. Signed-off-by: Mark Hamzy Signed-off-by: Robbie Harwood --- Makefile.util.def | 7 ++ util/grub.d/20_ppc_terminfo.in | 114 + 2 files changed, 121 insertions(+

[PATCH v3 13/16] normal/main: fw_path prefix when fallback searching for grub config

2024-10-10 Thread Leo Sandoval
From: Fedora Ninjas When PXE booting via UEFI firmware, grub was searching for grub.cfg in the fw_path directory where the grub application was found. If that didn't exist, a fallback search would look for config file names based on MAC and IP address. However, the search would look in the prefix

[PATCH v3 02/16] term/terminfo: for ppc, reset console display attr when clear screen

2024-10-10 Thread Leo Sandoval
From: Paulo Flabiano Smorigo v2: Also use \x0c instead of a literal ^L to make future patches less awkward. This should fix this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=908519 Signed-off-by: Peter Jones Signed-off-by: Paulo Flabiano Smorigo Signed-off-by: Robbie Harwood --- gr

[PATCH v3 04/16] configure.ac: Move bash completion script

2024-10-10 Thread Leo Sandoval
From: Peter Jones Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=922997 Apparently these go in a new place now. --- configure.ac | 11 +++ util/bash-completion.d/Makefile.am | 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/configure.ac

[PATCH v3 16/16] normal/main: Try $prefix if $fw_path doesn't work.

2024-10-10 Thread Leo Sandoval
From: Peter Jones Related: rhbz#1148652 Signed-off-by: Peter Jones --- grub-core/kern/ieee1275/init.c | 28 +++ grub-core/net/net.c| 2 +- grub-core/normal/main.c| 132 - 3 files changed, 81 insertions(+), 81 deletions(-) diff --git a

[PATCH v3 10/16] 10_linux.in: Add devicetree loading

2024-10-10 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones Switch to use APM Mustang device tree, for hardware testing. Signed-off-by: David A. Marlin Use the default device tree from the grub default file instead of hardcoding a value. Signed-off-by: David A. Marlin --- util/grub-mkconfig.in | 3 +

[PATCH v3 05/16] misc: Make "exit" take a return code.

2024-10-10 Thread Leo Sandoval
From: Peter Jones This adds "exit" with a return code. With this patch, any "exit" command /may/ include a return code, and on platforms that support returning with an exit status, we will do so. By default we return the same exit status we did before this patch. Signed-off-by: Peter Jones --

[PATCH v3 15/16] 10_linux.in: Generate OS and CLASS in 10_linux from /etc/os-release

2024-10-10 Thread Leo Sandoval
From: Peter Jones This makes us use pretty names in the titles we generate in grub2-mkconfig when GRUB_DISTRIBUTOR isn't set. Resolves: rhbz#996794 Signed-off-by: Peter Jones --- util/grub.d/10_linux.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/grub.d/10_linux

[PATCH v3 09/16] commands: Pass "\x[[:hex:]][[:hex:]]" straight through unmolested.

2024-10-10 Thread Leo Sandoval
From: Peter Jones Don't munge raw spaces when we're doing our cmdline escaping (#923374) Signed-off-by: Peter Jones --- grub-core/commands/wildcard.c | 16 - grub-core/lib/cmdline.c | 25 ++-- grub-core/script/execute.c| 43 ++--

Re: [PATCH v1 37/37] chainloader: Use grub_efi_...() memory helpers where reasonable.

2024-10-10 Thread Leo Sandoval
On Mon, Oct 7, 2024 at 1:44 PM wrote: > On 10/7/24 11:21 AM, Leo Sandoval wrote: > > From: Peter Jones > > > > This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and > > grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we > > get more re

Re: [PATCH v2 09/17] commands: Pass "\x[[:hex:]][[:hex:]]" straight through unmolested.

2024-10-10 Thread Leo Sandoval
On Mon, Oct 7, 2024 at 1:05 PM wrote: > On 10/7/24 11:18 AM, Leo Sandoval wrote: > > From: Peter Jones > > > > Don't munge raw spaces when we're doing our cmdline escaping (#923374) > > > > Signed-off-by: Peter Jones > > --- > > grub

[PATCH v1 26/37] 30_os-prober.in: just build chainloader entries, don't try any xnu xnu.

2024-10-07 Thread Leo Sandoval
From: Peter Jones Since our bugs tell us that the xnu boot entries really just don't work most of the time, and they create piles of extra boot entries, because they can't quite figure out 32-vs-64 and other stuff like that. It's rediculous, and we should just boot their bootloader through the c

[PATCH v1 28/37] btrfs: fix a bad null check

2024-10-07 Thread Leo Sandoval
From: Peter Jones current gcc complains: grub-core/fs/btrfs.c: In function ‘grub_cmd_btrfs_info’: grub-core/fs/btrfs.c:2745:7: error: the comparison will always evaluate as ‘true’ for the address of ‘label’ will never be NULL [-Werror=address] 2745 | if (data->sblock.label) |

[PATCH v1 29/37] btrfs: export btrfs_subvol and btrfs_subvolid

2024-10-07 Thread Leo Sandoval
From: Michael Chang We should export btrfs_subvol and btrfs_subvolid to have both visible to subsidiary configuration files loaded using configfile. Signed-off-by: Michael Chang --- grub-core/fs/btrfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/b

[PATCH v1 31/37] btrfs: grub2-btrfs-04-grub2-install

2024-10-07 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/osdep/linux/getroot.c | 7 +++ grub-core/osdep/unix/config.c | 17 +++-- include/grub/emu/config.h | 1 + util/config.c | 10 ++ util/grub-install.c

[PATCH v1 37/37] chainloader: Use grub_efi_...() memory helpers where reasonable.

2024-10-07 Thread Leo Sandoval
From: Peter Jones This uses grub_efi_allocate_pool(), grub_efi_free_pool(), and grub_efi_free_pages() instead of open-coded efi_call_N() calls, so we get more reasonable type checking. Signed-off-by: Peter Jones --- grub-core/loader/efi/chainloader.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v1 36/37] efi: Add grub_efi_allocate_pool() and grub_efi_free_pool() wrappers.

2024-10-07 Thread Leo Sandoval
From: Peter Jones Signed-off-by: Peter Jones --- include/grub/efi/efi.h | 36 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/include/grub/efi/efi.h b/include/grub/efi/efi.h index a5cd99e5a..8d98203a7 100644 --- a/include/grub/efi/efi.h +++ b/

[PATCH v1 25/37] grub.texi: Make our info pages say "grub2" where appropriate.

2024-10-07 Thread Leo Sandoval
From: Peter Jones This needs to be hooked up to --program-transform=, but I haven't had time. Signed-off-by: Peter Jones --- docs/grub-dev.texi| 4 +- docs/grub.texi| 359 ++ grub-core/kern/misc.c | 2 +- 3 files changed, 191 insertions(+

[PATCH v1 20/37] net/tcp: add window scaling support

2024-10-07 Thread Leo Sandoval
From: Josef Bacik Sometimes we have to provision boxes across regions, such as California to Sweden. The http server has a 10 minute timeout, so if we can't get our 250mb image transferred fast enough our provisioning fails, which is not ideal. So add tcp window scaling on open connections and

[PATCH v1 35/37] btrfs: Grub not working correctly with btrfs snapshots (bsc#1026511)

2024-10-07 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c | 238 +++ 1 file changed, 238 insertions(+) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index dba86d19b..87e4dd1a0 100644 --- a/grub-co

[PATCH v1 19/37] grub-set-password.in: Add friendly grub2 password config tool (#985962)

2024-10-07 Thread Leo Sandoval
From: Robert Marshall Provided a tool for users to reset the grub2 root user password without having to alter the grub.cfg. The hashed password now lives in a root-only-readable configuration file. Resolves: rhbz#985962 Signed-off-by: Robert Marshall [pjones: fix the efidir in grub-setpassword

[PATCH v1 23/37] grub-get-kernel-settings.in: Add grub-get-kernel-settings and use it in 10_linux

2024-10-07 Thread Leo Sandoval
From: Peter Jones This patch adds grub-get-kernel-settings, which reads the system kernel installation configuration from /etc/sysconfig/kernel, and outputs ${GRUB_...} variables suitable for evaluation by grub-mkconfig. Those variables are then used by 10_linux to choose whether or not to creat

[PATCH v1 27/37] btrfs: Add ability to boot from subvolumes

2024-10-07 Thread Leo Sandoval
From: Jeff Mahoney This patch adds the ability to specify a different root on a btrfs filesystem too boot from other than the default one. btrfs-list-snapshots will list the subvolumes available on the filesystem. set btrfs_subvol= and set btrfs_subvolid= will specify which subvolume to use an

[PATCH v1 24/37] backtrace: Make grub_fatal() also backtrace

2024-10-07 Thread Leo Sandoval
From: Peter Jones --- grub-core/Makefile.core.def | 3 ++ grub-core/kern/misc.c | 6 grub-core/lib/arm64/backtrace.c | 62 + grub-core/lib/backtrace.c | 2 ++ grub-core/lib/i386/backtrace.c | 14 +++- 5 files changed, 86 insertions

[PATCH v1 30/37] btrfs: grub2-btrfs-03-follow_default

2024-10-07 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang Signed-off-by: Robbie Harwood --- grub-core/fs/btrfs.c | 107 ++- 1 file changed, 76 insertions(+), 31 deletions(-) diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c index 14e38a4df..d47f9ab03 1006

[PATCH v1 32/37] btdfs: grub2-btrfs-05-grub2-mkconfig

2024-10-07 Thread Leo Sandoval
From: Michael Chang Signed-off-by: Michael Chang --- util/grub-mkconfig.in | 3 ++- util/grub-mkconfig_lib.in | 4 util/grub.d/00_header.in| 25 - util/grub.d/10_linux.in | 4 util/grub.d/20_linux_xen.in | 4 5 files changed, 38 inserti

[PATCH v1 22/37] bootp: New net_bootp6 command

2024-10-07 Thread Leo Sandoval
From: Michael Chang Implement new net_bootp6 command for IPv6 network auto configuration via the DHCPv6 protocol (RFC3315). Signed-off-by: Michael Chang Signed-off-by: Ken Lin [pjones: Put back our code to add a local route] Signed-off-by: Peter Jones --- grub-core/net/bootp.c |

  1   2   >